-
Notifications
You must be signed in to change notification settings - Fork 5
chore: enable dormant eslint rules and include .mjs in lint/format globs #823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2e70025
chore: enable unused-imports and vue/no-reserved-component-names esli…
robsongajunior ac037fe
chore(webkit): include .mjs in lint/format globs and format test .mjs…
robsongajunior 2556ee5
chore: update lint canaries for unused-imports and vue/no-reserved-co…
robsongajunior 081020a
chore: adopt globals package for eslint language options
robsongajunior File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| // CANARY — must keep failing unused-imports/no-unused-imports. | ||
| // `computed` is imported and never used — the one unused-code case | ||
| // `lint:fix` deletes automatically. | ||
| import { computed, ref } from 'vue' | ||
|
|
||
| export const count = ref(0) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| // CANARY — must keep failing @typescript-eslint/no-unused-vars. | ||
| // `computed` is imported and never used; `event` is an unused parameter | ||
| // without the `_` prefix that would mark it intentional. | ||
| import { computed, ref } from 'vue' | ||
|
|
||
| export function onSelect(event: MouseEvent, item: { label: string }) { | ||
| return ref(item.label) | ||
| // CANARY — must keep failing unused-imports/no-unused-vars. | ||
| // `orphan` is assigned and never used, without the `_` prefix that would | ||
| // mark it intentional. (Unused IMPORTS are guarded separately by | ||
| // eslint/import-hygiene/no-unused-imports.ts.) | ||
| export function onSelect(item: { label: string }) { | ||
| const orphan = item.label | ||
|
robsongajunior marked this conversation as resolved.
Dismissed
|
||
| return item | ||
| } | ||
9 changes: 9 additions & 0 deletions
9
lint-canaries/eslint/vue-correctness/no-reserved-component-names.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <script setup> | ||
| // CANARY — must keep failing vue/no-reserved-component-names. | ||
| // `Teleport` is a Vue 3 built-in component name (disallowVue3BuiltInComponents). | ||
| defineOptions({ name: 'Teleport' }) | ||
| </script> | ||
|
|
||
| <template> | ||
| <div>reserved component name</div> | ||
| </template> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.