chore(theme): delete dead css-vars/resolve token path - #808
Merged
Conversation
robsongajunior
changed the base branch from
chore/theme-fail-on-unresolved-tokenref
to
main
July 27, 2026 13:15
pauloSF0
approved these changes
Jul 27, 2026
isaquebock
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #807 (base = its branch; GitHub auto-retargets to
mainwhen #807 merges — #807 modifiesresolve.jsand this PR deletes it, so basing onmainwould guarantee a modify/delete conflict).Deletes the dead runtime CSS-vars path that #807's unresolved-
tokenRefguard exposed as rotten:scripts/css-vars.js+scripts/resolve.jsdeleted. Zero callers anywhere in the monorepo; unreachable for consumers twice over (./tokensis not in theme's v4exportsmap, and the roottokens.jsentry isn't infiles, so it never ships); its data carried 4 dangling refs (primitives.alpha.neutral.25,primitives.alpha.brand.primary.65—alphahas noneutral/brandshades). The healthy, publicly exported path (./theme-colors→compile-theme.js) does the same job.tokens/index.js: thecreateCssVars/cssVarsString/injectCssVarsre-export dropped (barrel keeps its 7 remaining exports — smoke-tested).README.md: the runtime-injection example now shows the real API (injectThemeCssfrom@aziontech/theme/theme-colors); the fictionalbuild/css-vars.js/build/resolve.jsexport listings and tree entry removed; the token-resolution example rewritten tocompileThemeVars.tokens/README.md: architecture diagram + file tree corrected (also drops the phantomtests/*.htmlharness entries and the wrong "legacy compiler" label oncompile-theme.js); the JS-API sections now documentcompileThemeVars/compileThemeCss/injectThemeCss; thetokenRefprefix table now lists the surviving resolvers' prefixes (two deleted-resolver rows dropped,theme.surfaces.*added) and states that unresolved refs fail the build — replacing the now-false "left as the raw path string" claim.semantic/colors.js:semanticColorsData's header comment no longer points at the deleted file and warns in-place that itsbackdrop/primary-maskrefs point at nonexistentalphashades — fix them before ever rewiring that data to a compiler.compile-primitives.js: header comment re-anchored frominjectCssVarstoinjectThemeCss.Second commit — full
README.mdrewrite for the v4 package (+104/−326). The old README was v2/v3-era fiction well beyond the css-vars references: a@aziontech/theme/widgettheme anddefault.js/widget.jsentries that don't exist,@aziontech/theme/tokenswithpreset/tokenUtilitiesTailwind-config examples (no preset or plugin exists;/tokensis neither exported nor shipped),textSemantic/backgroundSemantic/borderSemanticmodules that don't exist, aneutralpalette (it'sgray), wrong hex values (orange[500]is#F3652B, not#fe601f), abuild/directory tree, and asemantic-releaseversioning claim. The new README documents the real package — one Tailwind-v4 CSS import (@theme/@utility, bundled@font-face, no config step), the true five-path exports table, JS examples with values and shapes verified by introspection (curve['productive-exit'],duration['fast-02'], responsivetextsDatabundles,compileThemeVarsoutput), the real theme-switch selectors from the dist, theprepackrebuild guarantee, the actual project tree, and release-please versioning — with a pointer tosrc/tokens/README.mdas the deep reference.Verification
build:tokensgreen;dist/v4output byte-identical to the pre-chore(theme): fail token build on unresolved tokenRef #807 baseline.build:dts(publish-path vue-tsc emit) green without the deleted files.tokens/index.jsbarrel imports cleanly (7 exports);injectThemeCsspresent on./theme-colors.createCssVars/cssVarsString/injectCssVars/resolveRefsToCssVars/scripts/css-vars/scripts/resolvein code or docs.Notes
chore→ no release; net −178 lines; nothing shipped changes (the deleted API never reached the tarball).