Skip to content

fix: use @aziontech/theme/animations imports; move vue-tsc to devDependencies - #804

Merged
robsongajunior merged 4 commits into
mainfrom
fix/deep-theme-imports-vue-tsc-devdeps
Jul 27, 2026
Merged

fix: use @aziontech/theme/animations imports; move vue-tsc to devDependencies#804
robsongajunior merged 4 commits into
mainfrom
fix/deep-theme-imports-vue-tsc-devdeps

Conversation

@robsongajunior

@robsongajunior robsongajunior commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes three items from the engineering audit (2026-07-26 re-check):

Replace the 7 deep-relative theme/src imports (§4)

  • dialog, drawer, tooltip, tab-view, segmented-button, code-block presets and navigation-menu-css-vars.js all imported { curve, duration } via ../../../../../../theme/src/tokens/primitives/animations/animate.js — a path that climbs out of the published package root, so it breaks for any npm consumer (webkit ships as source).
  • All 7 now use import { curve, duration } from '@aziontech/theme/animations' — the form message/toast/pick-list already used, resolved through theme's exports map to the same module.

Move vue-tsc to devDependencies (§2)

  • It was a runtime dependency of webkit and theme's only runtime dependency, dragging vue-tsc + typescript into every consumer install. It has zero runtime usage in shipped code (checked CLI/MCP/source — comments only).
  • Publish flows unaffected: the package-*.yml Build steps and theme's prepack (build:tokens && build:dts) run after pnpm install --frozen-lockfile, which installs devDependencies.
  • Theme now ships with zero runtime dependencies.

Reconcile release types with release-please (§6)

  • The release-types contract still described semantic-release: the rule named three deleted .releaserc files, and CONTRIBUTING/commands/shipped docs promised hotfix/chore/docs/style/refactor/perf → patch — bumps stock release-please never produces (it releases only on feat/fix/breaking, and per-type mapping is not configurable).
  • All surfaces rewritten to the real semantics — feat→minor, fix→patch, breaking→major (any type), everything else → no release on its own: .claude/rules/release-types.md (full rewrite: squash-merge means the PR title is the commit release-please parses; per-package path filtering; Release-As:), CONTRIBUTING.md, /open-pr + /create-branch, git-workflow.md, deprecation.md, commitlint.config.js header comment, and the shipped docs (PROCESS.md, STYLEGUIDE.md, DOC_LINTS.md — STYLEGUIDE's stale "branch from dev" also corrected to main).
  • hotfix dropped from the commitlint enum: its name implies a release but release-please never releases it — a silent trap for exactly the most urgent commits. Zero uses in the repo's entire history; commitlint now rejects it loudly (urgent fixes are fix).

Notes

  • The PR squash-merges under a fix title → release-please cuts patch releases for webkit and theme; the imports fix is the consumer-facing repair that should ship, and the shipped-docs corrections ride along.
  • Verified: vue-tsc --noEmit passes; real-browser Vitest on the three affected component families (tooltip, navigation-menu, dialog) — 49/49 passing; lockfile change is the 4-line prod→dev move; toolkit suite (97 tests incl. the standards invariant), doc-standards and authoring ratchets all green; commitlint smoke-tested (hotfix: rejected, standard forms accepted); lint-canaries unaffected.
  • Remaining dangling .releaserc mentions (compound-api.md, component-scaffold skill, COMPONENT_REQUIREMENTS.md) describe the d.ts-at-publish mechanism — a separate cleanup, not release types.
  • No new dependencies; no API changes.

BEGIN_COMMIT_OVERRIDE
fix: use @aziontech/theme/animations imports; move vue-tsc to devDependencies
END_COMMIT_OVERRIDE

@robsongajunior
robsongajunior requested a review from a team as a code owner July 26, 2026 22:13
@robsongajunior
robsongajunior merged commit b3795d2 into main Jul 27, 2026
23 checks passed
@robsongajunior robsongajunior changed the title [NO-ISSUE] fix: use @aziontech/theme/animations imports; move vue-tsc to devDependencies fix: use @aziontech/theme/animations imports; move vue-tsc to devDependencies Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants