fix: use @aziontech/theme/animations imports; move vue-tsc to devDependencies - #804
Merged
Merged
Conversation
gdsantana
approved these changes
Jul 27, 2026
HerbertJulio
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three items from the engineering audit (2026-07-26 re-check):
Replace the 7 deep-relative
theme/srcimports (§4)dialog,drawer,tooltip,tab-view,segmented-button,code-blockpresets andnavigation-menu-css-vars.jsall imported{ curve, duration }via../../../../../../theme/src/tokens/primitives/animations/animate.js— a path that climbs out of the published package root, so it breaks for any npm consumer (webkit ships as source).import { curve, duration } from '@aziontech/theme/animations'— the formmessage/toast/pick-listalready used, resolved through theme's exports map to the same module.Move
vue-tsctodevDependencies(§2)vue-tsc+typescriptinto every consumer install. It has zero runtime usage in shipped code (checked CLI/MCP/source — comments only).package-*.ymlBuild steps and theme'sprepack(build:tokens && build:dts) run afterpnpm install --frozen-lockfile, which installs devDependencies.Reconcile release types with release-please (§6)
.releasercfiles, and CONTRIBUTING/commands/shipped docs promisedhotfix/chore/docs/style/refactor/perf→ patch — bumps stock release-please never produces (it releases only onfeat/fix/breaking, and per-type mapping is not configurable).feat→minor,fix→patch, breaking→major (any type), everything else → no release on its own:.claude/rules/release-types.md(full rewrite: squash-merge means the PR title is the commit release-please parses; per-package path filtering;Release-As:),CONTRIBUTING.md,/open-pr+/create-branch,git-workflow.md,deprecation.md,commitlint.config.jsheader comment, and the shipped docs (PROCESS.md,STYLEGUIDE.md,DOC_LINTS.md— STYLEGUIDE's stale "branch from dev" also corrected tomain).hotfixdropped from the commitlint enum: its name implies a release but release-please never releases it — a silent trap for exactly the most urgent commits. Zero uses in the repo's entire history; commitlint now rejects it loudly (urgent fixes arefix).Notes
fixtitle → release-please cuts patch releases for webkit and theme; the imports fix is the consumer-facing repair that should ship, and the shipped-docs corrections ride along.vue-tsc --noEmitpasses; real-browser Vitest on the three affected component families (tooltip, navigation-menu, dialog) — 49/49 passing; lockfile change is the 4-line prod→dev move; toolkit suite (97 tests incl. the standards invariant), doc-standards and authoring ratchets all green; commitlint smoke-tested (hotfix:rejected, standard forms accepted); lint-canaries unaffected..releasercmentions (compound-api.md,component-scaffoldskill,COMPONENT_REQUIREMENTS.md) describe the d.ts-at-publish mechanism — a separate cleanup, not release types.BEGIN_COMMIT_OVERRIDE
fix: use @aziontech/theme/animations imports; move vue-tsc to devDependencies
END_COMMIT_OVERRIDE