Skip to content

fix: [Dropdown/DropdownPanel] refinements (ENG-46740, ENG-46741) - #781

Merged
isaquebock merged 11 commits into
mainfrom
fix/dropdown-refinements-eng-46740-41
Jul 27, 2026
Merged

fix: [Dropdown/DropdownPanel] refinements (ENG-46740, ENG-46741)#781
isaquebock merged 11 commits into
mainfrom
fix/dropdown-refinements-eng-46740-41

Conversation

@isaquebock

@isaquebock isaquebock commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • ENG-46740overflow-x-hidden aplicado no __body do painel para clipar conteúdo que estourava (mantido overflow-y-auto para scroll vertical).
  • ENG-46741 — Removido mt-*/pt-* entre dropdown-groups consecutivos; separação agora é só o border-t hairline, flush com os itens.

How to test (mapeado 1:1 com Jira)

ENG-46740 — "DropdownPanel Clip Content (conteúdo estoura o painel)"

  • Storybook → Components/Navigation/Dropdown → abrir o painel.
  • Item com texto muito longo (label extenso) → conteúdo NÃO vaza para fora das bordas arredondadas do painel.
  • Conteúdo horizontal excedente é clipado; conteúdo vertical excedente continua scrollável.

ENG-46741 — "Divider deve separar sem padding"

  • Storybook → Components/Navigation/Dropdown → story com múltiplos Dropdown.Group.
  • Verificar que a separação entre grupos é uma linha hairline única, flush com os itens acima/abaixo — sem padding vertical adicional.
  • <Divider> genérico (fora do Dropdown) continua com o padding padrão — o fix é escopo do dropdown-group.

Tests

29/29 pass — vitest run dropdown.test.ts (27 pre-existing + 2 novos: clip + hairline).

@isaquebock
isaquebock marked this pull request as ready for review July 23, 2026 17:33
@isaquebock
isaquebock requested a review from a team as a code owner July 23, 2026 17:33
@isaquebock
isaquebock marked this pull request as draft July 23, 2026 17:34
@isaquebock
isaquebock marked this pull request as ready for review July 23, 2026 21:02
gdsantana
gdsantana previously approved these changes Jul 24, 2026
@isaquebock isaquebock changed the title fix: [Dropdown/DropdownPanel] refinements (ENG-46740, ENG-46741) [NO-ISSUE] fix: [Dropdown/DropdownPanel] refinements (ENG-46740, ENG-46741) Jul 27, 2026
@robsongajunior robsongajunior changed the title [NO-ISSUE] fix: [Dropdown/DropdownPanel] refinements (ENG-46740, ENG-46741) fix: [Dropdown/DropdownPanel] refinements (ENG-46740, ENG-46741) Jul 27, 2026
robsongajunior
robsongajunior previously approved these changes Jul 27, 2026
gdsantana
gdsantana previously approved these changes Jul 27, 2026
Comment thread packages/webkit/src/components/navigation/dropdown/dropdown.test.ts Outdated
@isaquebock
isaquebock dismissed stale reviews from robsongajunior and gdsantana via b7d3d77 July 27, 2026 19:59
@isaquebock
isaquebock merged commit e55906c into main Jul 27, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants