Repository navigation
Keep NeuroScope2 channel tags usable with many groups - #28
Merged
Merged
Conversation
Refactored panel height management for better flexibility and clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The General sidebar previously grew the Groups table with every electrode group and let Channel tags shrink to a few dozen pixels. Keep Groups and Channel tags independently scrollable, give the tags table at least 140 pixels, and calculate the sidebar scroll height from the same panel sizes.
Validated the layout calculations using metadata from a 257-channel session with 43 groups and 2 tags. At a 900-pixel viewport, the tags panel grew from 66 to 140 pixels and its action buttons fit in view. Also checked shorter and taller viewports and sessions with up to 32 raw time series files. Live MATLAB GUI verification is pending.