Skip to content

Backport VS Code 1.132.1 security fixes (9 advisories) [V2322571997] - #300

Draft
aderende wants to merge 1 commit into
mainfrom
sec-backport-main
Draft

Backport VS Code 1.132.1 security fixes (9 advisories) [V2322571997]#300
aderende wants to merge 1 commit into
mainfrom
sec-backport-main

Conversation

@aderende

Copy link
Copy Markdown
Contributor

Summary

Backports the microsoft/vscode 1.132.1 security fixes (PR microsoft/vscode#330308) onto our pinned 1.119.1 source, resolving the GlobalDependenciesSecurityScanFailed-main alarm / GitHub Security Advisories scan failure tracked in V2322571997.

Nine advisories affect 1.119.1 (all vulnerable range < 1.132.1). This PR covers all of them.

Patched (4 patches, 6 CVEs)

Patch CVEs
fix-block-privileged-url-payload.diff CVE-2026-70336, CVE-2026-69320 — fileless RCE via URL-controlled NODE_OPTIONS
fix-terminal-workspace-trust-bypass.diff CVE-2026-69278 — terminal Workspace Trust bypass via waitOnExit
fix-network-filter-domain-validation.diff CVE-2026-58650 (extensions.json terminal RCE), CVE-2026-69306 (agent network filter bypass via IPv4-mapped IPv6 literals)
fix-buffer-copy-extensions.diff CVE-2026-47285 — information disclosure via shared buffers

Each patch hunk was diffed against the upstream fix commits and matches byte-for-byte.

Marked N/A (3 CVEs — code path not shipped in Code Editor web/reh-web builds)

CVE Reason
CVE-2026-65675, CVE-2026-70335 Copilot — stripped via disable-copilot-features.diff
CVE-2026-59113 webContentExtractor webPageLoader is electron-main only; shipped extensionUrlHandler portion covered by fix-network-filter-domain-validation.diff

All finding IDs (CVE + GHSA) registered in patches/backported-patches.json.

Validation

  • Patches apply cleanly on all 4 targets (prepare-src.sh).
  • security-scan.sh scan-github-advisories (with semver): 0 concerning advisories, exit 0.

Follow-ups

Companion PRs backport the same set to 1.2, 1.1, 1.0.

Draft — review before marking ready.

Backports the microsoft/vscode 1.132.1 security fixes (PR #330308) to
the pinned 1.119.1 source, clearing the GitHub Security Advisories scan
failure (ticket V2322571997).

Patched (4 patches, 6 CVEs):
- fix-block-privileged-url-payload.diff: CVE-2026-70336, CVE-2026-69320
  (fileless RCE via URL-controlled NODE_OPTIONS in web remote terminal /
  environmentService)
- fix-terminal-workspace-trust-bypass.diff: CVE-2026-69278
  (terminal Workspace Trust bypass via waitOnExit)
- fix-network-filter-domain-validation.diff: CVE-2026-58650, CVE-2026-69306
  (extensions.json terminal RCE; agent network filter bypass via
  IPv4-mapped IPv6 literals)
- fix-buffer-copy-extensions.diff: CVE-2026-47285
  (information disclosure via shared buffers)

Marked N/A (3 CVEs, not present in Code Editor web/reh-web builds):
- CVE-2026-65675, CVE-2026-70335: Copilot (stripped via
  disable-copilot-features.diff)
- CVE-2026-59113: webContentExtractor webPageLoader is electron-main only

All finding IDs (CVE + GHSA) registered in backported-patches.json.
Verified: patches apply cleanly on all 4 targets; advisory scan reports
0 concerning advisories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant