Stop using the now deprecated std::is_trivial.#3819
Open
Romain-Geissler-1A wants to merge 1 commit intoaws:mainfrom
Open
Stop using the now deprecated std::is_trivial.#3819Romain-Geissler-1A wants to merge 1 commit intoaws:mainfrom
Romain-Geissler-1A wants to merge 1 commit intoaws:mainfrom
Conversation
std::is_trivial is deprecated in C++26. Using gcc 15 and C++26 yields
this warning:
/data/mwrep/res/mdw/SIOTF/internal/osp/aws_sdk/25-0-0-1/include/aws/core/utils/memory/AWSMemory.h: In function 'Aws::UniquePtr<T> Aws::MakeUnique(const char*, ArgTypes&& ...)':
/data/mwrep/res/mdw/SIOTF/internal/osp/aws_sdk/25-0-0-1/include/aws/core/utils/memory/AWSMemory.h:307:56: error: 'template<class _Tp> struct std::is_trivial' is deprecated: use 'is_trivially_default_constructible && is_triviall
y_copyable' instead [-Werror=deprecated-declarations]
307 | static_assert(!std::is_array<T>::value || std::is_trivial<T>::value,
| ^~~~~~~~~~
So do as gcc suggests, and replace it by a combination of
is_trivially_default_constructible and is_trivially_copyable.
11 tasks
Collaborator
|
yep, seems like the right thing to do, for logistical reasons i have to pull your change onto a branch on the main repo to run CI on it. will be merged in this PR #3820 Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
std::is_trivial is deprecated in C++26. Using gcc 15 and C++26 yields this warning:
So do as gcc suggests, and replace it by a combination of is_trivially_default_constructible and is_trivially_copyable.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.