Skip to content

docs(tests): use get_results in Python parallel-workflow example#197

Merged
yaythomas merged 1 commit into
mainfrom
fix/parallel-workflow-python-get-results
May 29, 2026
Merged

docs(tests): use get_results in Python parallel-workflow example#197
yaythomas merged 1 commit into
mainfrom
fix/parallel-workflow-python-get-results

Conversation

@yaythomas
Copy link
Copy Markdown
Contributor

Issue

results.get_succeeded() is not a valid method on the Python BatchResult.
The Protocol in types.py only declares get_results(), and the concrete
class in concurrency/models.py exposes succeeded(), get_results(), and
get_errors() — no get_succeeded. The handler raises AttributeError,
the durable execution fails, and the test asserting
InvocationStatus.SUCCEEDED would fail.

Follow-up to #196, which fixed the same bug in the TypeScript sibling.

Description of changes:

Replace results.get_succeeded() with results.get_results() in
examples/python/testing/examples/parallel-workflow.py.

results.get_succeeded() is not a valid method on the Python BatchResult.
The handler raises AttributeError and the durable execution fails, so the
test asserting InvocationStatus.SUCCEEDED would fail.

Use results.get_results() to mirror the TypeScript fix in #196.
@yaythomas yaythomas merged commit d7363fe into main May 29, 2026
4 checks passed
@yaythomas yaythomas deleted the fix/parallel-workflow-python-get-results branch May 29, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants