refactor(eval): address on-demand review feedback - #2007
Open
jariy17 wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2007 +/- ##
============================================
+ Coverage 96.96% 97.01% +0.04%
============================================
Files 366 366
Lines 21179 21191 +12
============================================
+ Hits 20536 20558 +22
+ Misses 643 633 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Hweinstock
reviewed
Aug 15, 2026
Hweinstock
left a comment
Contributor
There was a problem hiding this comment.
thanks for coming back to this! one question on the testing pattern, otherwise lgtm.
| return { core, stdout: io.stdout(), stderr: io.stderr() }; | ||
| } | ||
|
|
||
| async function runWithRealCore(options: LogsOptions, logger = createSilentLogger()) { |
Contributor
There was a problem hiding this comment.
should this use the fixture pattern? Might be a little harder to trigger these cases, but seems possible unless i'm missing something.
Contributor
|
is this from this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1983: makes on-demand evaluation failures easier to classify and removes review-identified noise.
Changes
ResourceNotFoundError.CloudWatchQueryErrorwith query status and ID metadata.test.each.Decisions
Evaluatecalls. Continuing after one fails could return incomplete results while appearing successful.context.spanContext.sessionIdsupports per-session filtering without changing the SDK response shape.DataSourceConfig, including CloudWatch log groups andonlineEvaluationConfigArn; on-demand feeds client-side Logs Insights.Verification