Skip to content

[DRAFT] feat(gateway): complete execution role policy management - #1990

Closed
aidandaly24 wants to merge 15 commits into
feat/gateway-iam-reconciliationfrom
feat/gateway-iam-complete
Closed

[DRAFT] feat(gateway): complete execution role policy management#1990
aidandaly24 wants to merge 15 commits into
feat/gateway-iam-reconciliationfrom
feat/gateway-iam-complete

Conversation

@aidandaly24

Copy link
Copy Markdown
Contributor

Stack

Depends on #1989. Base this PR on feat/gateway-iam-reconciliation.

Summary

  • Complete Gateway execution-role planning for API Gateway, Runtime, S3 schemas, managed Knowledge Bases, Bedrock Mantle, interceptors, custom transforms, OAuth, API keys, caller IAM, JWT passthrough, and no-auth targets.
  • Reconcile C ∪ D around Gateway and Target updates, restore C on confirmed failure, retain the transition policy on unknown outcomes, and tighten to exact D after terminal success.
  • Reconcile child deletion only after confirmed absence; remove only the generated per-Gateway policy after parent deletion; leave the IAM role and external policies untouched.
  • Add --skip-role-policy-update to Gateway, Target, and Connector updates, with preflight warnings for unknown roles and explicit customer-role handling.
  • Resolve credential-provider backing secret ARNs before policy compilation and accept standard matching aws:SourceAccount / aws:SourceArn trust conditions for recognized console roles.
  • Record asynchronous fixture response sequences so update/delete replay preserves real status transitions and IAM read-back behavior.

Verification

  • bun test --coverage: 1,217 passed, 11,182 assertions, 94.27% lines, 98.04% functions.
  • Focused Gateway/shared-IAM suite: 206 passed, 1,526 assertions.
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • git diff --check
  • bun run build
  • bun pm pack --destination /tmp/pr3-pack
  • Extracted tarball help smoke for Gateway update/delete and Target/Connector update.
  • Recorded and replayed managed Gateway update and delete lifecycles with AWS_PROFILE=deploy.

Live Matrix

Using the dedicated deploy account:

  • Shared Lambda permission deduplication, Lambda A to B replacement, and final-owner deletion.
  • S3 OpenAPI schema object access.
  • API Gateway REST API stage target.
  • Disposable Bedrock managed Knowledge Base connector.
  • OAuth and API-key provider, workload identity, and backing secret grants.
  • Request interceptor and custom transform Lambda grants.
  • No-auth, caller-IAM, and JWT-passthrough no-grant variants.
  • AgentCore Runtime IAM target.
  • Bedrock Mantle model discovery and inference grants.

Every disposable Gateway, role, managed Knowledge Base, REST API, and S3 bucket was independently confirmed absent after testing.

@github-actions github-actions Bot added the size/xl PR size: XL label Aug 13, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 13, 2026
@aidandaly24 aidandaly24 changed the title feat(gateway): complete execution role policy management [DRAFT] feat(gateway): complete execution role policy management Aug 13, 2026
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 13, 2026
@aidandaly24

Copy link
Copy Markdown
Contributor Author

Withdrawing this draft stack for scope and architecture reduction before review.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xl PR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant