-
Notifications
You must be signed in to change notification settings - Fork 72
feat(project): wire dev handler #1966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| # Environment variables for local development. | ||
| # `agentcore dev` loads this file into your agent's process. Values here | ||
| # override anything the CLI injects. This file is gitignored — keep secrets | ||
| # out of version control, but they are safe here. | ||
| # `agentcore project dev` loads this file into your agent's process. Values here | ||
| # override injected values except PORT, FASTMCP_PORT, and LOCAL_DEV, which the | ||
| # CLI owns. This file is gitignored — keep secrets out of version control. | ||
| # | ||
| # Example: | ||
| # MY_API_KEY=... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| import { describe, expect, test } from "bun:test"; | ||
| import type { PortChecker } from "../../io"; | ||
| import { PortInUseError, resolveDevPort } from "./port"; | ||
|
|
||
| const signal = new AbortController().signal; | ||
|
|
||
| describe("resolveDevPort", () => { | ||
| test.each([ | ||
| ["HTTP", 8080], | ||
| ["AGUI", 8080], | ||
| ["MCP", 8000], | ||
| ["A2A", 9000], | ||
| ] as const)("uses the %s default", async (protocol, port) => { | ||
| expect(await resolveDevPort(protocol, undefined, async () => true, signal)).toEqual({ | ||
| port, | ||
| requestedPort: port, | ||
| }); | ||
| }); | ||
|
|
||
| test("walks up from occupied defaults", async () => { | ||
| const checked: number[] = []; | ||
| const check: PortChecker = async (port) => { | ||
| checked.push(port); | ||
| return port === 8002; | ||
| }; | ||
|
|
||
| expect(await resolveDevPort("MCP", undefined, check, signal)).toEqual({ | ||
| port: 8002, | ||
| requestedPort: 8000, | ||
| }); | ||
| expect(checked).toEqual([8000, 8001, 8002]); | ||
| }); | ||
|
|
||
| test("accepts a free explicit port and rejects an occupied one", async () => { | ||
| expect(await resolveDevPort("A2A", 4567, async () => true, signal)).toEqual({ | ||
| port: 4567, | ||
| requestedPort: 4567, | ||
| }); | ||
| const occupied = resolveDevPort("A2A", 4567, async () => false, signal); | ||
| await expect(occupied).rejects.toBeInstanceOf(PortInUseError); | ||
| await expect(occupied).rejects.toThrow("lsof -i :4567"); | ||
| }); | ||
|
|
||
| test("bounds the default search", async () => { | ||
| await expect(resolveDevPort("HTTP", undefined, async () => false, signal)).rejects.toThrow( | ||
| "No free port found in range 8080-8179", | ||
| ); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.