Repository navigation
Conversation
The registration link always read "Request Access", even when new accounts are approved automatically. Pass the approval mode to login.twig and use the existing ui.register.create_account key when no approval is required. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TITLE: Login page: say "Create Account" when registration is auto-approved
Problem
The login page always labels the registration link "Request Access" (
ui.login.request_access), even when registration does not require sysop approval (BbsConfig::shouldRequireRegistrationApproval()is false) and new accounts can be used immediately.Impact
Visitors to auto-approve boards are told they must request access, which suggests a review wait that doesn't exist and discourages sign-ups.
Repair
The
/loginroute passesregistration_requires_approval, andlogin.twigpicksui.login.request_accessor the existingui.register.create_accountkey for both link locations. The template defaults to the approval wording if the variable is absent. No new translation keys; both keys exist in every locale.Proof
tests/Unit/LoginRegisterLinkContractTest.php(8 tests) fails on the current branch (4 failures) and passes with the change. The rest oftests/Unitis unchanged.