You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
add the opt-in Aura PV discovery client (CONFIG_AURA_PV) and ABI 0.1 UAPI
expose bounded discovery and arithmetic self-test ioctls through /dev/aura-pv
add the executable selftest and document the ABI and explicit limitations
Validation
drivers/virt/aura_pv.o builds with CONFIG_AURA_PV=m
selftest compiles and exits 4 when /dev/aura-pv is unavailable, as expected
m1n1 host endpoint default-off/opt-in build and contract checks pass
This PR intentionally does not claim /dev/kvm guest-run, EL1 entry, stage-2 translation, virtual interrupts, timers, or nested guest context switching. The current m1n1 host has one global stage-2/VTTBR context, so a safe per-VM protocol is still required before ABI 0.2 guest execution.
Review, not merged yet. It builds in a test merge on integration/aurora 86cb1c3 (with 731 and 856), and the header passes HDRTEST. A few things to fix first:
include/uapi/linux/aura_pv.h uses BIT_ULL() from <linux/bits.h>. The uapi linux/bits.h only has __GENMASK, so userspace that uses AURA_PV_FEATURE_* or AURA_PV_OUTPUT_* won't compile. HDRTEST doesn't catch it because nothing expands the macros. _BITULL() from <linux/const.h> works in both.
aura_pv_hvc() is hand-rolled and doesn't list x4 to x17 as clobbered. That's only safe if Aura promises SMCCC 1.1 register preservation for these function IDs. arm_smccc_1_1_hvc() would cover it, or the asm needs the clobbers. If the x19/x20 sentinels are there to check that Aura preserves callee-saved registers, the client never compares them after the call.
.compat_ioctl = aura_pv_ioctl passes a 32-bit pointer through unchanged. compat_ptr_ioctl is the usual fix.
There's no module_exit, so the module can't be unloaded, and with no modalias it never autoloads. That's fine for a diagnostic, but the docs should say it has to be loaded by hand.
asahi.config turns it on as =m for every distro kernel. It's harmless without the DT node, but the Aura side that publishes aurora,aura-kvm-pv-0 isn't merged yet (aura PR 33 is still a draft). Until it is, this would ship a module nothing can bind.
I'd hold it until the Aura host side lands and one guest run has passed on the Neo. Happy to re-run the build once it's updated.
Heads-up: #1363 (merged as 8484356) removed APIF from integration/aurora, including tools/testing/selftests/aurora-apif/. This PR still adds a test under that directory, so it needs a small fixup on rebase: move the test, or drop it if it's APIF-only.
aura #77 (merged 2026-11-07) removed the PV-KVM endpoint, the monitor and the aurora,aura-kvm-pv-0 node this client binds to, so nothing on the tip or in aura can answer /dev/aura-pv any more. The branch also no longer applies to integration/aurora 110861f: its selftest lives in tools/testing/selftests/aurora-apif/, which #1363 removed. With the host side gone this looks obsolete; if PV discovery comes back on the aura side, a fresh PR against the new interface would be the way to bring it back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
CONFIG_AURA_PV) and ABI 0.1 UAPI/dev/aura-pvValidation
drivers/virt/aura_pv.obuilds withCONFIG_AURA_PV=m/dev/aura-pvis unavailable, as expectedThis PR intentionally does not claim
/dev/kvmguest-run, EL1 entry, stage-2 translation, virtual interrupts, timers, or nested guest context switching. The current m1n1 host has one global stage-2/VTTBR context, so a safe per-VM protocol is still required before ABI 0.2 guest execution.