Repository navigation
drm/apple: test apple_typec_port_rgb8_only() - #2833
Open
RyanTheTide wants to merge 1 commit into
Open
RyanTheTide wants to merge 1 commit into
RyanTheTide wants to merge 1 commit into
Conversation
apple_typec_port_rgb8_only() decides whether a Type-C connector gets the BT.2020/PQ output properties: it must not when any pipeline that can drive the port runs the native26 (ext26) IOMFB method set, which scans out XRGB8888 only. It had no test. Make it visible to KUnit (VISIBLE_IF_KUNIT, no change for non-KUnit builds) and add topology_rgb8_only_test to the apple-dcp-topology suite. It registers four ports over a 10-bit pipeline, an ext26 one and one without drvdata, and checks: no pipelines; any pipeline with an ext26 candidate after a 10-bit one; a single pipeline counting only its own method set, including one that is not a candidate for the port; a port the ext26 pipeline cannot drive; a candidate without drvdata being skipped; a port without routes and an index past the last port. No functional change. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
Contributor
Author
|
Review at 17db3f1. The test calls the real
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
apple_typec_port_rgb8_only()(from #2783) decides whether a Type-C connector gets the BT.2020/PQ output properties: it must not when any pipeline that can drive the port runs the native26 (ext26) method set, which scans out XRGB8888 only. It had no test.Change
Make the function visible to KUnit (
VISIBLE_IF_KUNIT; builds without KUnit are unchanged) and addtopology_rgb8_only_testto the apple-dcp-topology suite. It registers four ports over a 10-bit pipeline, an ext26 pipeline and one without drvdata. It then checks the any-pipeline and single-pipeline scopes, the port-candidate filter, a candidate without drvdata being skipped, a port with no routes, and an index past the last port. No functional change.Testing
tests/topology.kunitconfig: apple-dcp-topology 7/7 (6/6 before). All suites in that config: 201 of 202 pass, with 1 skip (apple_g17_rx_util_min_testneeds CONFIG_UCLAMP_TASK, unrelated).checkpatch.pl --strict: clean.Still to run
Assisted-by: LLM (Claude:Opus 5.5)