Skip to content

arm64: dts: apple: t8122-j613: sample the speaker sense one bit clock later - #2813

Draft
satchlj wants to merge 1 commit into
aurora-silicon:integration/aurorafrom
satchlj:upstream/j613-sense-rx-delay-20261122
Draft

satchlj wants to merge 1 commit into
aurora-silicon:integration/aurorafrom
satchlj:upstream/j613-sense-rx-delay-20261122

Conversation

@satchlj

@satchlj satchlj commented Nov 22, 2026

Copy link
Copy Markdown
Member

Claude Opus 5.5 on @satchlj's behalf.

J613 takes the J615's apple,rx-delay-bclks (#2589) for its speaker sense: <1 1 0 0 0 0> on the two speaker ports, the same as t8122-j615.dts. This replaces #2104's edge-inversion property, which is closed in favour of this.

Not yet measured on J613. #2104 moved the sampling by half a bit clock (the opposite edge); this moves it by one whole bit clock, which is what J615 measured. A J613 speaker-sense row (clean V/I words with the amps running) is needed before merge; Ryan's lab rows for speaker sense would cover it.

DT only: it compiles (t8122-j613.dtb); no driver change.

Assisted-by: LLM (Anthropic:Claude Opus 5.5)

… later

The J613 amps' voltage and current sense words reach the speaker ports
late, as on the J615. Describe that with apple,rx-delay-bclks on the two
speaker ports, so the cluster capturing the sense stream samples them one
bit clock later.

Signed-off-by: Satya Benson <satya@benson.earth>
@RyanTheTide

Copy link
Copy Markdown
Contributor

One-line DT change that gives J613 the same apple,rx-delay-bclks = <1 1 0 0 0 0> as t8122-j615.dts; the speaker ports are MCA 0/1 on both boards, so the cells line up.

  • The J615 offset may not carry over directly: J613 has two amps per speaker bus, J615 three. The J613 speaker-sense row (clean V/I words with the amps running, and ideally the 0 and 2 offsets for comparison) is needed before this merges, because a misaligned sense stream gives the speaker protection wrong data.
  • Until that row exists, the commit message and the DT comment state as a fact that the J613 sense words arrive one bit clock late. Either add the row first or word them as carried over from J615.

Assisted-by: LLM (Claude:Opus 5.5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants