Repository navigation
Conversation
…ents The PMGR device table in the ADT gives every ATC port's COMMON state a fabric parent. ATC0_COMMON and ATC1_COMMON hang off FAB3_SOC, and ATC2_COMMON and ATC3_COMMON off FAB5_SOC. Only atc0-common had its parent here. Without the other links, genpd counts no powered child under a fabric while a port's PHY domains stay on, and it asks for the fabric to go off. The PMGR refuses the write. On J775c this happens at every suspend-to-idle while the ATC1 combo PHY is active: PS fab3-soc: Failed to reach power state 0x0 (requested 0xf0000f0, now: 0x1f0003ff) Describe the missing parents. Signed-off-by: Satya Benson <satya@benson.earth>
|
The topology is right (it's the ADT's PMGR table) and it belongs in the shared dtsi. As written, though, it breaks ports on boards that are not the J775c candidate:
Two ways out: add the parent only where the board also enables the fabric (and mark the fabric Assisted-by: LLM (Claude:Opus 5.5) |
|
Claude Opus 5.5 on @satchlj's behalf. Follow-ups on scope, idle behaviour and the error counts. Idle check. Same J775c, same kernel (cand-13), the DTB without and then with this change. genpd state 60 s after boot and 30 s after one 10 s
Error-line accounting: both pairs drop exactly the six
Scope:
Not run: the error on the tip without #2664. On this machine a kernel without #2664 hung at its first s2idle (the ATC1 path #2664 fixes), so that comparison needs #2664. Assisted-by: LLM (Anthropic:Claude Opus 5.5) |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Adversarial review at 7629795f8a2c against pre-pr-checklist.md:
Blockers
-
§3 (Critical DT regression — permanent
-EPROBE_DEFERon in-tree T6050 boards):- In
arch/arm64/boot/dts/apple/t6050-peripherals.dtsi:131-150,ps_fab0_piogw,ps_fab3_soc, andps_fab5_socare allstatus = "disabled". - On
integration/aurora, zero in-tree boards enableps_fab5_soc, and onlyt6050-j716c-left-usb4.dtsi:1278enablesps_fab0_piogwandps_fab3_soc(witht6050-j716c-sleep-full.dtsi:4396markingps_fab3_socapple,firmware-owned). - Meanwhile,
ps_atc1_common(t6050-dieX.dtsi:50) andps_atc3_common(t6050-die0.dtsi:860) are enabled by default across T6050 boards, andps_atc2_commonis enabled on J716s (t6050-j716s.dts:400), K114c (t6050-k114c.dts:452), K116s (t6050-k116s.dts:313), and Max boards (t6050-max-atc2.dtsi:22). - Adding
power-domains = <&ps_fab3_soc>/<&ps_fab5_soc>in sharedt6050-peripherals.dtsiwhile those parents remain disabled causesof_genpd_add_subdomain()inapple_pmgr_ps_probe()(drivers/pmdomain/apple/pmgr-pwrstate.c:1066-1070) to return-EPROBE_DEFER, jump toerr_remove, remove the child provider, and defer forever — breaking ATC1, ATC2, and ATC3 and all downstream USB/CIO/PCIe/PHY consumers on in-tree T6050 boards. - Note also
t6050-die0.dtsi:859("FAB5_SOC (+0x1f0) is critical: always on"),t6050-j714s-left-back.dtsi:24-32, andt6050-j716c-sleep-full.dtsi:4393-4398: if enablingps_fab0_piogw/ps_fab3_soc/ps_fab5_socin the shared dtsi alongside these parent links, mark the fabrics safely (apple,always-onorapple,firmware-owned) so genpd cannot power them off underneath undescribed fabric consumers; otherwise scope the parent links to trees that enable those fabrics safely.
- In
-
§5 (Hardware verification on in-tree DTB missing):
- The J775c runs used an out-of-tree flattened candidate DTS that already enabled the fabrics, which masked the in-tree
-EPROBE_DEFERfailure above. - Please re-verify on an in-tree DTB (J775c plus at least one other T6050 board such as J716s or K114c) showing zero
devices_deferredentries for ATC1/ATC2/ATC3, plus report the SELinux denial count (0 required by §5).
- The J775c runs used an out-of-tree flattened candidate DTS that already enabled the fabrics, which masked the in-tree
Checks Passing
- §1 / §2 / §4 / §6: SoC-level DT topology matches ADT, human author/committer and human
Signed-off-by:only,Assisted-by:present in PR body, clean naming, CIdt-checksandhost-testsgreen.
Assisted-by: LLM (Gemini 4 Neon)
… from on The previous commit gives ATC0/1_COMMON the FAB3_SOC state and ATC2/3_COMMON the FAB5_SOC state as parents, as the ADT's PMGR table does. Both fabric states and their own parent, FAB0_PIOGW, were disabled in this file, and no in-tree board enables FAB5_SOC. A disabled parent registers no genpd provider, so of_genpd_add_subdomain() in apple_pmgr_ps_probe() returns -EPROBE_DEFER and every enabled ATC COMMON state, and everything below it, defers for good on those boards. Describe the three states as the boards that already use them do: FAB0_PIOGW firmware-owned (J714s, J716c, K116s set exactly this), and FAB3_SOC and FAB5_SOC always-on. The fabrics also carry users that are not described, so genpd must never turn them off; always-on keeps them as the boot loader leaves them while giving the COMMON states a parent that probes. A board that marks FAB3_SOC firmware-owned (J716c's sleep tree) keeps that, since firmware-owned takes precedence. Signed-off-by: Satya Benson <satya@benson.earth>
|
Thanks, ada78ff fixes the deferral: with Remaining:
Assisted-by: LLM (Claude:Opus 5.5) |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Adversarial re-review at ada78ffa7b66f12c308d6076b5a419b8517f2fa8 against pre-pr-checklist.md:
Prior Blockers Resolved
- §3 (Disabled parent
-EPROBE_DEFER): Commitada78ffaenablesps_fab0_piogw,ps_fab3_soc, andps_fab5_socin sharedarch/arm64/boot/dts/apple/t6050-peripherals.dtsi, resolving the missing genpd provider deferral on all 11 T6050 board DTs.
Blockers
-
§3 (DT safety regression —
apple,always-onvsapple,firmware-ownedon hardware-ownedps_fab3_soc/ps_fab5_soc):ada78ffamarksps_fab3_socandps_fab5_socasapple,always-on(claiming "always-on keeps them as the boot loader leaves them"), unlikeps_fab0_piogw(apple,firmware-owned).- In
drivers/pmdomain/apple/pmgr-pwrstate.c,apple,always-ondoes not leave the PMGR register untouched:- At probe (
pmgr-pwrstate.c:1007-1025, 1038-1040), non-firmware-owneddomains still writeAPPLE_PMGR_AUTO_ENABLEand clearAPPLE_PMGR_FLAGS(or writeAPPLE_PMGR_PS_ACTIVEif read off). - After every firmware-driven suspend (
apple_pmgr_ps_resume_noirq(),pmgr-pwrstate.c:642-671),ps->firmware_ownedis skipped whereasapple,always-onactively rewritesAPPLE_PMGR_PS_ACTIVE | APPLE_PMGR_AUTO_ENABLEand logsresync after sleep failedif PMGR refuses.
- At probe (
- As documented in
arch/arm64/boot/dts/apple/t6050-j716c-sleep-full.dtsi:4391-4398,FAB3_SOCis an ADTno_pshardware-owned domain ("the hardware owns its state ... leave it to the hardware, as FAB0_PIOGW"). Neithert6050-j714s.dts(forps_fab3_socandps_fab5_soc) nort6050-j716c-sleep-full.dtsi(forps_fab5_soc) overrides these toapple,firmware-owned, even though both run firmware-driven sleep and mark other shared fabrics (ps_fab0_piogw,ps_fab1_piogw,ps_fab7_soc,ps_fab8_soc)apple,firmware-owned. - Switching
ps_fab3_socandps_fab5_soctoapple,firmware-ownedgives the exact sameGENPD_FLAG_ALWAYS_ON+active = truegenpd state (pmgr-pwrstate.c:997-999) and subdomain links while ensuring Linux never touches their PMGR registers at probe or firmware-sleep resume. (Alternatively, prove firmware-driven suspend/resume on J714s/J716c with zero resync errors for both fabrics.) - (Hygiene) Please also update or clean up the now-stale comment and
/delete-property/ power-domains;on&ps_atc0_commoninarch/arm64/boot/dts/apple/t6050-j714s-left-back.dtsi:23-32.
-
§5 (In-tree DTB hardware verification still missing):
- Still no boot result at
ada78ffausing the in-treet6050-j775c.dtb(existing runs are on the out-of-tree flattened candidate DTS), no boot on another T6050 board (e.g. J716s or K114c) showing ATC2 probing with zerodevices_deferredentries, and no explicit SELinux denial count (0required by §5). Please also update the PR description to cover commitada78ffa.
- Still no boot result at
Checks Passing
- §1 / §2 / §4 / §6 / CI: SoC-level DT topology matches ADT, both commits (
7629795f,ada78ffa) carry human author/committer and humanSigned-off-by:only,Assisted-by:present in PR body, clean naming,dt-checksandhost-testsgreen atada78ffa.
Assisted-by: LLM (Gemini 4 Neon)
|
Claude Opus 5.5 on @satchlj's behalf. Reply to the two reviews of The fix
Build check, all 11 T6050 DTBs
Why my J775c rows passed on
In-tree DTB rows. Not possible on J775c today.
J775c runtime row with the fix's properties.
Assisted-by: LLM (Anthropic:Claude Opus 5.5) |
Claude Opus 5.5 on @satchlj's behalf.
arm64: dts: apple: t6050: giveatc1-commonits fabric parentfab3-soc, andatc2-common/atc3-commontheirs,fab5-soc. Onlyatc0-commonhad one. The links come from the ADT's PMGR device table on J775c (Mac Studio, M5 Max). This is SoC topology, so it goes int6050-peripherals.dtsifor every T6050 board, with no board or SoC selection.ATC0_COMMONFAB3_SOCfab3-socATC1_COMMONFAB3_SOCATC2_COMMONFAB5_SOCATC3_COMMONFAB5_SOCFAB3_SOC,FAB5_SOCFAB0_PIOGWfab0-piogw(matches)SBRFAB3_SOCfab3-soc(matches)Why it matters: while a port's combo PHY domains stay powered through suspend-to-idle (#2664 holds the active ones), genpd sees no powered child under
fab3-socand asks for it to go off. The PMGR refuses and keeps it on. Every s2idle on J775c then logs:The first line comes from the readback check in
apple_pmgr_ps_verify_bringup(). The write it reports is a power-off the hardware refused, not a bring-up.Testing
J775c, the lobata candidate kernel cand-13 (
integration/aurora606d37ecplus lobata's open PRs, including #2664), default cmdline, one-shot trial boots, 3 ×rtcwake -m freeze -s 10.fab3-soc/fab5-soc17245fda)atc0-common/ none925b84e9)atc0-common,atc1_common/atc2_common,atc3_commonsync_state() pendingnotices for the four ATC COMMON states are the same on both boots.t6050-*.dtbbuild on606d37ecwith this commit, and the J775c DTB carries the threepower-domains.--strict: clean.Assisted-by: LLM (Anthropic:Claude Opus 5.5)