Repository navigation
arm64: dts: apple: t8132-j773g: wire pmc_dispext0/1 interfaces (4K@120Hz bandwidth) - #2761
DjDeveloperr wants to merge 1 commit into
Conversation
|
Reviewed the top commit (9bc2bc9) only; the rest is #2541. The fix is right and the numbers make the case: with the PMC interfaces as second parents of the dispext FE domains, the BWR/boost enables come up at boot ( One request: this is now the second copy of the same wiring ( Assisted-by: LLM (Claude:Opus 5.5) |
9bc2bc9 to
d86ac07
Compare
|
Updated top commit to
Assisted-by: LLM (Gemini:4 Neon) |
9952e46 to
bc0067c
Compare
…132.dtsi On T8132, the PMC ignores an external display pipe's bandwidth request (BWR) and display-clock boost votes while its interface enable bits in 0x3828ac020 (bwr_enable) and 0x3828ac028 (boost_enable) remain clear (drivers/pmdomain/apple/pmc.c). Previously only t8132-j713-j715.dtsi wired pmc_dispext0 and pmc_dispext1 into ps_dispext0_fe and ps_dispext1_fe, leaving J773g (as well as J604 and the M4 iMacs) unconnected and cutting available DRAM bandwidth in half under a 4K@120Hz pipe (51.54 GB/s vs 102.54 GB/s). Move the shared <&pmc_dispext0> and <&pmc_dispext1> second power-domain parent wiring for &ps_dispext0_fe and &ps_dispext1_fe into t8132.dtsi (keeping &ps_dispext0_sys at index 0 so apple_pmgr_ps_hold_parents() enables pmc_dispext0 cleanly even when ps_dispext0_fe starts active from iBoot, while leaving t8132-platform-data.dts unaffected because it includes only t8132-memory.dtsi), and drop the per-board copy from t8132-j713-j715.dtsi. On t8132-j773g.dts, point &framebuffer0 at <&ps_dispext0_sys> instead of <&ps_dispext0_fe> so simpledrm still binds early when CONFIG_APPLE_PMP=m (apple-pmc defers until apple-pmp binds); ps_dispext0_fe is apple,always-on and never powered off by genpd. Signed-off-by: Diljit Singh <hey@djdev.me>
d86ac07 to
b76381c
Compare
Summary
Stacked on #2541 (
djdev/j773g-272-dcpext0).On T8132, the PMC ignores an external display pipe's bandwidth request (BWR) and display-clock boost votes while its interface enable bits in
0x3828ac020(bwr_enable) and0x3828ac028(boost_enable) remain clear (drivers/pmdomain/apple/pmc.c).t8132-j713-j715.dtsiwirespmc_dispext0andpmc_dispext1intops_dispext0_feandps_dispext1_fe, whereast8132-j773g.dtsleft them unconnected — leavingdispext0BWR/boost off at4K@120Hz(perf_state=5) and halving available DRAM bandwidth across both GPU and CPU.<&pmc_dispext0>and<&pmc_dispext1>as the second power-domain parent of&ps_dispext0_feand&ps_dispext1_fe, keeping&ps_dispext0_sysat index 0 (matchingt8132-j713-j715.dtsi).&framebuffer0at<&ps_dispext0_sys>instead of<&ps_dispext0_fe>sosimpledrmstill binds early whenCONFIG_APPLE_PMP=m(apple-pmcdefers untilapple-pmpbinds);ps_dispext0_feisapple,always-onand never powered off by genpd.Hardware Verification (M4 Mac mini J773g, macOS 27.2 / 26B123)
7.3.0-ARCH-m4prod1,dcp61-m4prod1-full, zero/dev/memwrites):/sys/kernel/debug/apple-pmc/382800000.power-management/statuscomes up automatically at boot withbwr enable: 0x00000018 (saved 0x00000000)andboost enable: 0x00000007 (saved 0x00000001)(0deferred devices).dcp55, J773g 26B123):bwr_enable=0x00): GPU DRAM BW51.54 GB/s, CPU 4P BW45.59 GB/s.bwr_enable=0x18,boost_enable=0x07): GPU DRAM BW100.39 GB/sin-place and102.54 GB/safter re-modeset (+9.8% over native macOS 27.293.42 GB/s), CPU 4P BW97.70 GB/s.scripts/checkpatch.pl --strict:0 errors, 0 warnings, 0 checks.t8132-j773g.dtbbuilds cleanly.Assisted-by: LLM (Gemini:4 Neon)