Repository navigation
Conversation
…work The T8122 sleep controller's data on the shared Apple sleep framework, selected by its compatible, its DT node, and the driver hooks it needs (macsmc, asahi g17). The SoC is marked untested, so the framework keeps its commit off as for every untested SoC; this adds no module parameter and no board or firmware-version selection. Signed-off-by: Satya Benson <satya@benson.earth>
…not armed Drop the J613 prefix from the driver's messages and the comment that named a removed parameter. Signed-off-by: Satya Benson <satya@benson.earth>
|
Claude Opus 5.5 on @satchlj's behalf. Asking for a boot of this exact head (2465452) on a T8122 board from Ryan's lane (J615), default command line: does it boot to userspace, and does the sleep controller probe ( What I see on J613 so far: booting this tree from RAM through the Aura chainload trial (an integration/aurora-tip kernel, with or without this PR's changes on top, under the fixed trial DT or the tree's own t8122-j613.dtb) resets the board about 3 minutes after the chainload starts, right at Aura's hand-over, with no Linux console output at all. Kernels on the older diagnostic base boot the same way with full output. So this may be a base-tree issue on that boot path rather than this PR; a normal installed boot on J615 would separate the two. |
|
Read at 2465452. Splitting the gates out of #2572 was the right move, and the selection is now the sleep node's compatible only. The register data is your own measurement of a macOS sleep on the J613, so it's fine to have in the tree. My concern is with what lands, not where the numbers came from:
My suggestion: keep this as a draft beside #2572 and merge it together with the commit enablement once a J613/J615 resume is shown, with the witness reduced to what the working sleep logs. Until then, a default-cmdline boot showing the dry run refuses cleanly on J613 and J615 (nothing written, no new errors) is the row this head still owes. Assisted-by: LLM (Claude:Opus 5.5) |
…ith the node The help still said the driver binds only on J613; the match is the sleep controller's compatible. Signed-off-by: Satya Benson <satya@benson.earth>
…nd say the bound is not measured The 3 s only limits how long .prepare waits before it refuses; a GPU still on refuses the sleep and nothing is forced. Signed-off-by: Satya Benson <satya@benson.earth>
…l branch Drop the four-point witness against macOS's commit words (the power-word and macOS tables, the coprocessor control reads, the debug-console dump and its progress marks): it is qualification instrumentation, not part of the sleep. The DISP_CPU refusal and the per-SoC power lists stay. Signed-off-by: Satya Benson <satya@benson.earth>
|
Claude Opus 5.5 on @satchlj's behalf. Status on your four points (head 4891dfe):
On the boot row this head owes: J613 RAM-trial boots of tip-based kernels are now run with the SEP initcall blacklisted (the tip's SEP driver has no read-only xART mode), confirmed per row by the SEP platform device being absent. That row will therefore not be the default command line, and it cannot cover a suspend with the SEP bound; I'll say so with the result. |
|
Claude Opus 5.5 on @satchlj's behalf. J613 boot row on #2746 (RAM boot, SEP disabled, disk read-only): the driver bound, deep sleep was offered with The trial delta, so the row isn't read as a default-config result:
So on a default build this PR doesn't bind on J613, which matches its Kconfig help. Default-cmdline behaviour isn't shown by this row. |
|
Claude Opus 5.5 on @satchlj's behalf. One more gap for J613, beyond the disabled node: with the sleep node enabled in the tree's own |
The T8122 sleep driver's probe needs the display coprocessor it lowers (apple,display-coprocessors) and the port controller behind the debug port (apple,debug-port). Without them, enabling the node on J613 fails with -ENODEV. The node itself stays disabled in t8122.dtsi. Signed-off-by: Satya Benson <satya@benson.earth>
|
Claude Opus 5.5 on @satchlj's behalf. Pushed a4905c2: On "disabled in qualification": this isn't meant as a gate. The node and |
|
Re-review of a4905c2. Earlier points:
New:
Assisted-by: LLM (Claude:Opus 5.5) |
Claude Opus 5.5 on @satchlj's behalf.
The gate-free part of #2572: T8122's firmware-sleep data on the shared Apple sleep framework, its
apple,t8122-sleepnode int8122.dtsi, its Kconfig and KUnit coverage, and the macsmc and asahi g17 sleep hooks it needs.Selection. The sleep controller's compatible alone. No board match, no firmware-version check, no module parameter: the trial knobs from #2572 (
t8122_wdt_secs,t8122_wdt_clear,t8122_disp_off,t8122_console,t8122_keep_debug_link,t8122_witness_full,t8122_witness_sep_asc,t8122_match,t8122_atc_off,t8122_wake_mask,t8122_quiet,t8122_dry_regs, and the framework's newuntested_hold) are fixed at their defaults.Behaviour. The SoC is marked untested, so the framework keeps its sleep commit off, as for every untested SoC: a firmware sleep runs the dry path and returns. Nothing commits on the default command line, on any T8122 board (J433, J434, J504, J613, J615).
Not in this PR. The DCP cold stop keyed on the 26.6 firmware and the commit enablement stay in #2572 (draft) until a real resume works on J613. Today every trial commit there ends in a watchdog cold reset, and whether the SoC powers down after the commit is still being measured.
Testing. Built with W=1 for arm64 (
drivers/soc/apple/,drivers/mfd/,drivers/gpu/drm/asahi/), no errors. Not yet booted in this exact form; a default-cmdline boot and dry-run sleep on J613 is the next step.Assisted-by: LLM (Anthropic:Claude Opus 5.5)