Repository navigation
Conversation
|
The DT side matches t8132-j604.dts and aurora-silicon/aura#429: the J715 gets
Assisted-by: LLM (Claude:Opus 5.5) |
|
Thanks for the review. A J715 booted with the MTP left running. What I can say today, from source and from this unit:
Merge order: added to the description. This needs aurora-silicon/aura#429 in the shipped aura; with aura main alone, the J715 keeps its current MTP fault. |
249a224 to
8b51ad4
Compare
|
The J715 boot through U-Boot is done. It corrects one point of my earlier reply. Setup. J715, OS firmware 26.6.2, stage 1 → aura → U-Boot → Linux:
Two boots, differing only by one line in U-Boot. U-Boot was kept off NVMe, and the kernel came from the boot.bin (details in the U-Boot PR).
Correction. I wrote that with U-Boot in the chain "Linux should again get a halted MTP on stream 0". That part holds: the loader's halted filter and this tree's stream 0 layout were fine in both boots, with no DART faults. But a halted MTP is not a fresh one. The MTP firmware does not survive a second start, exactly as on the J604 (aurora-silicon/u-boot#44), so a U-Boot that runs it first breaks the keyboard and trackpad. The fix belongs in U-Boot, the same one-line change as u-boot#44: aurora-silicon/u-boot#69. With it, this tree works through U-Boot as it does without. The running-MTP case you asked about is still untested. This tree assumes a halted MTP. A boot that hands it over running would need the J713's stream 1 layout. That can't come from stage 1 → aura → Linux on 26.6.2, nor from U-Boot with the fix above. It would come from iBoot on other firmware, or from a U-Boot live handoff such as aurora-silicon/u-boot#57. I've added this to the commit message and force-pushed it (message only, no code change). |
|
Thanks for the U-Boot row and the correction. 8b51ad4 has the same tree as before (message only), so our earlier read stands. The keyboard loss is the U-Boot side's to fix (aurora-silicon/u-boot#69). I suggested there that it key on this tree's halted-handoff property rather than adding the J715 to a board list, so this PR and that one line up without another table entry. Assisted-by: LLM (Claude:Opus 5.5) |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Adversarial review at head 8b51ad43a3d7b9154e2ebd1676a828eb25f37ec0 against pre-pr-checklist.md: Request changes — the devicetree change itself is clean and matches t8132-j604.dts, but there is a §6 naming violation in both the DTS comment and the commit message, and CI has not yet run.
Blocker
- §6 Naming (hard rule —
arch/arm64/boot/dts/apple/t8132-j715.dts:24& commit message):pre-pr-checklist.md§6 requires Aurora paths and names, notAsahiorm1n1.- Both the new comment in
arch/arm64/boot/dts/apple/t8132-j715.dts:24and the commit message of8b51ad43writem1n1 stage 1 -> aura -> Linux. (The PR description already usesstage 1 -> aura -> Linux, andt8132-j604.dtshas nom1n1reference.) - Please drop
m1n1from both the DTS comment and commit message (e.g.,stage 1 -> aura -> Linuxoraura stage 1 -> stage 2 -> Linux).
Technical, Policy & §5 Check
- DT correctness & §1 / §2 / §3: Matches
t8132-j604.dts(chosen/linux-enablement-mac,dapf-halted-handoff = "/arm-io/mtp",&mtp_dartapple,remap-streams = <1 0>, <2 0>, <3 0>,&mtpand&mtp_hidiommus = <&mtp_dart 0>). Default cmdline, board-scoped DT only, and pairs withaurora-silicon/aura#429(which removes the board list in aura). The U-Boot second-start crash (aurora-silicon/u-boot#69), running-MTP caveat, andaura#429merge order are clearly documented. - §4 Attribution: Clean — human author/committer (
Kazuhide Takahashi) andSigned-off-by:only. - CI (needs run): Both fork workflow runs (
Host tests,Device tree checks) on8b51ad43are currentlyaction_requiredawaiting maintainer approval; please ensureDevice tree checks/Host testsrun green after the naming update. - §5 Evidence (minor completeness): The direct and U-Boot J715 hardware rows confirm MTP cold-start, keyboard/trackpad, audio/display/GPU, and 0 DART faults; please also include the kernel build/version and the standard §5 regression counts (
0 SELinux denials,0 failed units,0 new kernel errors) in the PR description.
Assisted-by: LLM (Gemini 4 Neon)
When the device tree names the MTP (/arm-io/mtp) in /chosen linux-enablement-mac,dapf-halted-handoff, the earlier stage hands it to the OS halted and Linux cold-starts it. U-Boot's MTP keyboard probe starts it first and stops it again at OS entry, and the firmware does not survive the second start: on the J715 (MacBook Air 15-inch, M4), Linux's RTKit init is followed 0.3 ms later by "co-processor has crashed", the same data abort as on the J604, and the internal keyboard and trackpad are gone. Refuse the keyboard whenever the tree says so, instead of listing boards. The J604's tree has the property, so its entry goes; the J715's gets it from aurora-silicon/linux#2745. The J813 and T6050 keep theirs, since their trees don't name the MTP there. U-Boot then has no internal keyboard on these boards, and Linux gets a firmware nobody ran. Tested on a J715 (OS firmware 26.6.2) with the #2745 tree: with aurora-wip as is, the MTP crashes in Linux; with this change, "MTP Says Hello" and the keyboard and trackpad work. Signed-off-by: Kazuhide Takahashi <kazuhide.t@linux-powered.com>
Without U-Boot (stage 1 -> aura -> Linux), nothing keeps the J715's MTP running, so Linux cold-starts it. As on the J604, name /arm-io/mtp in linux-enablement-mac,dapf-halted-handoff so the loader programs its DART filter as for a halted consumer, and put the MTP and its HID on DART stream 0 (streams 1 to 3 remapped to 0) instead of the stream 1 the J713's running MTP is handed over on. Before this, the MTP firmware's first access faulted with "CTE invalid" and the keyboard and trackpad never came up. With U-Boot in the chain, U-Boot has to leave the MTP alone, as on the J604: if it starts the MTP for its keyboard, it stops it again before Linux, and the firmware crashes on Linux's second start. Linux still finds it halted on stream 0. A boot that hands the MTP over running, as the J713 does, would need the J713's stream 1 layout instead. Neither stage 1 -> aura -> Linux on 26.6.2 nor U-Boot with the J715 in its keyboard skip list does that, and it has not been tested. Tested on a J715 with OS firmware 26.6.2 and aura main plus aurora-silicon/aura#429: the MTP says hello, and the keyboard and trackpad work, with no DART faults. Through U-Boot aurora-wip with the J715 in that skip list: the same. Through U-Boot aurora-wip as is: the MTP firmware crashes as on the J604. Signed-off-by: Kazuhide Takahashi <kazuhide.t@linux-powered.com>
8b51ad4 to
0388405
Compare
|
Thanks for the review.
|
|
Re-checked at 0388405. Against 8b51ad4 the only change is the one DTS comment line, and the commit message no longer mentions m1n1, so the DTB is the one I reviewed. Thanks for listing the counts as they are. One question about the test kernel. The rows ran on integration/aurora 0abc2f3 plus local J715 changes in four files, one of them the AIC driver. The MTP cold start and the keyboard depend on its interrupts, so could you say what the local AIC change does, and whether the MTP comes up the same without it? If the J715 needs any of those four changes to boot from integration/aurora, a link to where they are going would help. That way the row can be repeated on a plain tree once they land. Assisted-by: LLM (Claude:Opus 5.5) |
On a J715 (15-inch M4 Air) booted stage 1 → aura → Linux, the MTP is stopped when Linux takes over, as on the J604. This mirrors
t8132-j604.dts:/chosen:linux-enablement-mac,dapf-halted-handoff = "/arm-io/mtp", so aura programs dart-mtp's filter as for a halted consumer;&mtp_dart:apple,remap-streams = <1 0>, <2 0>, <3 0>;&mtpand&mtp_hid:iommus = <&mtp_dart 0>.Without it, the MTP firmware's first access faults ("CTE invalid") and the keyboard and trackpad stay dead.
Tested on a J715, OS firmware 26.6.2, aura main 58e712b9 with aurora-silicon/aura#429 (the T8132 board list dropped from
dapf_init_fdt()):AppleMTPFirmwareMac-5340.61.4), no DART faults;This replaces the board exception proposed in aurora-silicon/aura#430. J715 report: #2663.
Merge order: this needs aurora-silicon/aura#429 in the shipped aura, and the two should land together. With aura main alone, the board list skips the J715, and the MTP faults as it does today. That is not a regression.
Kernel and regression counts. The kernel is the J715's everyday build,
7.3.0-j715-aurora+. It isintegration/aurora0abc2f3 with local J715 bring-up changes in four files (EFI earlycon, the Apple DRM driver, the GPUhw.rs, the AIC driver), none of them in this PR. The DTB is this PR's tree. Counts from the three recorded boots (direct, through U-Boot with aurora-silicon/u-boot#69's fix, and through unpatched U-Boot):j713-owner-assets.serviceandm4-j715-backlight.service. Both are local services of this install (speaker filter assets and a backlight guard) and fail the same way without this change.error above:avd ... probe with driver avd failed with error -2(no AVD firmware).hid-generic ... device has no listeners.apple-dcp ... external DCP not handed over.