Repository navigation
thermal: apple-pmp: ride out long dark spans while the SoC is idle - #2720
Closed
RyanTheTide wants to merge 3 commits into
Closed
RyanTheTide wants to merge 3 commits into
RyanTheTide wants to merge 3 commits into
Conversation
The M4 PMP session's pieces, its power-vote bridge, its telemetry and thermal policy and the PMP report's readiness, run only on the Airs and on macOS 26.6.2 firmware: apple_t8132_firmware_path() compares the boot loader's os-fw-version with "26.6.2". On the M4 Mac mini (J773g) on macOS 27.2 there is then no thermal zone, no telemetry, and no vote bridge, so the G16 driver's apple_pmp_j713_gpu_prepare() refuses the PMP session and the GPU can't come up. None of these pieces depends on the OS firmware's version any more. Each takes what it needs from the PMP firmware itself: - the data segment from the image's header, which the PMP driver now checks at probe; - the temperature records by name; - the IOP power handshake the firmware starts; - each registry entry's length as the firmware registered it. The vote bridge still checks its soc-device record in the firmware's tunables. Add apple_t8132_pmp_path(), every T8132 Mac, and use it for those pieces in place of the version gate. apple_t8132_firmware_path() stays for the display, DART, PMGR and boot-handoff paths, which this does not touch. Signed-off-by: Diljit Singh <hey@djdev.me>
…M4 firmware t8132_platform_handoff() returns early unless the boot loader reports macOS 26.6.2 firmware, or the Mac is an Air. On other firmware, macOS 27.2 among them, it applies neither of its two parts: - The PMGR ownership policy. Without it Linux owns every power domain in the board tree, with auto-PM written to each one at probe, including the domains 26.6.2 keeps firmware-owned (AIC, GPIO, display) or out of Linux's reach. On the M4 Mac mini (J773g) on 27.2 that ends in an SError when the PCIe controller probes. - The memory nodes (MCC, PMC and CLPC) for a loader tree that lacks them. They depend on the PMP path, which now runs on every M4 firmware. Both describe the SoC, not one firmware, and the copy adds only nodes the loader's tree doesn't have. Apply them on every T8132. Signed-off-by: Diljit Singh <hey@djdev.me>
On the 27.2 firmware a cool, idle J713 keeps all six PMP sensors invalid far longer than the 2 s hold sized from 26.6.2 (0.46 s worst case there): sampled at the driver's own 100 ms, 86% of samples were all-dark and the longest span was 13.3 s. Each span past 2 s latches the minimum CPU caps again, and the recovery climbs back over seconds, so the machine spends most of its time well below its clocks. Keep going from the last cool reading for up to 30 s, but only while the SMC's measured P, E and GPU rails, read within the last 1.5 s, add up to under 500 mW. A dark cluster is powered down; the rail reading is the independent proof that nothing is drawing power while the sensors are dark. The 2 s hold and every other limit are unchanged. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
DjDeveloperr
force-pushed
the
djdev/t8132-pmp-272
branch
from
November 21, 2026 17:31
12aea2b to
d3a8923
Compare
Contributor
Author
|
A checklist note on the selection (not a blocker). The firmware-version gate going away is the right direction. Its replacement,
Assisted-by: LLM (Claude:Opus 5.5) |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the idle dark-span hold for the M4 Air (J713) on the macOS 27.2 firmware. It is one commit, stacked on #2533 (head 12aea2b), which no longer carries it.
With #2533 alone, an idle J713 stays on the minimum CPU caps. Its sensors go dark much longer than the 2 s hold, so every long span returns
-61and brings the caps back. The hardware row is in #2533 (comment): 462-61in 150 s, and cpu0 delivered 903 MHz.The commit holds the last cool reading for up to 30 s, but only while the SMC's measured P+E+GPU rails, read within the last 1.5 s, total under 500 mW. The 2 s hold and every other limit stay as they were. On Macs with a fan, #2533 turns off the rail budget, so no rail reading is recorded there and only the 2 s hold applies.
The same code (identical diff) is in the J713's default kernel today: 0
-61, caps 4464000/2892000, and the clocks reach every OPP. It also passed fanless all-core soaks of 10 and 30 min and 75+ warm reboots.Numbers and method
-61in 150 s, caps 912000/900000.-61, caps 4464000/2892000, cpu0 4447.8 MHz, cpu1 2883.0 MHz.Assisted-by: LLM (Claude:Opus 5.5)