Repository navigation
Conversation
Commit 78d979d ("docs: add AI Coding Assistants documentation") asked contributors to add an Assisted-by tag to patches developed with help from an LLM, and commit 816d999 ("coding-assistants: simplify attribution") later reduced the tag to "Assisted-by: LLM". A proposal to drop the tag was turned down in July [1]. The main argument for keeping it was that maintainers wanted a signal that a patch was LLM-assisted, so that they could review it accordingly. The tag came up again at the 2026 Maintainers Summit [2]. Roughly 10% of the 18,533 non-merge commits in 7.3 through -rc7 carry an Assisted-by tag, while actual LLM use is far more widespread. Some contributors do not know about the rule, others leave the tag off on purpose, and few maintainers ask about it. As a result, the tag does not provide the signal it was kept for: its absence says nothing about how a patch was made, and for developers who use these tools for almost everything, its presence says little more. The choice was between finding a way to enforce the requirement and dropping it, and there was a strong, though not unanimous, consensus in the room to drop it. Greg Kroah-Hartman, who argued for keeping the tag in July, supports removing it now [3]. Maintainers do still want to know how a patch was created, but the view at the Summit was that this belongs in the cover letter, where it can describe how the tools were used, rather than in the changelog. Documentation/process/generated-content.rst already asks contributors to be transparent about tool use and is not changed here. The rules on the DCO and on the submitter's responsibility for the patch stay as they are. Remove the Assisted-by sections from coding-assistants.rst, submitting-patches.rst, and the Italian, Brazilian Portuguese and Traditional Chinese translations, and drop the handling of the tag from checkpatch. [1] https://lore.kernel.org/workflows/2026070224-unholy-commode-cf45@gregkh/ [2] https://lwn.net/Articles/1099594/ [3] https://lore.kernel.org/all/2026101327-cupid-legal-6cf6@gregkh/ Acked-by: Lorenzo Stoakes (ARM) <ljs@kernel.org> Reviewed-by: Kees Cook <kees@kernel.org> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org> Reviewed-by: Jeff Layton <jlayton@kernel.org> Reviewed-by: Jori Koolstra <jkoolstra@xs4all.nl> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Acked-by: SJ Park <sj@kernel.org> Acked-by: David Hildenbrand (Arm) <david@kernel.org> Acked-by: Mark Brown <broonie@kernel.org> Acked-by: Daniel Pereira <danielmaraboo@gmail.com> Acked-by: Shuah Khan <skhan@linuxfoundation.org> Acked-by: Weijie Yuan <wy@wyuan.org> Reviewed-by: Miguel Ojeda <ojeda@kernel.org> Signed-off-by: Jonathan Corbet <corbet@lwn.net> Message-ID: <20261013121501.3738437-1-sashal@kernel.org> [ Backport to the 7.3 base: the pt_BR files and the zh_TW Assisted-by section are not in 7.3, so those hunks are dropped. ] (cherry picked from commit 1e035297ffdadf2184c3c773b8c098e372324aaf) Signed-off-by: Kyle Arrington <kyle@arrington.co>
Reviews here ask for the disclosure as the last line of the pull request description, in the form "Assisted-by: LLM (<Vendor>:<Model>)", and for commits that carry only the human Signed-off-by. Nothing in the tree said so: until the previous commit, coding-assistants.rst asked for an Assisted-by tag in the commit itself. Mainline now leaves the disclosure to the cover letter, and a pull request description is this tree's cover letter. Write down the form reviews use. Signed-off-by: Kyle Arrington <kyle@arrington.co>
|
@RyanTheTide, this writes down the convention from your reviews. Is Assisted-by: LLM (Claude:Opus 5.5) |
|
Checked the backport: it matches the mainline commit 1e035297ffda (cherry-pick line and your sign-off added, the 7.3-absent pt_BR/zh_TW hunks dropped), and the head has no On your question: yes, Assisted-by: LLM (Claude:Opus 5.5) |
The rules the previous commit wrote down are kept for every Aurora Silicon repository in aurora-silicon/agent-guidelines, with the pre-PR checklist the reviews apply. Link them instead of keeping a copy that can drift. Signed-off-by: Kyle Arrington <kyle@arrington.co>
|
Thanks. The third commit ( Assisted-by: LLM (Claude:Opus 5.5) |
The tree's process docs still ask for an
Assisted-bytag in the commit, while reviews here ask for the opposite: commits with only the humanSigned-off-by, and the disclosure as the PR body's last line (#2192, #2193, #2195, #2199, #2019, #1876).Mainline already settled this.
coding-assistants.rsthere is the v7.3 copy, unchanged. Since then, Sasha Levin's1e035297ffda("docs: remove Assisted-by references", 2026-10-13, in v7.4-rc1) dropped the tag fromcoding-assistants.rst,submitting-patches.rstand checkpatch, after the 2026 Maintainers Summit. Its reasoning is that the disclosure belongs in the cover letter, not the changelog.Commits
Assisted-bysection aren't in 7.3, so those hunks are dropped. The rest applies cleanly.CONTRIBUTING.md: a short section linking aurora-silicon/agent-guidelines and its pre-PR checklist, where the disclosure form and the commit rules are kept for every repo. (The second commit first copied the rules; the third replaces the copy with the link.)Docs only, apart from the checkpatch hunk, which is mainline's.
perl -c scripts/checkpatch.plpasses. checkpatch on the backport reports only false positives from its own diff (the tag list in checkpatch's own source, read as trailers) and over-75-column lines in the mainline message, kept as merged.Assisted-by: LLM (Claude:Opus 5.5)