Repository navigation
Conversation
The sensor reports on its own at the interval the driver sets at probe, and each report is an AOP mailbox interrupt. Nothing set the interval back to zero: the sensor kept reporting after the driver was unbound, and through suspend-to-idle, where it woke a CPU five times a second. Set the interval to zero on unbind and on system suspend. On resume the CT817 gets the probe's whole sequence (verbosity, batch, raw, then the interval), since it arms only on the zero to non-zero interval transition after its batch and raw properties are written, and they may not survive the sleep. The other parts need only the interval. Signed-off-by: Kyle Arrington <kyle@arrington.co>
|
Looks right to me. The drvdata cast matches what On your firmware-sleep question: Small: if Assisted-by: LLM (Claude:Opus 5.5) |
|
I'm stepping back from this one. The branch stays up and maintainer edits are enabled, so take it, rework it, or close it as you see fit. The code is GPL-2.0 under my Signed-off-by; use it however helps. Assisted-by: LLM (Claude:Opus 5.5) |
The ALS reports on its own at the interval the driver sets at probe (200 ms), and each report is an AOP mailbox interrupt. Nothing set the interval back to zero, so:
This sets the interval to zero on unbind and in
.suspend. In.resumethe CT817 (T8140) gets the probe's whole sequence (verbosity, batch, raw, then the interval), since it arms only on the zero to non-zero transition after its batch and raw properties are written. The other parts need only the interval.Replaces #1876: adds the CT817 replay from the review, on current integration/aurora, without the commit trailer.
Draft, because I can test one machine and this driver serves several. I have only a J813 (VD6286), so the CT817 path has not run. Feedback wanted on:
aop.rsstops the endpoints insuspend_latefor a firmware sleep; this runs before that, in.suspend. I could only test s2idle.Tested on J813 (Mac17,3, 27.0 stub, VD6286) with #1876's head, integration/aurora 5d112b1 merged with #1532. The J813 row on this head is to follow:
Not tested: any other Mac (so not the CT817 replay), a failed write on resume (it warns).
Assisted-by: LLM (Anthropic:Claude Fable 5.2)