Repository navigation
arm64: dts: apple: t6050-j714s: describe the system level cache controller - #2708
DjDeveloperr wants to merge 1 commit into
Conversation
…oller Describe the die-0 memory cache controller on the 14-inch M5 Pro MacBook Pro (J714s) and wire the internal DCP as its boot-DMA supplier and as the boot framebuffer's display. Unlike M5 Max boards (eight enabled AMCCs, 32 planes), the live J714s ADT reports four enabled AMCCs (/arm-io/mcc amcc-enable-mask = 0xf) with four planes each at 0x2220000000, 0x2222000000, 0x2224000000 and 0x2226000000 (stride 0x40000, 16 planes total), matching /chosen/lock-regs/amcc. Each plane's 12 data and tag ways are powered at boot with allocation disabled until apple-mcc enables it. Naming the internal DCP on both apple,boot-dma-devices and the boot framebuffer's display property ensures apple-mcc waits for the DCP to bind (and, with boot-scanout retirement tracking, for a displayed swap to retire the boot framebuffer) before enabling cache allocation. Signed-off-by: Diljit Singh <hey@djdev.me>
|
The latency table makes the case well: SLC allocation on 16 planes takes the 12–24 MiB working sets most of the way to macOS, and the boot line confirms the planes the node describes. One point on where the layout lives. The 4 enabled AMCCs ( Assisted-by: LLM (Claude:Opus 5.5) |
|
Agreed — checking the T6050 IPSW ADTs confirms The block comment above On deep sleep: every T6050 ADT carries Assisted-by: LLM (Google:Gemini 4 Neon) |
|
[Joshua's agent] Verdict at 3481265 #2708 (3481265, J714s MCC node): GREEN once merged after #2518, with one row asked.
|
|
Deep-sleep and
Assisted-by: LLM (Google:Gemini 4 Neon) |
|
Merge-train adversarial review (MERGETRAIN-LINUX2) at 3481265: NO BLOCKERS. Code read only, nothing built here. Before the merge it still needs Dj's verdict at this head; the missing rows are listed below. Full review#2708 arm64: dts: apple: t6050-j714s: describe the system level cache controller @3481265dVERDICT: NO BLOCKERS Blockers: none. The node is inert at this base: drivers/soc/apple/mcc.c:386-390 has no What I checked:
Nits:
Hygiene: one commit, Missing rows:
|
Summary
apple,t6050-mcc,soc@2220000000/memory-controller@2220000000) toarch/arm64/boot/dts/apple/t6050-j714s.dtswithapple,boot-dma-devices = <&dcp>, and adddisplay = <&dcp>to/chosen/framebuffer@0./arm-io/mccamcc-enable-mask = 0xfofamcc-count = 8) with 4 planes each at0x2220000000,0x2222000000,0x2224000000, and0x2226000000(stride0x40000, 16 planes total), matching/chosen/lock-regs/amcc. Pre-kernel Stage 2 reads of all 16 planes confirm+0x82c = 0x1(allocation disabled),+0x2800 = 0x8000000c,+0x2804 = 0x0c000c00(12 data ways and 12 tag ways powered), and+0x2844 = 0x0.integration/auroratoday,apple,t6050-mccis already permitted byDocumentation/devicetree/bindings/soc/apple/apple,t8140-mcc.yamland remains unbound until soc: apple: mcc: let the T6050 system level cache allocate #2518 adds theapple,t6050-mccmatch todrivers/soc/apple/mcc.c. Addingdisplay = <&dcp>onframebuffer@0also prepares J714s for boot-scanout retirement tracking in soc: apple: mcc: wait for display controllers to retire boot scanout #2538 and drm/apple: publish completion of native display takeover #2539.Testing
t6050-j714s.dtbbuilds cleanly with 0 warnings;scripts/checkpatch.plreports 0 errors and 0 warnings.7.3.0-m5-sship7(CONFIG_APPLE_MCC=y,drivers/soc/apple/mcc.cidentical to soc: apple: mcc: let the T6050 system level cache allocate #2518 on 16 planes), comparing the default DTB (c0440c9e) against the same DTB plus this MCC node (with a temporary"apple,t8140-mcc"test fallback sosship7'sapple-mccbinds without rebuilding the kernel; test DTB24cbf3f8517e):apple-mcc 2220000000.memory-controller: system level cache allocation enabled on 16 planes.cpu12) pointer-chase latency (ns/load, 128 B stride) vs macOS 27.0 (26A428, QoS UI) on the same J714s:cpu0) pointer-chase latency (ns/load): 8 MiB44.9 -> 23.6, 12 MiB106.6 -> 46.6, 16 MiB104.2 -> 47.6, 24 MiB110.2 -> 58.8, 32 MiB109.2 -> 75.1.rbw, GB/s): P-core 16–32 MiB94.4–95.8 -> 105.7–107.7(macOS:103.7–106.4); M-core 12–32 MiB88.8–92.9 -> 103.3–113.9.gpubench-vk --test compute.light --depths 1 --runs 3 --run-ms 100(Apple M5 Pro G17S B1):us_per_submitmedian156.99 -> 104.82 µs(-33.2%, 1.50x faster;latency_usmedian148.48 -> 93.60 µs).tailscaled.servicebaseline only on both boots), 0 new kernel error lines (13 pre-existing HID/DCP clock lines vs 17 on baseline), 0 MCC warnings/errors, GPU live before/during/after (vulkaninfo --summary+ compute dispatch), clean reboot and shutdown flush back to default.Assisted-by: LLM (Claude:Opus 5.5, Google:Gemini 4 Neon)