Repository navigation
arm64: dts: apple: t8122-j613-j615: share the CPU thermal zones - #2684
Conversation
Nothing limits the J615's CPU temperature: the CPU thermal zones that keep the fanless J613 safe are in t8122-j613.dts only. The J615 has the same die, the same six CPU die sensors behind smc_hwmon and no fan either; with all eight cores busy its die sensors pass 105 C in 150 s, and a -j8 kernel build holds 110-114.6 C for 22 minutes. Move the zones unchanged into t8122-j613-j615.dtsi, which both boards include. The J613's compiled tree is unchanged (decompiled and sorted, the old and new t8122-j613.dtb are identical); the J615's gains the same thermal-zones node. sustainable-power stays at 6 W. On a J615 with these zones applied as a boot-time overlay, eight busy cores for 170 s peak at 87.7 C with the P cores at 3.1-3.6 GHz, and a 20 minute -j8 kernel build holds 91-92 C with the P cores at 2.9 GHz (peak 97.2 C). Those numbers are Eric Juta's, from linux#2203. Link: #2203 Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
|
Looks good; approve once the J615 row below is posted. The change is a pure move: the HW row: J615, a kernel built from this head with its own t8122-j615.dtb (not the boot loader's lab DTB), default cmdline. Pass if Assisted-by: LLM (Claude:Opus 5.5) |
|
J615 row at 107c2f8: J615 production default, 7.3.0-aurora-fleet79, which carries this head with the DTB built from the tree. Default command line.
|
|
Merge-train adversarial review (MERGETRAIN-LINUX2) at 107c2f8: NO BLOCKERS. Code read only, nothing built here. Before the merge it still needs Dj's verdict at this head; the missing rows are listed below. Full review#2684 arm64: dts: apple: t8122-j613-j615: share the CPU thermal zones @107c2f88VERDICT: NO BLOCKERS What I checked:
Nits:
Merge-order hazard (not a blocker for this PR): #2203 (open, head b2db791) still carries Missing rows:
|
DjDeveloperr
left a comment
There was a problem hiding this comment.
Adversarial review at 107c2f88 against pre-pr-checklist.md (§1–§6): 0 code/policy/attribution/CI blockers, and required §5 evidence is complete on this head.
Verification
- Pure move: Diffing removed lines in
arch/arm64/boot/dts/apple/t8122-j613.dtsagainst added lines inarch/arm64/boot/dts/apple/t8122-j613-j615.dtsiconfirms all sixcpu-*-thermalzones, trips (58 C/95 C/110 C),sustainable-power = <6000>, cooling maps (1024P /3072E capped at state 3), and#include <dt-bindings/thermal/thermal.h>moved unchanged (only the comment block att8122-j613-j615.dtsi:203-208was updated). - Sensor & node safety:
smc_hwmonint8122.dtsi:1134-1176defines the six CPU die sensors (Te05,Te0P,Tp05,Tp0L,Tp0b,Tp0r) first at indices0..5beforehwmon-laptop.dtsiis included (t8122-j613-j615.dtsi:130).t8122-j615.dtsadds nosmc_hwmonchildren and has no conflictingthermal-zonesnode. - §1–§4, §6: Pass — shared
t8122-j613-j615.dtsi(no model gates), default cmdline, DT-carried thermal limits protecting the fanless J615, human-only commit metadata +Signed-off-by:,Link:to #2203 with credit to Eric Juta, PR bodyAssisted-by:, CIdt-checksandhost-testsgreen. - §5 Evidence (complete at
107c2f88): J615 production boot (7.3.0-aurora-fleet79, in-tree DTB, default cmdline) verified all sixcpu-*-thermalzones bound to both clusters, 10-minute 8-CPU soak held P-cores at91-93.7 C(single peak95.49 C, 0 critical trips), SELinux Enforcing, 0 AVC, 0 failed units, 0 new kernel errors; J613 compiled DTB is identical before/after.
Merge-order note (non-blocking)
- Open PR #2203 still carries commit
d30c3bceadding the samethermal-zonesnode/labels tot8122-j615.dts; drop that commit from #2203 before merging it to avoid duplicate-labeldtcfailures.
Assisted-by: LLM (Gemini 4 Neon)
Problem
The CPU thermal zones that keep the fanless M3 Air within limits live only in
t8122-j613.dts. The J615 (15-inch) has the same die, the same six CPU die sensors behindsmc_hwmon, and no fan, but its DTB has no zones. Nothing throttles it: with all eight cores busy, its die sensors pass 105 C in 150 s.Change
Move the J613's
thermal-zonesnode, unchanged, intot8122-j613-j615.dtsi, which both boards include. No values change and no driver changes.Testing
t8122-j613.dtbbefore and after, decompiled and sorted: identical.t8122-j615.dtbgains the samethermal-zonesnode as the J613 (phandles aside).CHECK_DTBS=yis clean for both boards./sys/firmware/fdtthermal-zones node matches the new DTB's: same trips, sustainable power, contributions and cooling maps. A 10-minute all-core soak with those zones held the P-core zones at 86-91 C, with no critical trip. Eric Juta's overlay tests in drm/asahi: m3: T8122 GPU states 6 to 8 under the thermal limit, with the J615 die zone and CPU thermal zones #2203 show the same: 87.7 C peak over 170 s of eight busy cores, and 91-92 C during a 20-minute-j8build.Still to run
Assisted-by: LLM (Claude:Opus 5.5)