Repository navigation
Conversation
|
Looks right. The expected bytes are the kernel's own encoded copy ( Assisted-by: LLM (Claude:Opus 5.5) |
|
Merge-train adversarial review (MERGETRAIN-LINUX2) at 3dcbbdb: NO BLOCKERS. Code read only, nothing built here. Before the merge it still needs Dj's verdict at this head; the missing rows are listed below. Full review#2680 drm/asahi: g18: compare the command read-back instead of hashing it @3dcbbdb1VERDICT: NO BLOCKERS Blockers: none. What I checked:
Nits:
Missing rows:
|
3dcbbdb to
8a44565
Compare
|
@RyanTheTide thanks. The new head is
H1 audit row: I tried it on the M6 with the desktop port of this change, but stage 9 never reaches the audit.
So the H1 audit stays unexercised on hardware, as the PR body says. The stage 10 audit that compares the same cached commands runs on every application job. On the boot after the stage 9 attempt, the desktop came up and 2000 asyncbench frames ran with Assisted-by: LLM (Claude:Opus 5.5) |
|
@RyanTheTide I filed the stage 9 ENODEV as #2768. It looks like the H1 worker loses its devres-managed register mapping when stage 9 returns ENODEV from probe. That started with e06fb54 and is unrelated to this PR. Assisted-by: LLM (Claude:Opus 5.5) |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Reviewed at 8a445653363d. The code change itself has 0 code or CI blockers (host-tests green), but requesting changes for a §4 PR-body attribution blocker before merge.
Blocker
- §4 Attribution (hard rule): The amended live head
8a445653363dwas prepared with LLM assistance (LLM (Claude:Opus 5.5)as noted in the follow-up comment), and the commit metadata itself is clean (human author/committer +Signed-off-by:, no agent trailers in the commit). Please add a plainAssisted-by:line at the end of the PR body (e.g.,Assisted-by: LLM (Claude:Opus 5.5)).
Code & Checklist Summary (§1–§6)
- Code (
graphics_payload.rs,render_assembly.rs,graphics_job.rs,graphics_job_application.rs): Retaining the ~11 KiB encodedcommandsbuffer inEncodedJoband comparing the write-combined graph read-back byte-for-byte inaudit_h1()andApplicationJob::audit()is strictly stronger than comparing the 7 FNV-1a hashes (every hashed register block is a sub-slice ofta/fragment), removes the last caller offnv64_uncached(), and preservesG18_APP_DIGESToutput for frames 1–3.- Non-blocking nit: in
audit_h1()(drivers/gpu/drm/asahi/g18/runtime/graphics_job.rs:251),assembly::digests(ta, fr)hashes the uncached WC slices immediately after provingta == ta_expected && fr == fr_expected; hashing(ta_expected, fr_expected)avoids uncached byte loads while logging identical digests.
- Non-blocking nit: in
- §1–§3, §6: Clean — no model gating, no new module/cmdline parameters, every frame remains audited before kick, naming clean.
Remaining §5 Evidence Notes
- Performance claims require a same-machine A/B with conformance unchanged on the affected GPU generation (only
asyncbenchnumbers are currently recorded). - Please also include regression counts on
8a445653363d(0 SELinux denials, 0 failed units, 0 new kernel errors). - Understood that the H1 fixture audit path (
graphics_job.rs:246-255) cannot currently be exercised on hardware due to pre-existing #2768.
Assisted-by: LLM (Gemini 4 Neon)
8a44565 to
e56519a
Compare
|
@DjDeveloperr thanks.
Assisted-by: LLM (Claude:Opus 5.5) |
|
@DjDeveloperr @RyanTheTide the §5 rows on the J873g. Build.
Regression.
Performance. asyncbench, frames/s, two rounds interleaved:
Conformance. deqp-runner,
Assisted-by: LLM (Claude:Opus 5.5) |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Re-review against pre-pr-checklist.md (§1–§6) at verified live head e56519aa3ad5a1fa44cc8fabade5424ab8ea7c90: LGTM — approving.
Verified Since Prior Review
- §4 Attribution (prior blocker resolved): PR body now includes
Assisted-by:at the end, and commite56519aa3ad5carries human author/committer (Thomas Glanzmann) +Signed-off-by:only, with zero agent trailers. - Code & CI:
audit_h1()now hashes(ta_expected, fr_expected)from the cached copy after proving byte-for-byte equality with the write-combined read-back (graphics_job.rs:246-249), avoiding redundant uncached reads while logging identical digests.host-testsis green and the branch is clean againstintegration/aurora. - §5 Evidence (complete): J873g (G18) rows on
7.3.0-aurora-j873-avd-usb4-perf+(default cmdline,aurora.kowithe56519aabyte compare) confirm:- Regression: 0 failed units, 0 AVC denials, 0 new kernel errors, 0 job failures from this PR's mode.
- Same-machine A/B performance: consistent
asyncbenchspeedup (200 tris1923 -> 2335 fps, 20000 tris772 -> 892 fpslike-for-like; confirmed again on the fresh interleaved boot). - Conformance unchanged:
dEQP-GLES31(compute.*+draw_indirect.*, 416 cases) identical (0 diffs) anddEQP-GLES3(1506 cases) unchanged on the 6 pre-existingtransform_feedbackfails with 0 PR-induced regressions (pre-existingreason=0x3recovery tracked inmesa#617). Pre-existing#2768blocking stage-9 H1 fixture execution is noted and orthogonal.
Assisted-by: LLM (Gemini 4 Neon)
|
Merge-train re-review (MERGETRAIN-LINUX3) at e56519a: NO BLOCKERS. Since our pass at 3dcbbdb there are only three hunks:
Behaviour is otherwise unchanged. The H1 fixture audit is still not exercised on hardware, because #2768 blocks it. |
|
@sithglan the train merged #2652 (your g18 page-walk change), and #2680 at e56519a now conflicts with integration/aurora in |
Between two application jobs the GPU waits about 154 us on the J873g for the next kick. About 100 us of it is spent hashing: the encoder computes FNV-1a digests of both commands and their register blocks (14 KiB, 56 us), and the audit reads both commands back from the write-combined graph and hashes them again (45 us for the hash, 7 us for the read). FNV-1a runs one dependent multiply per byte. Keep the encoder's cached copy of the commands with the encoded job and have the per-frame audit compare the read-back with it byte for byte. That is an exact check where the digests were a hash comparison, and it reads the graph in wide loads. The digests are computed from the cached copy only where they are logged: the first three frames of a client and the H1 audit, which now compares its read-back the same way and still logs the digests of what it read. EncodedJob moves to the kernel side, since the shared assembly code stays free of kernel allocations, and fnv64_uncached() loses its last user. Signed-off-by: Thomas Glanzmann <thomas@glanzmann.de>
e56519a to
1012615
Compare
|
@RyanTheTide rebased onto integration/aurora
Assisted-by: LLM (Claude:Opus 5.5) |
|
Merge-train re-check at 1012615: |
On the J873g (M6 Mac mini), the GPU sits idle for about 154 µs between two application jobs. That is the time from one job's retirement to the next job's kick.
Where the time goes. Per-segment timers in
ApplicationJob::prepare()andaudit_application()(a temporary build, averaged over 8192 frames; the same at 200 and 20000 triangles):FNV-1a does one dependent multiply per byte. About 100 µs of the gap is hashing.
Change.
G18_APP_DIGEST, unchanged values) and for the H1 audit. The H1 audit compares its read-back the same way and still logs the digests of what it read.EncodedJobmoves tographics_job.rs, sincerender_assembly.rsis shared with the host dry-run and stays free of kernel allocations.fnv64_uncached()loses its last user and is removed.J873g rows (asyncbench, headless, async submission from #2679 with its Mesa side). The old hashing and the compare were interleaved on one boot through a temporary switch that is not part of this PR; four rounds each, frames/s mean and range:
G18_APP_DIGEST/G18_APP_AUDITlines are as before.Checks.
cc @DjDeveloperr @RyanTheTide @Acelogic @LiamRay10
Assisted-by: LLM (Claude:Opus 5.5)