Repository navigation
arm64: dts: apple: t8122-j613-j615: describe the Touch ID data-ready line - #2678
RyanTheTide wants to merge 1 commit into
Conversation
…line The J613/J615 Mesa sensor raises its data-ready line on AP GPIO 199. The ADT's /arm-io/spi2/mesa node gives it as interrupts = <199 3> on gpio0, the same encoding as J713 (199) and J616c (116), whose device trees describe it as IRQ_TYPE_EDGE_RISING and capture on the interrupt. Without the line the driver polls the SPI status every 2 ms while a capture is armed. On a J615 waiting for a finger that is about 1450 spi2 interrupts a second; with the line described it is 16 a second, the 250 ms status backstop. Describe the line so the J613/J615 capture is interrupt driven like the other Mesa sensors, and update the T8122 SEP device tree test. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
|
Looks good; approve once the fingered J615 row is in. Checked: HW row: J615, fleet77 + this DTB, default command line: one fingered enrolment and one match (fprintd-verify) with the data-ready IRQ count rising per touch and no fallback-to-polling line, then the same after one s2idle round; 0 AVC, 0 failed units, 0 new kernel errors. Assisted-by: LLM (Claude:Opus 5.5) |
|
Merge-train adversarial review (MERGETRAIN-LINUX2) at 67b0890: NO BLOCKERS. Code read only, nothing built here. Before the merge it still needs Dj's verdict at this head; the missing rows are listed below. Full review#2678 arm64: dts: apple: t8122-j613-j615: describe the Touch ID data-ready line @67b0890bVERDICT: NO BLOCKERS What I checked:
Nits:
Missing rows:
|
DjDeveloperr
left a comment
There was a problem hiding this comment.
Adversarial review at 67b0890b against pre-pr-checklist.md (§1–§6): 0 code/policy/attribution blockers (and all 8 CI checks are green); holding only for the remaining §5 hardware rows below.
Verification
arch/arm64/boot/dts/apple/t8122-j613-j615.dtsi:126-127wires&mesadata-ready topinctrl_appin199,IRQ_TYPE_EDGE_RISING.pinctrl_ap(t8122.dtsi:910-922) hasapple,npins = <224>,interrupt-controller,#interrupt-cells = <2>, and pin 199 has no conflicts acrosst8122*.dts*.- Matches
Documentation/devicetree/bindings/input/apple,mesa-fingerprint.yaml:32-34,125-126anddrivers/soc/apple/sensor_shim.c:712-716,756-758(IRQF_ONESHOT | IRQF_TRIGGER_RISING, no trigger mismatch). tools/aurora-sep/tests/test_t8122_sep.py:88-91checks both thepinctrl_apphandle and<199 1>cells across all four Air DTBs (j613,j615,j613-25g83,j615-25g83).- §1–§4, §6: Pass (shared dtsi, default cmdline, ADT-derived GPIO, human-only commit metadata +
Signed-off-by:, PR bodyAssisted-by:, clean naming). - Non-blocking nit:
tools/aurora-sep/tests/test_t8122_sep.py:88says "as on J713 and J616s" while the commit message says "J713 (199) and J616c (116)" (both J616s and J616c use116 IRQ_TYPE_EDGE_RISING).
Remaining §5 HW rows before approval
- J615 fingered Touch ID enrolment + verification (
fprintd-enroll+fprintd-verify) on currentintegration/aurora+ this PR (which now includes #1598 /3f09f2d2switchingspi2fromclk_200mtoclkref~8 MHz since the earlierfleet77no-finger measurement), default command line: confirm thepinctrl_appin 199 data-ready IRQ count increments per touch in/proc/interruptswithout falling back to polling, and repeat a match after ans2idleround. - Regression counts on that run: 0 AVC denials, 0 failed units, 0 new kernel errors.
(J613 is not in the lab and shares the node/ADT value; -25g83 variants inherit the shared dtsi.)
Assisted-by: LLM (Gemini 4 Neon)
Problem. The J613/J615 (M3 MacBook Air) Touch ID sensor has a data-ready line, but the device tree leaves it out, so the SEP driver polls the sensor's SPI status every 2 ms whenever a capture is armed (enrolment, a login or unlock prompt waiting for a finger). On a J615 that is about 1450 spi2 interrupts a second for as long as the prompt is up.
Change. Describe the line on the shared J613/J615
&mesanode: AP GPIO 199, rising edge. The value comes from the J615 ADT (/arm-io/spi2/mesa,interrupts = <199 3>ongpio0). J713 (199) and J616c (116) carry the same encoding in their ADTs and are described asIRQ_TYPE_EDGE_RISINGin our trees, where capture already runs on the interrupt. The T8122 SEP device tree test now checks the line instead of its absence. DT only, no driver change.Testing. J615, default kernel 7.3.0-aurora-fleet77, the production Stage 2 with only this DTB change, default command line:
data-ready IRQ ... configured for interrupt capture,sensor: interrupt-driven capture; an enrolment opens and waits for a finger, and cancels cleanly.genpd_prepare -11, comes from the s2idle and shows on earlier fleet77 s2idle boots too).tools/aurora-sep/tests/test_t8122_sep.py: 4/4. dtc warnings unchanged on j613, j615, j613-25g83 and j615-25g83 (13 each).Still to run. A fingered enrolment and match on the J615 (needs a person at the machine). No J613 in the lab; it shares this node and ADT value.
Related: #1596 (draft) adds the same J613 line from the J613 ADT, together with a driver change that drops polling. This PR is the DT half on its own, for J613 and J615 both.
Measurements and kit
Per-second spi2 (
2a1108000.spi) interrupt deltas from/proc/interrupts, enrolment held 30 s withfprintd-enroll, nobody touching the sensor, same script on both boots:The t=1 s burst is the sensor re-registration that opens every enrolment. A 40 s no-finger enrolment on a J713 (data-ready line already described) for comparison: data-ready interrupt 12 times, spi interrupts +2.0k in total.
Test boot: one aura-try one-shot of the J615 production Stage 2 with its embedded DTB swapped for one carrying only the two
&mesaproperties (interrupt-parent,interrupts); aura and U-Boot bytes identical (cmp). Kernel unchanged (fleet77).Assisted-by: LLM (Claude:Opus 5.5)