Skip to content

drm/asahi: g16: admit the 25G83 GFX image as loaded on the J715 - #2667

Closed
kazuhidet wants to merge 1 commit into
aurora-silicon:integration/aurorafrom
kazuhidet:j715/g16-j715-25g83
Closed

kazuhidet wants to merge 1 commit into
aurora-silicon:integration/aurorafrom
kazuhidet:j715/g16-j715-25g83

Conversation

@kazuhidet

Copy link
Copy Markdown

The J715 (15-inch M4 Air, Mac16,13) loads the same 25G83 GFX image as the J713 (same
TEXT/DATA sizes and entropy records 0x5c8df/0x5c9c2); only the block iBoot fills after the
entropy records differs, as with the 10-core J713 entry. Without this entry the probe stops
with "unsupported GPU firmware build ... sha256 cceb3f98...".

Tested on J715 (10 cores, OS firmware 26.6.2): firmware identity accepted, READY, Mesa
(aurora-wip) GL 4.6 / GLES 3.2, Hyprland session.

Built and tested on integration/aurora 0abc2f3; the change applies unchanged to the current tip. J715 report: #2663.

The J715 (15-inch M4 Air, Mac16,13) loads the same 25G83 GFX image as the J713 (same
TEXT/DATA sizes and entropy records 0x5c8df/0x5c9c2); only the block iBoot fills after the
entropy records differs, as with the 10-core J713 entry. Without this entry the probe stops
with "unsupported GPU firmware build ... sha256 cceb3f98...".

Tested on J715 (10 cores, OS firmware 26.6.2): firmware identity accepted, READY, Mesa
(aurora-wip) GL 4.6 / GLES 3.2, Hyprland session.

Signed-off-by: Kazuhide Takahashi <kazuhide.t@linux-powered.com>
@RyanTheTide

Copy link
Copy Markdown
Contributor

The entry is correct as a firmware identity: same 25G83 sizes and entropy records, admitted by the normalized TEXT digest. The table now holds the same image three times (J713, the 10-core J713, J715), differing only in the block iBoot fills after the entropy records. Rather than one digest per board, it would scale better to describe that block in boot_filled (its offset and size, which you've found), so that one normalized entry admits every T8132 Air and the next board needs no new entry. If its contents depend on the core count, that is what boot_filled is for. If that is a bigger change than this PR wants, this entry is fine as it is, and the follow-up can fold the three.

Assisted-by: LLM (Claude:Opus 5.5)

@kazuhidet

Copy link
Copy Markdown
Author

Superseded by #2672, which follows the review here: the block iBoot fills is described in boot_filled, so one normalized 25G83 entry admits the J715 (tested there) and the J713 entries stay until a J713 run. Closing this per-board entry.

@kazuhidet kazuhidet closed this Nov 21, 2026
kazuhidet added a commit to kazuhidet/linux that referenced this pull request Nov 22, 2026
The T8132 table pins the same 25G83 image (build 2 of armfw_g16g.im4p) three
times, one TEXT digest per J713 variant, and aurora-silicon#2667 would add a fourth for the
J715. The images differ only in what iBoot writes into TEXT at load time.

Comparing the TEXT of the 26.6.2 firmware file with the TEXT loaded on a J715
shows that iBoot writes three ranges besides the two entropy records. The
image describes each of them itself:

  - 0x23c, 8 bytes: a header field.
  - 0x5c8df, 0x231 bytes: the record block (GKTS ... ECAP ...). The header
    states this offset and length at 0x22c/0x230.
  - 0x5cb10, 0x6a0 bytes: the tunables block. The block's TUNS record points
    at it, and its TUNZ record gives the size.

With these ranges in boot_filled, the file's TEXT and the J715's loaded TEXT
hash to the same digest. Every byte that differs between the two lies inside
the ranges. Add that single entry ahead of the per-board ones, as the G17
tables already do, and name it so the identity line says which entry admitted
the image.

Keep the J713 8-core and 10-core entries after it for now. Only a J715 has
booted with just the normalized entry; if a J713's iBoot writes anywhere
outside the three ranges, removing its entries would stop its GPU at
"unsupported GPU firmware build". They can go once both J713 variants have
booted on 26.6.2 with only the normalized entry.

j713_accepts_all_loaded_images() now expects the J713 digests at builds[1..=3],
and checks that the normalized entry at builds[0] is found by its own digest
and that its boot_filled ranges lie inside TEXT.

Tested on J715 (Mac16,13, 10 cores, OS firmware 26.6.2) with only the
normalized entry in the table: "firmware identity accepted", READY, Hyprland
session. Not tested on J713.

Signed-off-by: Kazuhide Takahashi <kazuhide.t@linux-powered.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants