Repository navigation
soc: apple: pmp: confirm a T8132 27.2 ioreg update with the entry's length, as macOS does - #2653
Open
DjDeveloperr wants to merge 1 commit into
Open
DjDeveloperr wants to merge 1 commit into
DjDeveloperr wants to merge 1 commit into
Conversation
Contributor
|
Reviewed the last commit (e544c86). Answering with the named entry's registered length is a small, contained change, and the J773g's four ioregs still confirm 8. Some points:
The M4 Air (J713) boots the same T8132 27.2 PMP image, so a J713 boot with this would show whether its updates name the same four entries. Assisted-by: LLM (Claude:Opus 5.5) |
…ength The T8132 27.2 PMP firmware sends UPDATE_IOREG for a registry entry it names by its own index, and waits for the confirmation. The index is word 0x48 of the entry's REGISTER_IOREG buffer, and the confirmation carries the length of that entry: 8 for the four entries the firmware updates on the Mac mini (J773g), which is what hypervisor traces of macOS 27.2 show and what this driver sends for every update. Keep the firmware's index of each registered entry and answer with that entry's registered length. An index that names no registered entry keeps the value 8, with a warning. Signed-off-by: Diljit Singh <hey@djdev.me>
DjDeveloperr
force-pushed
the
djdev/t8132-pmp-272-confirm-len
branch
from
November 21, 2026 07:22
e544c86 to
f5d413f
Compare
Contributor
|
Blockers: 3.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the T8132 27.2 PMP firmware the driver answers every UPDATE_IOREG with CONFIRM_IOREG 8, a constant. The confirmation is meant to carry the length of the entry the firmware names. This change sends that length.
Evidence
0x0037000000000008, CONFIRM_IOREG with value 8.dev_info) matched each of those four indices to a registered entry through word 0x48 of its REGISTER_IOREG buffer, and found length 8 every time (UPDATE_IOREG 0x17c: confirming its 8 bytes, likewise for 0x17f, 0x182 and 0x18a, 12 times each in the GPU lane's runs). Its confirmations equal the traced macOS values.Base
The base is the HV lane's 27.2 PMP kit branch,
hvtrace/m4drv8p-mods-pmp272-confirm(head 19bf8a8). It is the source of theapple_pmp27.2 module the mini runs. Because this PR is stacked on that feature branch, the repository's CI does not run on it.The same change was built as an external module for the mini's running kernel (010c3eb) in a kit for the GPU lane. That kit build has an extra
dev_infoon every UPDATE_IOREG, for its tests.Before this can merge: the base selects the 27.2 behaviour with a T8132 27.2-image check (
apple_pmp_t8132_self_starts()), and this change inherits it. A firmware-version gate doesn't meet the agent guidelines for merged code. The merge candidate should select by what the firmware does: confirm with the registered length whenever the firmware sends UPDATE_IOREG for a registered entry. That is a change to the base, for its owner.Assisted-by: LLM (Claude:Opus 5.5)