Repository navigation
arm64: dts: apple: t8140-j700: Show the software camera indicator (slot 1) - #2651
Conversation
The MacBook Neo's camera has no indicator light. Point the ISP at the DCP so the kernel shows its best-effort software camera indicator while the camera streams, and give the indicator swap slot 1. Slot 1 sits directly above the surface DRM uses (iomfb-surfaces <0>). Slot 2 was tried first: the DCP blends it only where the primary is transparent, so under an opaque primary such as GNOME's AR30 desktop the indicator never reached the panel. With slot 1 it shows over an opaque primary and is cleared when the stream stops. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
|
No blockers. DT only, on the J700 board file. Assisted-by: LLM (Claude:Opus 5.5) |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Pre-PR checklist review (§1–§6) at 6f729e6caf89: APPROVE (0 blockers).
- Code & DT checks (
arch/arm64/boot/dts/apple/t8140-j700.dts:629,703):apple,camera-indicator-surface = <1>on&dcpsatisfiesdcp_indicator_probe()(drivers/gpu/drm/apple/dcp-indicator.c:55-68): J700 usesapple,iomfb-surfaces = <0>(t8140.dtsi:1704, mapped to bit 0 indcp.c:7369-7374), so slot 1 is free above surface 0 and< SWAP_SURFACES, andapple_dcp_hw_t8140(dcp.c:9727-9737) uses H17P (not H17G), so theswap_donehook is present.apple,camera-indicator = <&dcp>on&ispmatchesapple_isp_indicator_node()(drivers/media/platform/apple/isp/isp-drv.c:833-838) and both DT bindings (apple,dcp.yaml:195,apple,t8140-isp.yaml:93).
- §1–§3 / §6: Board-DT-only opt-in on
t8140-j700.dts(the only T8140 board in tree), default kernel command line, no hacks or naming issues. - §4 Attribution: Commit
6f729e6caf89carries human author/committer and humanSigned-off-by: Ryan Murray <ryan@aurorasilicon.org>only, with zero AI trailers in the commit. - §5 Evidence & CI:
dt-checksandhost-testsare green on6f729e6caf89. Hardware rows on J700 (#2561 comments 7052690642 and 7055375971) exercise these exact two DT properties: modetest opaque AR30 blend CRC 3/3, GNOME AR30 2/2, DPMS off/on during stream 3/3, camera stop/start while dark 8/8 each, 150-frame stream rc=0, 0 AVC denials, 0 failed units, 0 oops/WARN, and 0 swap failed / present dropped. (The DPMS retained-layer plane-state note belongs to #2561's driver code, not this DT opt-in.)
Assisted-by: LLM (Gemini 4 Neon)
Problem. The MacBook Neo's camera has no indicator light. #2561 added a best-effort software indicator, which the DCP draws in a reserved swap slot, but J700 doesn't opt in yet. The earlier opt-in (#1758) used slot 2. The DCP blends slot 2 only where the primary is transparent, so under GNOME's opaque AR30 desktop the indicator never reached the panel.
Change. DT only, J700 only.
apple,camera-indicator-surface = <1>on the DCP, andapple,camera-indicator = <&dcp>on the ISP. Slot 1 sits directly above the surface DRM uses (apple,iomfb-surfaces = <0>), so it isn't one userspace could use.Testing. On a J700, using fleet76 plus the #2561 commits, with exactly these two properties in the DTB (one-shot trial boots):
Still to run.
Notes for review
Assisted-by: LLM (Claude:Opus 5.5)