Repository navigation
Conversation
…m sleep
On firmware 27.2 the G14 GPU firmware keeps running through
suspend-to-idle. Without apple,sleep-retained, genpd gates the GFX
domain under it in the noirq phase. At the wake the domain does not
power on ("PS gfx: Failed to reach power state 0xf"), and the next GPU
access hangs a CPU. This is the J713 case that
apple,sleep-retained was added for, and the same property T8132 and
T6050 carry.
Only the firmware-27 J413 tree needs it, since only that tree runs the
GPU on 27.2. With the GPU disabled the domain is already off at
runtime, and the property changes nothing.
Signed-off-by: Satya Benson <satya@benson.earth>
|
Looks good. One small point: what needs this is the 27.2 GPU firmware, not the J413 board. Today only J413 has a -fw27 DTB, so nothing else is affected, but saying in the comment that any T8112 board file for 27.x firmware needs the same property would help whoever adds the next one. The untested items you list (several cycles in one boot, a long sleep, sleep power with GFX held on) are the ones I would still like to see once the suspend commit in #2544 settles. Assisted-by: LLM (Claude:Opus 5.5) |
8203f55 to
017a1ab
Compare
DjDeveloperr
left a comment
There was a problem hiding this comment.
Pre-PR checklist review at 017a1abaf2ba9027cc52d0dbf4ede072c18a9a8b (§1–§6): 0 code/policy/CI blockers — COMMENT (holding for §5 HW regression row).
Code & Source Verification
arch/arm64/boot/dts/apple/t8112-j413-fw27.dtsaddsapple,sleep-retained;to&ps_gfx, matchingt8132-gpu.dtsi:96andt6050-k114c-gpu.dtsi:111.- Verified
arch/arm64/boot/dts/apple/t8112-pmgr.dtsi:810-816:ps_gfxhas no parentpower-domainsand no conflicting policy properties. - Verified
drivers/pmdomain/apple/pmgr-pwrstate.c:443,547-569,951-967:apple,sleep-retainedonly returns-EBUSYfromapple_pmgr_ps_power_off()whileps->system_sleepis true (suspend_late..resume_early). Runtime PM is unchanged, and ifps_gfxis already off (GPU disabled/unbound) it stays off. - Verified
t8112-j413-fw27.dtsis currently the only-fw27board DTS in the tree andDocumentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml:138permits the property.
Checklist Summary
- §1 No model gating: Pass — hardware/firmware behavior expressed in DT (
t8112-j413-fw27.dts), no driver-side board/chip gating. - §2 Production-ready: Pass — default command line, no hacks.
- §3 Safety: Pass — prevents GFX power-domain wedge and post-resume CPU hang.
- §4 Clean-room & attribution: Pass — commit
017a1abacarries human author/committer andSigned-off-by: Satya Benson <satya@benson.earth>with no AI trailers;Assisted-by:is in the PR body. - §6 Naming: Pass.
- CI:
dt-checksSUCCESS andhost-testsSUCCESS on live head017a1aba.
Missing §5 Evidence (Hold)
- Regression gate counts missing: none of the reported phellos runs record
0 SELinux denials (AVC),0 failed units, and0 new kernel errors. - Compiled PR DTB / default-boot s2idle coverage: runs used
fdtputon a lab kernel carrying#2544+aura#402with GPU enabled; a plain default-config boot on J413 using the compiledt8112-j413-fw27.dtbfrom017a1aba(including an s2idle cycle with GPU disabled, the current default, and the 0/0/0 regression gate) is needed to complete §5.
Non-blocking nit: echoing the earlier comment, noting in the DTS comment that any future T8112 -fw27 board file needs the same &ps_gfx property would be helpful.
Assisted-by: LLM (Gemini 4 Neon)
Claude Opus 5.5 on @satchlj's behalf.
Adds
apple,sleep-retainedto&ps_gfxint8112-j413-fw27.dts, the J413 tree for macOS 27 system firmware. It is the GPU-side half of the suspend handling in #2544.Why. On firmware 27.2 the G14 GPU firmware keeps running through suspend-to-idle. Without the property, genpd gates the GFX domain under it in the noirq phase. At the wake the domain does not come back: pmgr logs
PS gfx: Failed to reach power state 0xf (requested 0xf00200f, now: 0xf002b0f), which means target active, actual power-gated, BUSY. The next GPU access then hangs a CPU: on phellos on 2026-11-20, an RCU stall with a CPU unresponsive to NMI after a post-resume compute dispatch, and earlier a hang on unbind. This is the J713 failure thatapple,sleep-retained(8fd377b) addresses, and T8132 and T6050 carry the property for the same reason.Tested on phellos (J413, 27.2 stub), one-shot boots of the up4 default kernel (integration/aurora df62a8c + our PRs) with the GPU published by aura#402 and #2544's suspend commit (0aac788) as the module. The property was added to the Stage 2's
t8112-j413-fw27.dtbwithfdtput; the DTB is otherwise the tip's (d73ea1e0…).Untested: idle power during the sleep (the GFX domain now stays on while the GPU is bound); a long sleep or many cycles in one boot; lid-close sleep. With the GPU disabled (the phellos default), the domain is already off at runtime and the property has no effect, but no s2idle was run on such a boot with this tree.
Assisted-by: LLM (Anthropic:Claude Opus 5.5)