Repository navigation
Conversation
6da1c0e to
4820c62
Compare
06d9663 to
8d801c2
Compare
|
Fine as a draft behind switches that default to off. Some small things to fix before it leaves draft:
Assisted-by: LLM (Claude:Opus 5.5) |
|
dcp_platform_suspend() only performs the RTKit idle and the 26.6 pre-sleep calls when the v26_sleep_rtkit_idle / v26_sleep_calls module parameters are set; both default off, and the block logs its state with dev_warn on every suspend. As written this is a trial harness, not a sleep path: the DCP shutdown has to work with no parameters. Once it is known which of the idle and call groups the firmware requires, make that the fixed sequence for dcp_j613_sleep_owned() devices, drop both parameters and lower the logging to dev_dbg. Until then this should stay a draft. |
|
Claude Opus 5.5 on @satchlj's behalf. Pushed 878dfdb (comments only, signed off):
On the switches: agreed, they shouldn't merge. What we know so far, all on J613:
Once a J613 sleep wakes, I'll make the minimal sequence fixed for |
Before the cold stop for a system sleep (switches, off by default), send the 26.6 firmware the calls macOS sends it before a sleep, observed on its mailbox and RPC memory (Aura capture run 68), then ask RTKit for AP and IOP idle on the 26.6 session's RTKit: - appledrm.v26_sleep_calls=1: the sleep-entry group, A478, A476(1), A473 (16 bytes), A115, A500 (0, 1); =2: the panel-off group first, A414, A478 x2, A476, A478, A412, A473 zeroed, A500 (0, 0). Every reply is compared with macOS's; a mismatch is -EPROTO. - appledrm.v26_sleep_rtkit_idle: the RTKit idle before the cold stop, on dcp->v26's RTKit where the 26.6 path keeps it. Without the calls the idle is never acknowledged (-62); with either group it is (status 0x30002e). Needs the power-down callbacks (#2558). Signed-off-by: Satya Benson <satya@benson.earth>
The trial parameters' comment and definitions now sit above the comment that describes dcp_j613_sleep_owned(), which again directly precedes it. The call groups are named panel-off and sleep-entry in both the function comment and the parameter description. Signed-off-by: Satya Benson <satya@benson.earth>
4820c62 to
7f160c1
Compare
878dfdb to
0a87098
Compare
…idle by default The sleep shutdown's panel-off and sleep-entry calls and the RTKit AP and IOP idle before the cold stop were behind two module parameters. Run them on every such sleep instead, in the firmware's own order, and report only a failed idle. Signed-off-by: Satya Benson <satya@benson.earth>
Conflict in dcp_platform_suspend(): keep this branch's sleep calls and RTKit idle, with the base's rename of the cold-stop flag. Signed-off-by: Satya Benson <satya@benson.earth>
|
Claude Opus 5.5 on @satchlj's behalf. J613 row (on #2572 and the current tip, trial-only conditions as on #2572): the DCP sleep shutdown fails before the commit.
|
J613's DCP calls D209 (no input, a u64 out) during the sleep shutdown. Left unhandled it fails with -EOPNOTSUPP, and the panel-off and sleep calls behind it return -95. The M4 and H17P ABIs already answer it as get_calendar_time_ms; answer it the same way here. Signed-off-by: Satya Benson <satya@benson.earth>
J613's DCP sends D002 (no input, no output) during the sleep shutdown. Unhandled, it fails with -EOPNOTSUPP and the panel-off and sleep calls behind it return -95. The other ABIs take it as a notification. Signed-off-by: Satya Benson <satya@benson.earth>
…, D594) After D002, J613's DCP sends D592 (20 bytes in, no reply) during the sleep shutdown, and unhandled it fails the panel-off and sleep calls with -95. The M4 ABI groups D002, D008, D592 and D594 as notifications (set_power_trace_enable, swap_complete_intent, enable_backlight_message_ap_gated); take the remaining three the same way when no reply is asked for. Signed-off-by: Satya Benson <satya@benson.earth>
|
Claude Opus 5.5 on @satchlj's behalf. With f540e0b the J613 DCP sleep shutdown now completes: The SoC still doesn't power down after the commit (WD1 resets it about 60 s later), so the DCP isn't what holds it up. |
…, D572) The previous change took D008, D592 and D594 at any input size, but only D592 (20 bytes in, no reply) has been seen from J613's DCP. Narrow it to that shape, and leave D008 and D594 unhandled until they are observed. After D592 the DCP's sleep shutdown sends D572 (4 in, 4 out). The M4 and H17P ABIs answer it, powerUpDART, with success; do the same. Signed-off-by: Satya Benson <satya@benson.earth>
f540e0b to
f386099
Compare
|
Claude Opus 5.5 on @satchlj's behalf. Correction to my last note: J613's own callback table isn't known, so D572's name is uncertain. H17P's table calls it powerUpDART, and M4's comment is ambiguous. Both answer it with success, which is what this does; the commit message's name is a best guess. |
|
Re-checked at f386099. The diff from f540e0b is one comment line, so the 09:59 J613 row is effectively at this head.
Assisted-by: LLM (Claude:Opus 5.5) |
Claude Opus 5.5 on @satchlj's behalf. Draft, stacked on #2572 (the J613 sleep port), and needs #2558 (the 26.6 power-down callbacks). The deep sleep it serves has not woken yet.
What it does
Before the DCP's cold stop for a system sleep, behind trial switches that are off by default:
appledrm.v26_sleep_calls=1: the calls the 26.6 firmware receives from macOS at its sleep entry: A478, A476(1), A473 (16 bytes), A115, A500 (0, 1).appledrm.v26_sleep_calls=2: the panel-off group macOS sends 6.9 s earlier comes first: A414, A478 ×2, A476, A478, A412, A473 zeroed, A500 (0, 0).appledrm.v26_sleep_rtkit_idle: then RTKit AP and IOP idle, on the 26.6 session's RTKit (dcp->v26->rtk).The calls and their inputs are observed traffic on the DCP's mailbox and RPC memory (Aura capture run 68, with aurora-silicon/aura#390). Each call's meaning is not known beyond what the traffic shows.
Results
J613 trial kernel n33 (
f44bf7af+ 39), the same Image and DTB for every run, n=1 each:v26_sleep_calls(trial namej613_sleep_calls)0x30002e)0x30002e)0x3000ac)The calls are what make the DCP's RTKit idle succeed. They do not, alone, let the SoC power down.
Untested:
acfcd08b(clean, compile only); the results above are from the trial kernel, where the switches were namedj613_.Not yet shown on hardware: with
f687047athe sleep calls and the RTKit idle run by default, with no module parameters. This form has not been booted or put through a sleep.Assisted-by: LLM (Anthropic:Claude Opus 5.5)