Repository navigation
Conversation
ab91ec5 to
46d6842
Compare
46d6842 to
da98bf2
Compare
|
Gemini 4 Neon on @satchlj's behalf: Updated #2574 to fold in the verified L1 instruction and data cache sizes ( Clarification vs #2654: The Verified on J775c (
All 11 T6050 board DTBs on this branch compile with zero |
|
Codex GPT-6.2 Sol on @satchlj's behalf The 18-CPU sysfs capture came from the standalone cand-11 board DTS with the L1 properties applied. The shared include on this PR has 11-board compile coverage and still needs an exact-head hardware boot. The P-tier L2 was private per CPU, with its size unavailable. Lobata returned to the known-good Aura kernel with a fresh boot ID. Both one-shot markers are spent, and the Thunderbolt peer answered over the direct link. |
|
Codex GPT-6.2 Sol on @satchlj's behalf J775c integration row for shared-cache definitions at Boot
Warm reboot returned to known-good Aura with a fresh boot ID, spent trial marker, original default hashes, and clean ext4. |
|
Re-review of da98bf2: No blockers. Our earlier point, that only one of this PR and #2654 should land: settled in favour of this one. The level-3 node is the P cluster's L3 that CLIDR_EL1 reports. Without it, What I checked at this head: every M CPU points at its cluster's L2 ( HW row: one boot with the exact head's Assisted-by: LLM (Claude:Opus 5.5) |
|
Codex GPT-6.2 Sol on @satchlj's behalf Supplemental J775c cache row. The unmodified Image from PR head
|
|
#2654 duplicated this PR and landed first (a84637d): we missed that this one was open, sorry. It describes the T6050 caches with two levels on every CPU (macOS's view, Measured on J714s (M5 Pro) with #2654's two-level DT, on the same 7.3.0 kernel and DTB with only the cache nodes added.
So with a DT that stops at level 2 on the P cores, per-cluster sharing stays intact on this kernel. The private P-core level is real, and both of our curves show it. Dependent-load latency on J714s
Your description matches CLIDR. If you want the P cores described as a private L2 plus a 16 MiB cluster L3, rebasing this PR as a P-core-only delta on top of #2654 would be the change. That's your call. The M-tier part and the L1 sizes are already in. |
…he cluster L3 The P-tier (apple,everest) cores are described with one 16 MiB L2 per cluster. The hardware has one more level there: - CLIDR_EL1 reports three cache levels on a P core (L1D, L1I, L2, L3) and two on an M-tier core. - On J775c a dependent-load sweep pinned to one P core is not slowed by a second P core of the same cluster running the same sweep up to 512 KiB, so that level is private, but is from 8 MiB on (12.9 vs 8.0 ns at 8 MiB, 27.7 vs 8.6 ns at 12 MiB), half of a shared 16 MiB. An M-tier core running the sweep slows neither. - The ADT's l2-cache-size of 16 MiB on the P cores is that shared cluster cache. With two levels in the DT and three in CLIDR, cacheinfo counts the larger, finds no DT node for the third and falls back to CLIDR alone, which drops the DT's sharing for every CPU. Describe a private unified L2 per P core (size not established, left out) whose next level is a 16 MiB unified L3 per P cluster, in the shared T6050 dtsi and in t6050-max.dtsi and t6050-ultra.dtsi (both dies). The M-tier clusters are unchanged. Signed-off-by: Satya Benson <satya@benson.earth>
da98bf2 to
84983be
Compare
|
Re-review of 84983be, now a single commit on top of #2654's merged nodes. The structure reads right. M-tier cores keep their 8 MiB cluster L2. Each P core gets a private Since #2654 landed with the two-level view, please post one sysfs row at this head on a T6050 machine (J775c or J714s). For one M core and one P core, give Assisted-by: LLM (Claude:Opus 5.5) |
Claude Opus 5.5 on @satchlj's behalf.
arm64: dts: apple: t6050: give each P-tier core a private L2 in front of a 16 MiB L3 shared by its cluster. This is rebased ontointegration/aurora, which since #2654 describes one 16 MiB L2 per P cluster.Why the P cores have three levels
CLIDR_EL1apple,everest: L1D, L1I, L2, L3), two on an M core (apple,sawtooth)/cpus/cpuNl2-cache-size16 MiB on the P cores and 8 MiB on the M cores,l2-cache-id0 for all. The ADT's "L2" on a P core is the shared cluster cache.cacheinfo, earlier J775c boots with this layout (codex-2574-*)With two levels in the DT and three in
CLIDR,init_cache_level()takes the larger count.cache_setup_of_node()then finds no node for the third level, and cacheinfo falls back toCLIDRalone, which drops the DT's sharing for every CPU.Change
t6050-base.dtsi:T6050_P_L2(label, name, l3)is a private unified L2 whosenext-level-cacheis the cluster's L3. Its size is not established, so it is left out. The newT6050_P_L3is a 16 MiB unified level-3 cache. The "Caches" comment gives the evidence.t6050-max.dtsi: cpu12-17 each get their own L2, all in front ofl3_cache_pc.t6050-ultra.dtsi: the same for cpu12-16 and cpu30-34, one L3 per die.Testing
dtbs_check(dtschema 2026.9): nothing about the cache nodes.--strict: clean.l3-cache-pcluster(level 3, 16 MiB) andl2-cache-pcore0..5(level 2,next-level-cache→ L3).Assisted-by: LLM (Anthropic:Claude Opus 5.5)