Skip to content

media: apple: isp: take the preview setup on T8122 ISP firmware 27.2 - #2570

Closed
RyanTheTide wants to merge 1 commit into
integration/aurorafrom
isp/t8122-272-preview
Closed

RyanTheTide wants to merge 1 commit into
integration/aurorafrom
isp/t8122-272-preview

Conversation

@RyanTheTide

Copy link
Copy Markdown
Contributor

Problem

On the 15-inch MacBook Air M3 (J615, T8122) running the macOS 27.2 firmware, the FaceTime camera probes (sensor 0x558, setfile isp_1921_01XX) and accepts a stream, but delivers no frames: 0 frames in 19 minutes, after which the stop command (opcode 0x0101) times out. The stream setup has one firmware-specific branch, the 26.6.2 preview path (MBNR and the temporal filter off). The J613 takes it on 26.6.2; 27.2 skips it.

Change

Firmware-compat 27.2 on the T8122 ISP now takes the same preview setup. It is chosen by the IP compatible and the compatibility version, with no board check. The J613 26.6.2 admission is unchanged, and preview_26=0 still turns both off.

Testing

  • J615, kernel 7.3.0-aurora-j615d1 (lab K4 tree + DCP 27.2), Stage 2 with aura#227's ISP handoff: with this change, 1920x1080 NV12 at 30.0 fps (90/90 frames in 3.00 s) and mean luma rising 15.9 -> 21.7 as auto exposure settles (dark lab). Without it: 0 frames.
  • Builds without warnings; checkpatch clean.

Still to run

  • A J613 row on 27.2 (same SoC; expected identical).
  • The 27.2 firmware still does not return the stop magic ("never received magic number"). The driver stops the coprocessor itself, so capture is unaffected. That is a separate follow-up.
Evidence and details
  • Trace: traces/camera/20261121-j615-isp272 (lab store), not tainted: our kernel logs and ffmpeg statistics only, no image kept.
  • The tested lab module (same effect, folded into isp_preview26_admitted) and this PR form are in the lab kit kits/test/20261120-j615-av/isp-272.

Assisted-by: LLM (Claude:Opus 5.5)

On the MacBook Air J615 (T8122) with the 27.2 firmware the camera probes
and accepts a stream, but delivers no frames, and its stop command then
times out. The only firmware-specific part of the stream setup is the
26.6.2 preview path (MBNR and the temporal filter off), which 27.2 skips.

Take that setup for firmware-compat 27.2 on the T8122 ISP, chosen by the
IP compatible and the compatibility version, without a board check. The
J613 26.6.2 admission is unchanged; preview_26=0 still turns both off.

With it the J615 streams 1920x1080 at 30.0 fps (90 frames in 3.00 s),
with auto exposure converging.

Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
@RyanTheTide

Copy link
Copy Markdown
Contributor Author

Desktop-path row (J615, macOS 27.2 firmware, lab kernel 7.3 with this patch as a module): PipeWire lists the FaceTime HD Camera as the default video source; GStreamer pipewiresrc as the GNOME user gets 30 of 30 1920x1080 frames in 2.97 s including start-up, and v4l2src 30 frames as well. Three sessions in a row restart fine. Each stop still logs 'never received magic number from firmware' (the firmware doesn't acknowledge the power-down on 27.2); the driver then stops the coprocessor itself, and the next start works.

@RyanTheTide

Copy link
Copy Markdown
Contributor Author

This does not build: isp_t8122_preview_on_272() in drivers/media/platform/apple/isp/isp-drv.c compares against ISP_FIRMWARE_V_27_2, which is not declared on this branch's base or on integration/aurora b4cd7b3:

drivers/media/platform/apple/isp/isp-drv.c:809:33: error: use of undeclared identifier 'ISP_FIRMWARE_V_27_2'

(arm64, LLVM=1, clang 22.1.6, Fedora asahi base config + asahi.config.) The host-tests check passes because it never compiles the driver. The 27.2 entry needs to be added to the ISP firmware version enum (and to the compat table that sets it) in this PR, or the PR needs to be stacked on the one that adds it. Until then this should stay a draft.

@RyanTheTide
RyanTheTide marked this pull request as draft November 21, 2026 00:57
@RyanTheTide

Copy link
Copy Markdown
Contributor Author

Superseded by #2670. On the J615 (27.2) the stall comes from starting the temporal filter with the 1921_01 set file, not from the firmware version: #2670 turns the filter off through the sensor table, reads 27.2 with the 26.6.2 layout, fixes the T8122 PMU base and drops the J613 board/version profile. No firmware-version or board check is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant