Repository navigation
arm64: dts: apple: t6050-k114c: enable the Neural Engine - #2564
joshuaswarren wants to merge 2 commits into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a414f4841e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #include "t6050-peripherals.dtsi" | ||
|
|
||
| /* The Neural Engine, started only after the boot loader's preload hand-off */ | ||
| #include "t6050-j714s-ane.dtsi" |
There was a problem hiding this comment.
Enable the ANE's fabric power-domain suppliers
In the preprocessed K114c tree, this include enables ps_ane_sys but leaves its suppliers ps_fab8_soc and ps_fab9_soc, and their parent ps_fab0_piogw, disabled. Those dependencies are declared in t6050-peripherals.dtsi; J714s and J716c enable them through other board-specific declarations that K114c does not include. Disabled suppliers never register their providers, so the PMGR driver's parent-domain lookup returns -EPROBE_DEFER, preventing ANE_SYS registration and leaving the ANE and all three DARTs unable to probe even after a valid firmware handoff. Enable the complete supplier chain alongside this include.
Useful? React with 👍 / 👎.
|
Thanks for the signed replacement. Two things are missing before this can go in:
Please also close #1607 once this replaces it. |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Thanks. a414f48 carries #1607's include unchanged, and the reg-names hunk is already on the base as acb6bae, so as a replacement the diff is right and the commit is signed off.
Codex's finding on this head is real, though, and it holds the merge. The include enables ps_ane_sys, whose parents are ps_fab8_soc and ps_fab9_soc, both under ps_fab0_piogw (t6050-peripherals.dtsi:787, :609, :764). All three stay disabled on the K114c:
- the J714s enables fab8 and fab0 in its dts (
t6050-j714s.dts:535-543) and fab9 throught6050-j716c-isp.dtsi:130; - the J716c gets them from its SEP and ISP includes;
- the K114c includes none of these.
A disabled parent never registers a genpd provider, so of_genpd_add_subdomain() in pmgr-pwrstate.c returns -EPROBE_DEFER, ANE_SYS never registers, and ane0 and its three DARTs stay deferred even after a good loader hand-off.
Please enable that chain for the K114c the way the J714s does: fab0 and fab8 with apple,firmware-owned, plus fab9. Putting them in t6050-j714s-ane.dtsi, so every board that includes it gets its parents, works too. With CI green it merges. The K114c boot row (both reservations filled, ane0 probes, firmware starts) comes after, with a revert ready.
|
J775c (lobata) row request — ANE enablement (sheet row U10) Posted by Joshua's lane (wB4) from the 2026-11-20 K114c row set. We supply no image for this; it needs a tree with the J775c DTB (off-host build of the exact head plus the J775c board DTB). ANE is T6050 silicon and J775c carries it. Head: exact Commands: boot the exact head one-shot; save Pass: Context note: on the PR itself, Ryan's two merge asks (enable the |
|
A note on the J775c row request: it won't exercise this PR. a414f48 changes only What this PR still needs is unchanged:
If you want ANE on the J775c as well, that needs its own board change (the include plus the same chain), with a J775c row on that change. |
|
Claude Opus 5.5 on @satchlj's behalf. J775c (lobata) row for sheet row U10: pass, with a J775c DT change rather than this PR's diff. This PR adds
Row (b), boot
The J775c DT change (to go on #2102, not here):
Ryan's K114c asks on this PR are unaffected. |
Enable ane@508000000, its three DARTs and ps_ane_sys, as t6050-j714s-ane.dtsi does for the boards that use the shared ane0 description (#2564 for K114c). This file has its own ANE nodes, so: - the three ANE DARTs get power-domains = <&ps_ane_sys>, as in the shared ane0_dart description. Enabling them without it hung J775c before userspace (a DART probed with its domain off, by hypothesis); - the ANE node keeps the engine, pmgr and pwgate windows only, as the shared ane0 node and the T6050 platform data (three windows) expect. With the extra "xl" window the driver refused the node (-EINVAL). Booted on lobata (J775c), cand-11 kernel, DTB-only trials one change at a time: the ANE probes, the loader hand-off is verified, /dev/accel0 appears, and three ANE programs (add64, add128, relu) run 100 times each, bit-exact, with no new error-level kernel lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Satya Benson <satya@benson.earth>
|
What changed: Build and check: The K114c hardware row (both reservations filled, |
|
Thanks, c5cf29f closes the supplier finding: fab0/fab8 enabled as on the J714s and fab9 in the J716c form, and the K114c DTB checks clean apart from the existing |
|
Cross-model agent review of c5cf29f (independent of the authoring model), against integration/aurora:
|
J714s already includes t6050-j714s-ane.dtsi: the two firmware reservations the boot loader fills, the three ANE DARTs and ps_ane_sys. K114c, the same T6050 ANE, enables none of it, so ane0 stays disabled. Include the same file after t6050-peripherals.dtsi. The ANE driver leaves the engine off until the loader has filled the reservations. Compiled the K114c dtb with and without the change: ane0 goes from disabled to okay with memory-region <&ane_fw_text &ane_fw_data>. Not booted with the ANE started. Signed-off-by: Joshua Warren <816217+joshuaswarren@users.noreply.github.com>
The t6050-j714s-ane.dtsi include sets ps_ane_sys okay, but ANE_SYS's suppliers stayed disabled on the K114c: ps_fab8_soc and ps_fab9_soc (parents of ANE_SYS in t6050-peripherals.dtsi) and their shared parent ps_fab0_piogw. A disabled power-controller registers no provider, so the pmgr driver's parent lookup defers and ANE_SYS never registers, leaving ane0 and its three DARTs deferred too. Enable the chain the way the J714s does: ps_fab0_piogw and ps_fab8_soc firmware-owned and okay as in t6050-j714s.dts, and ps_fab9_soc in the t6050-j716c-isp.dtsi form (parent edge dropped, no-auto-pm, firmware-owned, okay), since the fabric domains are powered by the boot firmware rather than by Linux. Compiled the K114c dtb and ran the schema check: only the pre-existing apple,t6050-pciec port0 finding, identical without the change. Signed-off-by: Joshua Warren <816217+joshuaswarren@users.noreply.github.com>
c5cf29f to
be91b86
Compare
|
Rebased onto integration/aurora at a84637d and both commits now carry Signed-off-by (Joshua Warren 816217+joshuaswarren@users.noreply.github.com), answering the review block. dt-checks and host-tests are running on be91b86; the K114c boot row (both loader reservations filled, |
|
Status at be91b86 (current head): the CHANGES finding is addressed — |
|
Re-checked at be91b86: both patches are the ones reviewed at c5cf29f (range-diff equal, only parentage and the sign-offs changed), and dt-checks and host-tests pass on this head. Nothing more from us on the code. The K114c boot row (both reservations filled, Assisted-by: LLM (Claude:Opus 5.5) |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Pre-PR checklist review at be91b867b18c (CI: dt-checks and host-tests passing).
DT & code (§1–§3, §6): Clean.
The earlier a414f484 supplier finding is fully resolved at be91b867b18c. Verified the full transitive dependency chain across t6050-peripherals.dtsi, t6050-j714s-ane.dtsi, t6050-j714s.dts, t6050-j716c-isp.dtsi, and t6050-k114c.dts:
ane0->ane0_dart,ane0_dart1,ane0_dart2+ps_ane_sys(all enabled byt6050-j714s-ane.dtsi) +peripheral_clocks(enabled int6050-peripherals.dtsi).ps_ane_sys->ps_fab8_soc+ps_fab9_soc->ps_fab0_piogw(root domain, no parentpower-domains), enabled withapple,firmware-owned(and/delete-property/ power-domains+apple,no-auto-pmonps_fab9_soc), matchingt6050-j714s.dts:535-543andt6050-j716c-isp.dtsi:130-135.- Both commits (
32e89725ccc9,be91b867b18c) carry human author/committer andSigned-off-by:only, with zero AI trailers.
Blocker (§4 Attribution):
- The PR body opens with
[Joshua's agent](indicating agent assistance) but omits the required end-of-bodyAssisted-by:line naming the model or tool (§4 hard rule). Please add a plainAssisted-by:line at the end of the PR body naming the model/tool, and update the stale PR description (it still says the branch carries one commit and does not mention the fabric power-domain enable commit).
Still needed (§5 Evidence):
- Once the §4 PR-body disclosure is added, the only remaining item is the K114c hardware boot row on
be91b867b18c(boot loader fills both firmware reservations,ane0probes, firmware starts, plus regression line: 0 SELinux denials, 0 failed units, 0 new kernel errors).
Assisted-by: LLM (Gemini 4 Neon)
|
Thanks both. Agreed that the K114c boot row is the remaining step. It runs in tonight's M5 test window on this exact head ( Assisted-by: LLM (Anthropic:Claude Opus 5.5) |
[Joshua's agent]
Enable the Neural Engine on K114c with the firmware reservations and DARTs already used on other T6050 boards. The driver still waits for the boot loader to fill the two firmware reservations.
Replaces #1607. The branch carries one signed commit on
integration/aurora. The second patch from #1607 is already present on the base asacb6bae371, so this branch does not repeat it. Naming the register windows alone does not make the DART program the DAPF; this node has noapple,dapf-rangesproperty.Validated on, and reach
Validated on: K114c DTB build and property checks. The ANE node changes from
disabledtookay, has both firmware reservation references, and its DART hasreg-names = "dart", "dapf".Applies beyond the M4: K114c only. No hardware run on this head. The boot check must show the loader filling both reservations, the driver probing, and firmware starting.
m tester run (omarchy-m-testing.org): Neural engine. No tester run for this head.