Repository navigation
Conversation
On T6050 G17C (M5 Max), both render and compute queues configure hardware soft-fault zeroing (`m5::queue::ConfigProfile::soft_fault_enabled` and `QueueConfig::UNK_66`), so unmapped GPU reads return zero and unmapped writes are discarded without raising a GPU fault. Advertise `DRM_ASAHI_FEATURE_SOFT_FAULTS` on T6050 `GpuVariant::C` (`0x6050`, M5 Max) unless overridden via `aurora.fault_control`, and document that on G17 `aurora.fault_control` overrides only the UAPI advertisement without changing queue configuration. Other T6050 variants remain excluded until independently verified. Verified on J716c (T6050 G17C) across 20,246 Vulkan robustness and sparse buffer CTS tests (`vertex_attribute_fetch`, `storage_buffer`, `uniform_buffer`, `vertex_access`, `buffer_access`, `null_descriptor`, `sparse_resources.buffer`) with 20,246/20,246 passing and zero GPU faults or recoveries. Built cleanly with both CONFIG_KUNIT=y and CONFIG_KUNIT=n. Developed with Claude Code. Signed-off-by: Erik Bourget <erik@ebourget.net>
|
Thanks for the J716c robustness and sparse runs, 20,246 clean cases is a strong result. This overlaps with linux#2081, which turns ( Could you run your CTS set on #2081's head on the J716c and post it there? If it passes, this PR can close. If G17C needs something #2081 doesn't do, a note on what differs would help. We can add rows on our M1 Pro, M2, M4 Pro and A18 Pro. |
|
Note 🤖 Claude Opus 5.5 responding on behalf of erikwb @RyanTheTide, the row you asked for: #2081's head (50c9683) on the J716c (M5 Max, G17C, 27.2 firmware), in a kernel built from the J716c's current base, with current aurora-wip Mesa.
#2081 covers G17C, so I'll close this PR. |
Advertise
DRM_ASAHI_FEATURE_SOFT_FAULTSon T6050GpuVariant::C(0x6050, M5 Max) unless overridden viaaurora.fault_control.Summary
m5::queue::ConfigProfile::soft_fault_enabledandQueueConfig::UNK_66), so unmapped GPU reads return zero and unmapped writes are discarded without raising a GPU fault.supports_soft_faults()strictly onself.cfg.chip_id == 0x6050 && self.cfg.identity.gpu_variant == crate::hw::GpuVariant::C && fault_control == 0xb, leaving G17S, G17D, and other variants excluded until independently verified.asahi_core.rsandg17/mod.rsthat on G17aurora.fault_controloverrides only the UAPI advertisement without altering queue configuration.Verification
CONFIG_KUNIT=yandCONFIG_KUNIT=n.vertex_attribute_fetch,storage_buffer,uniform_buffer,vertex_access,buffer_access,null_descriptor,sparse_resources.buffer): 20,246/20,246 PASS, zero GPU faults or recoveries.Created with Antigravity (reviewed with
gpt-6.2-sol).