Repository navigation
drm/asahi: g17: keep the commit-stop raise to the T8142 - #2521
Merged
Merged
Conversation
#2469 kept the GPU domain raise at the sleep commit's stop on the T8142 and on every apple,agx-g17s part. The G17S M5 boards (J714s, J716c) never run it: they stop the GPU through their own M5 commit stop, which this doesn't touch. On them the flag only made asahi_g17_commit_finish() print "GPU domain at the commit stop: 0x0, raise to full 0" from fields the M5 stop never fills, which reads as a raise that didn't happen. The other G17S boards (K114c, K116s) take the generic stop, where the raise was never measured; their sleep was tested before it came in. Keep the raise to the T8142, the SoC it was made for (the J815's GPU gates itself between frames and its registers may not answer below full power): the other G17S boards go back to the stop they were tested with, and the M5 boards stop printing the empty line. Signed-off-by: Diljit Singh <hey@djdev.me>
DjDeveloperr
force-pushed
the
djdev/g17s-no-commit-raise
branch
from
November 20, 2026 05:23
3decff5 to
10db28c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps the G17 commit-stop domain raise (f5b8062, narrowed by #2469) to the T8142. One line in
asahi_g17_commit_raises()plus its comment.What it changes:
asahi_g17_m5_commit_stop, picked byasahi_g17_m5_provider()). That stop never ran the raise and is byte-identical to the M5 default kernel's.apple,agx-g17sentry,asahi_g17_commit_finish()printedGPU domain at the commit stop: 0x0, raise to full 0there, from fields the M5 stop never fills. That line read as a raise that never happened. It goes away.Correction to the first version of this PR: it blamed an M5 hang after a deep sleep (the ship gate's intg28, 2026-11-19 23:49) on the raise. An independent review showed the raise never ran on the J714s, so this PR does not address that hang; it is still open and being bisected in the ship lane.
It is in the M5 ship candidate (
7.3.0-m5-intg28c) because it is harmless there.🤖 Generated with Claude Code