Repository navigation
Conversation
|
Blockers: 2.
HW row: J775c on this branch (with #2302) on the default command line. Assisted-by: LLM (Claude:Opus 5.5) |
Set clock-latency-ns on the M- and P-cluster OPPs so cpufreq reads the latency from the shared OPP tables. The nominal 100 us value sets schedutil's default rate limit to 150 us on T6050. Userspace-governor timing on J775c covered both M policies and the P policy. For transitions between the lowest or second-lowest OPP and the highest OPP, the maximum per policy was 60.0 us (policy0), 102.5 us (policy5), and 79.7 us (policy10). The timing is end to end through sysfs. Repeat it with this change and check the rate limit and workload response on the revised kernel. Signed-off-by: Satya Benson <satya@benson.earth>
450bfa5 to
5c4ee27
Compare
|
Codex GPT-6.2 Sol on @satchlj's behalf Moved the latency to Removed the co-author trailer from the DT commit and updated the PR footer. The current #2302 base ( The ARM64 J775c DTB and cpufreq object built with |
|
Codex GPT-6.2 Sol on @satchlj's behalf J775c one-shot on exact All three policies came up with
All p50s were under 100 µs. Two of policy6's directional maxima exceeded 100 µs (103.3 and 115.5 µs). Same-boot 0 AVC denials, 1 failed unit ( Timing and scope follow-up: 2,400 sysfs calls across three policies, two OPP pairs per policy, 200 calls per direction per pair. The largest observed end-to-end call was 115.5 µs (115,500 ns). A literal 100,000 ns bound does not cover these measurements. 120,000 ns would cover the captured sample only. These timings include sysfs overhead and do not establish a hardware-only bound or validate that rounded value under other loads. The exact stack was integration ancestor |
|
Re-review of 5c4ee27: Blockers: 1. Points from the last review:
New point:
The same-boot HW row: J775c, this branch (with #2302) on the current Assisted-by: LLM (Claude:Opus 5.5) |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Adversarial pre-PR checklist review (§1–§6) on 5c4ee27a9439054b812ac938f02b6b82f01181dc.
Blockers:
- §2 / DT binding violation —
clock-latency-ns = <100000>under-reports your own measured maximum (arch/arm64/boot/dts/apple/t6050-base.dtsi:114-300):- Per
Documentation/devicetree/bindings/opp/opp-v2-base.yaml:143-146,clock-latency-nsspecifies "the maximum possible transition latency (in nanoseconds) for switching to this OPP from any other OPP", whichdrivers/cpufreq/apple-soc-cpufreq.c:1531-1539reads viadev_pm_opp_get_max_transition_latency()forpolicy->cpuinfo.transition_latency. - Your own run on live head
5c4ee27a9439measuredpolicy6(M cluster) directional maxima of 103.3 µs and 115.5 µs (and the earlier run hit 102.5 µs onpolicy5), both exceeding100000ns. Calling 100 µs "nominal" does not satisfy the binding. Either measure the in-kernel transition latency directly without sysfs overhead (e.g., fromcpu_frequency/ driver request to observed P-state completion, per cluster so M and P can carry distinct bounds if they differ), or setclock-latency-nsto a documented bound that covers the observed worst case.
- Per
- Stale commit message (
5c4ee27a9439): Still cites the olderpolicy0(60.0 µs) /policy5(102.5 µs) /policy10(79.7 µs) numbers and ends with an open TODO ("Repeat it with this change and check the rate limit and workload response on the revised kernel"). Update it to match the final value, derivation, and live-head measurements.
Additional §2 / §5 / CI items to clear before approval:
- §2 Default command line & current base: The J775c trial used a carrier DTB with PCI SDHCI disabled, non-default kernel parameters (
arm64.nomte,console=tty0,console=ttyDC0), and an ancestor ~398+ commits behindintegration/aurora(wheret6050-base.dtsihas since changed), with 1 failed unit (ac-power-mode.service) and 3 boot error lines. Re-verify on currentintegration/aurora(with #2302) on the default command line with 0 AVC denials, 0 failed units, and 0 new kernel errors. - §5 Same-boot A/B:
pp pipeshowed no improvement (15.770 µsat6000 µsvs15.820 µsat150 µs) because that load holds one clock; include a same-boot A/B on a ramp-sensitive/bursty load (e.g.,schbenchp99 wakeup latency or a bursty fixed-work test) comparing6000 µsagainst the newrate_limit_us. - CI: No CI checks have run yet (stacked on
sweep/cpufreq-lazy); ensuredt-checkspasses once rebased/retargeted.
Checks passing:
- §1 No model gating: Moving latency into the shared
t6050-base.dtsiOPP tables with zero driver changes is the right approach. - §3 Safety: Thermal management properties are untouched.
- §4 Clean-room & attribution: Commit
5c4ee27a9439carries human author/committer and humanSigned-off-byonly (0 AI trailers); PR body includesAssisted-by:. - §6 Naming: Clean.
Assisted-by: LLM (Gemini 4 Neon)
Stacked on #2302 for lazy cpufreq transition verification.
Set
clock-latency-ns = <100000>on the T6050 M- and P-cluster CPU OPPs. The existing cpufreq OPP lookup reports 100,000 ns and sets schedutil's defaultrate_limit_usto 150 µs, down from the 6 ms derived from the timeout fallback.Evidence
Earlier J775c userspace-governor tests timed transitions between the lowest or second-lowest OPP and the highest OPP on both M policies and the P policy. The largest end-to-end sysfs times were 60.0 µs for policy0, 102.5 µs for policy5, and 79.7 µs for policy10. The 100 µs value is nominal. The effect of this value on a workload still needs an isolated measurement.
Testing
W=1builds passed forapple/t6050-j775c.dtbanddrivers/cpufreq/apple-soc-cpufreq.o. The compiled DTB contains 100,000 ns on all 37 CPU OPPs.Assisted-by: LLM (OpenAI:GPT-6.2 Sol)