Repository navigation
Conversation
Generation 4 controllers (T8142, T6050) were refused an interrupt at
probe ("Generation 4 interrupt layout is not supported"), so their PMU's
peripheral interrupts, such as the RTC alarm, could not reach Linux.
Their interrupt banks are 32-bit words: mask words from 0x400 and
acknowledge words from 0x600 (the same base the fault-interrupt
acknowledge already uses), with 256 peripheral interrupts, the reply
notification at 256 and the fault interrupt at 263. Give each generation
its own mask and acknowledge bases, read generation-4 status words 32 bits
at a time, and stop refusing the interrupt.
Nothing changes for a generation-4 controller whose device tree names no
interrupt, which is every one in the tree today.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Satya Benson <satya@benson.earth>
|
Thanks for porting this and for the J775c alarm-wake evidence. This is the same mechanism as #1743: per-generation mask/ack bases at 0x400/0x600,
Could you close this one and post the J775c |
|
Claude Opus 5.5 on @satchlj's behalf: thanks, agreed. Closing this one in favour of #1743. It is the same mechanism, and #1743 also handles fault source 263 and writes the eight gen-4 words rather than nine. I posted the J775c row on #1743, marked as coming from this PR's implementation, not #1743's head. lobata's next candidate carries #1743 instead of this PR, and #2495 now states #1743 as its gen-4 dependency. 🤖 Generated with Claude Code |
Claude Opus 5.5 on @satchlj's behalf.
spmi-apple-controllerrefuses an interrupt on generation-4 controllers (T8142, T6050) with "Generation 4 interrupt layout is not supported". So a PMU peripheral interrupt, such as the RTC alarm, cannot reach Linux on those SoCs. On the Mac Studio (J775c, T6050) that leaves suspend-to-idle with no RTC wake source. The PMU's alarm is its peripheral interrupt 2 on/arm-io/nub-spmi0.Change (driver only)
0x400and acknowledges from0x600(the base the fault-interrupt acknowledge already uses), with 256 peripheral interrupts, the reply notification at 256 and the fault interrupt at 263.The existing fault draining, recovery and suspend/resume masking are unchanged and now use the per-generation bases.
No behaviour change on its own: no generation-4 controller in the tree names an interrupt today. The J775c device-tree side (
nub-spmi0as an interrupt controller on AIC 726, and the SMC RTC's alarm interrupt withwakeup-source) follows as a separate PR on top of #2102.Testing
drivers/spmi/spmi-apple-controller.obuilds without warnings onintegration/aurora26294e82(gcc 16.1.1, arm64).apple_spmiinterrupt 2 since 2026-11-08, and 3/3 s2idle cycles woke from the RTC alarm on 2026-11-19.🤖 Generated with Claude Code