Repository navigation
drm/apple, soc: apple: remove the T6030 manual external-display path (-1781) - #2432
RyanTheTide wants to merge 1 commit into
Conversation
The T6030 display gate has two modes. The default, native, runs the external display coprocessor through the 14.7 IOMFB service in the main DRM device. The "manual" mode, which display-gate.c calls "the earlier diagnostic path", only runs with apple_t6030_display.dcpext_manual=1: the gate then marks the scanout node apple,t6030-scanout-verified and dcpext_scanout/dcpext_drm present a test pattern and register a separate DRM device. Native mode replaced it, and nothing we ship sets the parameter (kernel configs, distro and platform packages, aura, lab kits). Remove the early_param and the manual branch of the gate, the dcpext_scanout and dcpext_drm files (the dcpext_pageflip parameter and the dcpext_pattern, dcpext_desktop, dcpext_status and dcpext_present sysfs files), their hooks in dcp.c, dcp-fabric.c, iomfb_v14_7.c and ibootep.c, the ibootep pattern helpers only they used, and two host test stubs for the removed functions. Every removed hook keyed on dcp->dcpext_scanout, which only the manual mode could set, so the native path is unchanged. The manual path was written by Chris Kearney (98d767e, 718c6a3, e6c1062 and later). Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
|
No blockers. I checked that the default path does not change. Two small leftovers worth folding in:
HW row: J514s or J516s (T6030) on this head with an external display on built-in HDMI and on USB-C. Pass if the gate logs "enabled dcpext%u ... started by the display driver on first use", the mode and picture match the pre-change kernel, 3 hotplug cycles and one s2idle cycle each work, with 0 AVC, 0 failed units and no new dcp/dcpext kernel errors. The code is safe to leave draft without this row, but the row should be posted before merge if a T6030 owner can run it. Assisted-by: LLM (Claude:Opus 5.5) |
|
Re-check at 9f5ce93 against current integration/aurora and the open PRs. The default native path is still unchanged, and nothing in the tree, the distro repos or the boot loader sets
Assisted-by: LLM (Claude:Opus 5.5) |
Problem
The T6030 (M3 Pro/Max) display gate still carries its old "manual" external-display path next to the native one that replaced it. With
apple_t6030_display.dcpext_manual=1the gate marks the scanout node verified, and dcpext_scanout/dcpext_drm present a test pattern and register a separate DRM device.display-gate.citself calls this "the earlier diagnostic path". Nothing we ship sets the parameter, so about 1,800 lines only run on a command line nobody uses.Change
dcpext_manualearly_param and the manual branch. The comment block now describes the remaining outcomes, native or refused.dcpext_pageflipparameter and thedcpext_pattern,dcpext_desktop,dcpext_statusanddcpext_presentsysfs files.Net -1,781 lines. Every removed hook keyed on
dcp->dcpext_scanout, which only the manual mode could set, so the default native path does not change. The manual path was Chris Kearney's bring-up work (98d767e, 718c6a3, e6c1062).Kept on purpose: the explicit-start path for a dcpext that isn't native-shaped (
iomfb_v14_7_external_start, sysfsdcpext_start). A real boot can still reach it if the native check fails, so it isn't provably dead.Testing
make Image modules dtbsRC=0, 5,909 modules, modpost reports no undefined symbols, and the only warnings are ones the baseline already had in untouched files.make W=1 drivers/gpu/drm/apple/ drivers/soc/apple/with the fleet config, before and after: RC=0, same warning set..modinfoof appledrm.o: onlydcpext_pageflip(parm and parmtype) disappears.dcpext_manual,dcpext_pageflipand the sysfs names: nothing in the kernel tree, fedora/alarm/nixos/aurora-platform, aura or the lab kits.Still to run
Assisted-by: LLM (Claude:Opus 5.5)