Repository navigation
Conversation
T6000 and T8112 run the 6070.11.1 Start and Process commands that were qualified on hardware byte for byte. Nothing tests that those bytes stay the same when the shared 6070 writer changes for another chip. Add a KUnit case that builds Start and the first two Process commands for H.264 and HEVC, at 1280x720 30/1 and 1920x1080 30000/1001, with default session parameters, and compares their CRC32 with the values the builder produces at this commit. Assisted-by: Grok 4.7 Assisted-by: Claude Opus 5.5 Signed-off-by: Lucas Goossen <lucas.goossen@hey.com>
Every instance creates the debugfs directory apple-ave. On a machine with two encoders the second one fails to create it and has no lifecycle_test, inject_wedge or last-command files. Name the directory apple-ave-<device name>, for example apple-ave-40d100000.video-codec, and update the two documents that give the old path. The path changes on every chip. Assisted-by: Grok 4.7 Assisted-by: Claude Opus 5.5 Signed-off-by: Lucas Goossen <lucas.goossen@hey.com>
|
Thanks for this. The rate-control and VUI work is careful, and the CBR/VBR results table states its limits plainly. One convention point. We select behaviour by a hardware or firmware property, not by the list of machines it was run on. The four new behaviours are enabled only on T6021:
T6000, T8112 and T6021 run the same 6070.11.1 firmware. The missing VUI timing and the firmware's RC mode numbering look like properties of that firmware, not of the M2 Max. Could these be keyed on the 6070 layout (or on a firmware-build property, if a build really differs), with a comment where a difference is known? We can run the rows on our M1 Pro (T6000) and M2 (T8112): H.264/HEVC CQ, CBR and VBR, B-frames on and off, and an ffprobe timing check. If any one of them misbehaves there, that result is the hardware reason to keep it per variant. |
|
Thanks for the plain results table, including the CBR undershoot. Three requests:
As on #2374, please describe the T6021 offsets and values in the PR text and |
A boot loader that hands over two encoders cannot name both DATA images with the one /chosen aurora,ave-data-crc32 property, and the encoders share one TEXT reservation, so its iommu-addresses property carries one tuple per encoder. Read aurora,crc32 from each memory-region reservation and fall back to the /chosen property when it is absent. Accept several iommu-addresses tuples and use the one whose phandle is this device; a reservation with none, or with two for this device, is refused as before. Describe the reservation property in the admin guide, next to the /chosen ones. Every chip goes through this code. With today's boot loader (no aurora,crc32, one tuple per reservation) it does what it did before; only T6021 was run. Assisted-by: Grok 4.7 Assisted-by: Claude Opus 5.5 Signed-off-by: Lucas Goossen <lucas.goossen@hey.com>
The driver requires the extra0 register window to start on a 16 KiB boundary. On T6021 neither encoder's window does: ave0's is 0x7c44 bytes at 0x2902803e0, ave1's 0x3dfc bytes at 0x28e680228. dma_map_resource() maps the pages that contain an unaligned range and returns the IOVA of its first byte, which is the address Config takes. Drop the alignment check, and map the larger of the resource size and the variant size, so that the whole window is covered: with the variant size alone, the last 0x24 bytes of ave0's window would be unmapped. T6000's window is 0x24 bytes at a 16 KiB aligned address and T8112's is page aligned and exactly its variant size, so both map 0x4000 bytes as before. The alignment check goes for every chip: an unaligned window is now mapped, not refused. The only such window outside T6021 is on the second M1 Max encoder, which the device trees leave disabled. Assisted-by: Grok 4.7 Assisted-by: Claude Opus 5.5 Signed-off-by: Lucas Goossen <lucas.goossen@hey.com>
The M2 Max runs a larger build of the 6070.11.1 firmware the T6000 and T8112 support uses, AppleAVE2FW_H14C: TEXT 0xf0000 and DATA 0x134000, with the link cell at TEXT 0x423c. Its two encoders share TEXT and each has its own DATA. The coprocessor registers, boot argument and timebase are T8112's. With boot device ID 20 and device type 17 both encoders of a J475c boot, answer the handshake and encode. The identity CRC, TEXT with the link cell cleared, is 0x0d56db87; select the 6070.11.1 layout for it. Config on T6021 needs a shared area. With the pointer and size at +0x60 and +0x68 left zero, as on T8112, the firmware never answers Config. With a 64 KiB, 16 KiB-aligned area both encoders answer Config, Open and Start. Allocate it at the first boot, keep it until the device is removed, and pass it for a variant with config_shared. That is a property of the H14C build rather than of 6070.11.1: the T8112 build answers Config with both words zero. The 6070 sessions on T6021 run the T6000/T8112 commands unchanged in this commit: one constant-quality session per encoder. abi.rst said 6070 streams H.264 without B pictures; the 6070 path already offers HEVC Main and B pictures, so describe that, and say what T6021 adds and what each value was checked against. The Kconfig help now says what each chip offers. Assisted-by: Grok 4.7 Assisted-by: Claude Opus 5.5 Signed-off-by: Lucas Goossen <lucas.goossen@hey.com>
A session the firmware saw keeps its buffers until the coprocessor is proved to have lost power, and that happens only after the last session closes. With two sessions per boot, one long-lived stream and a second that is opened and closed again and again keep every closed session's buffers, a full set per session, with no bound. Count the sessions waiting for the reap. Once four wait, refuse a new session that would join the running firmware with EBUSY and a rate-limited warning. The refused session was never handed to the firmware, so it is freed at once. When the last stream closes, the power cycle frees all of them and resets the count. This holds for every layout; 9003 already ran two sessions per boot. Assisted-by: Claude Opus 5.5 Signed-off-by: Lucas Goossen <lucas.goossen@hey.com>
The 6070.11.1 layout allows one session per firmware boot, while the driver already keeps the process buffers per session. Allow two, on every SoC that runs this firmware. On a J475c, four H.264 sessions, two on each encoder, ran in real time for five minutes at their target rates, and a fifth STREAMON got EBUSY. T6000 and T8112 were not run with two sessions. When the first of two sessions closes, its buffers stay quarantined until the last session closes and the encoder is power cycled, as on 9003. Assisted-by: Claude Opus 5.5 Signed-off-by: Lucas Goossen <lucas.goossen@hey.com>
Two Start and Process words make 6070.11.1 H.264 P pictures much larger than they need to be. Both were checked on a J475c (T6021): - With the Process timescale word nonzero, every P slice had nal_ref_idc 0, so no P picture was a reference. With it zero, P slices have nal_ref_idc 1 and frame_num counts up. Submit 0 there for H.264; the PTS still counts in the same timescale. - With the motion lambdas at Start 0xff98, 0xffa4 and 0xffa8 zero, about 94% of P macroblocks were 8x8 partitions, and constant quality 0 on a 720p lecture clip came out at 8.4 Mbit/s. With 64 (full-pel search), 256 (inter mode decision) and 64 (intra mode decision), 8x8 became rare, the clip came out at 0.30 Mbit/s, and quality 50 took 1.8 times the bits of libx264 at the same PSNR. Name the lambda offsets in the 6070 layout, and key both on a new layout flag, h264_inter, set for 6070.11.1: they are words of that firmware's commands, and T6000 and T8112 run the same firmware version. Those two were not run with them; their encoded H.264 changes. The lambdas were tuned on one 720p clip and checked with CBR at 720p and 1080p. The pinned T6000/T8112 command bytes are built with the flag off and do not change; a new test checks what the flag writes. Assisted-by: Grok 4.7 Assisted-by: Claude Opus 5.5 Signed-off-by: Lucas Goossen <lucas.goossen@hey.com>
2845ce4 to
54d46ac
Compare
|
Thanks for the review. The updates are pushed; replies to each of your comments below. Re: convention point; rows on M1 Pro and M2 Moved, see the next reply. Thanks for offering the rows; here are the J475c results from this r4 build (
Re: three requests
|
|
Thanks for moving these onto the layout and for switching to #2218's reader. On One small change: |
6070.11.1 offers constant quality only, because the driver's CBR value, 2, holds the Start QP on that firmware. On a J475c (T6021), mode 1 moved slice QP with the bit rate. Without B pictures the coded rate stayed under the target; for CBR the host's filler data then brought 1.0 and 2.5 Mbit/s (720p) and 4.0 Mbit/s (1080p) within 15% of the target over the file and over its last 150 frames. Submit mode 1 for CBR and VBR and offer both. With a frame interval of 1000/30000 s every frame sat at the QP ceiling: about 0.31 Mbit/s coded for a 1.0 Mbit/s target. Give the firmware the frame rate rounded to an integer, over 1. The client's timeperframe and G_PARM are not changed, and the session keeps timeperframe exactly (client_fps_num, client_fps_den) for the VUI timing, which must not follow the firmware's rounded rate. A new frame rate written into the Process frame-rate words while streaming stepped the HEVC picture clock backwards. Keep the Start rate there; store a rate set by S_PARM while streaming in the context, not the session (the worker frees the session without vdev_lock), and scale the next Process bit rate and VBR limit by start rate / new rate so the bits per frame follow. An HEVC stream at 30, then 15, then 30 frames per second kept every picture. The CBR filler budget uses the live bit rate and frame rate, and drops a surplus above the buffer size after a rate cut. Key this on a new layout flag, rate_control, set for 6070.11.1: the mode numbering is that firmware's, like rc_mode_fixed_qp beside it. T6000 and T8112 run the same firmware version and were not run with it. They now also offer CBR and VBR; constant quality stays the default, and its frame rate is rounded the same way. Assisted-by: Grok 4.7 Assisted-by: Claude Opus 5.5 Signed-off-by: Lucas Goossen <lucas.goossen@hey.com>
Default the B-frames control to 0 on a low_delay layout, and without B-frames wait for each frame's reply before submitting the next, as for the first frame of every session. A second session on the same encoder waits behind that frame. Set it for 6070.11.1. Every T6021 measurement in this series was made this way; submitting frames ahead without B-frames was not measured on any 6070.11.1 SoC. On T6000 and T8112 this changes the defaults: B-frames 3 to 0, and one frame in the firmware at a time. A client that asks for B-frames still gets them and their pipelining. Assisted-by: Grok 4.7 Assisted-by: Claude Opus 5.5 Signed-off-by: Lucas Goossen <lucas.goossen@hey.com>
6070 firmware writes the parameter sets to a buffer of their own. On a J475c (T6021) the SPS there had no VUI timing, and with B-frames off no VUI at all, so a raw Annex B reader guessed 25 fps. When an SPS from that buffer has no timing_info, rewrite it in the output buffer: set timing in an existing VUI, or add a minimal one. The timing is the client's timeperframe exactly, not the integer rate the firmware gets: H.264 gets num_units_in_tick equal to the denominator and time_scale twice the numerator, with fixed_frame_rate_flag, which is how H.264 codes a frame rate; HEVC gets vui_num_units_in_tick equal to the denominator and vui_time_scale equal to the numerator. The rate is taken in lowest terms, so 60/2 gives the bytes of 30/1, and 30000/1001 gives 1001 and 60000 (H.264) or 1001 and 30000 (HEVC). ffprobe on a raw H.264 stream prints the field rate (60/1 at 30 fps) and an MP4 mux reports 30/1. When twice the numerator does not fit 32 bits, H.264 halves an even denominator instead; with an odd one there is no exact form and the SPS is left as written. The rewrite is keyed on the stream, not on a SoC or firmware flag: an SPS that already has timing is left alone, and so is one this walk cannot follow (scaling lists, POC type 1, more than one HEVC sub-layer, more than 256 bytes). Firmware that puts its parameter sets in the coded buffer (9003, 26A428) is not touched. The SPS is read with the RBSP reader of the T8142 slice-type probe in aurora-silicon#2218 (struct ave_rbsp, ave_rbsp_init(), ave_rbsp_bit(), ave_rbsp_ue()), with ave_rbsp_get() and ave_rbsp_get_ue() added and the buffer raised to 256 bytes so a whole SPS fits. Whichever of the two lands second drops its copy. Assisted-by: Grok 4.7 Assisted-by: Claude Opus 5.5 Signed-off-by: Lucas Goossen <lucas.goossen@hey.com>
54d46ac to
4f6e71b
Compare
|
Good catch, thanks. Fixed: the firmware still gets the rounded rate, and the VUI now comes from the client's What changed
KUnit vectors (
I built the expected bytes from the 30/1 vectors by replacing the two timing words, not with the driver's code. Checks (arm64 build host): KUnit New tips
I have not run the new 30000/1001 stamp on the J475c; the KUnit vectors are the check so far.
|
|
Thanks for the fix. The firmware keeps the rounded rate, and both VUI stamps now take the client's The |
|
Here are the Each arm is its own boot of the same kernel, with
Commit 3 misses the 5% bar on both Macs, so as agreed, please drop it. With it reverted, the H.264 stream is byte-identical to this head's, so the cost is only the one-frame-at-a-time submission. One more observation: with gst defaults, #2374 alone produced no B-frames on either Mac. Its streams are byte-identical to the current driver's, so the "three B-frames, pipelined" path isn't what a default gst client gets. Commit 1 fixes a real bug on T6000 and T8112. Today's H.264 stream is an IDR followed by non-reference P pictures that all carry Details
Assisted-by: LLM (Claude:Opus 5.5) |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Pre-PR Checklist Review (§1–§6) — 4f6e71b51956f7cb7d8ea26d343799983972fed0
Commits 1, 2, and 4 are technically strong — in particular, commit 1 (d0b0e0aa187c, h264_inter) fixes a confirmed H.264 7.4.2.1.1 POC-type-2 / frame_num compliance bug on T6000 and T8112 (verified by @RyanTheTide in #issuecomment-7080614409: 120/120 frames decoded bit-exact and in order via v4l2slh264dec vs 4/120 before). However, four hard blockers prevent merging this PR as-is.
Blockers
-
§4 Hard Blocker — AI trailers (
Assisted-by:) inside commit messages:
All 11 commits in the PR (including all 4 top commitsd0b0e0aa,a73782b5,5ac02307,4f6e71b5and the 7 stacked#2374commits) containAssisted-by: Grok 4.7and/orAssisted-by: Claude Opus 5.5trailers in the git commit messages. Per §4 of the pre-PR checklist, commits must carry human author/committer and humanSigned-off-by:trailers only (zero AI trailers in commit messages; keep theAssisted-by:disclosure in the PR body only). -
§2 / §5 Blocker — Drop commit 3 (
5ac023072f70,low_delay) per M1 Pro & M2 measurements:
Per @RyanTheTide's A/B benchmark in#issuecomment-7080614409,5ac023072f70regresses 1080p encode throughput on both T8112 (M2) and T6000 (M1 Pro) by −13% to −25% across every cell (−22%M2 H.264,−13%M2 HEVC,−25%M1 Pro H.264,−19%M1 Pro HEVC), missing the agreed 5% bar. Reverting5ac023072f70restores throughput to within−3%to+1%while keeping the H.264 stream byte-identical. Please drop commit 3 as agreed. -
Merge conflicts (
DIRTY) onintegration/auroraand unmerged#2374stack:- The branch is 643 commits behind
integration/auroraand has merge conflicts acrossdrivers/media/platform/apple/ave/(ave-drv.c,ave-sess.c,ave-layout.c,ave-v4l2.c,ave-abi-test.c, etc.) after#2675(T8122/T8132/T8142 27.2),#2697(host harnesses), and#2778(per-device debugfs and workqueue names, which overlaps#2374'sdce6e177). - All 7 commits from still-open
#2374are currently carried here. Because commit 1 (d0b0e0aa, H.264 P-picture references / POC-type-2 fix) is a standalone correctness fix for already-shipped T6000 and T8112 encoders with zero regression, consider either splitting commit 1 ontointegration/auroraindependently or rebasing the stack cleanly once#2374is rebased/merged (and checking deduplication against#2218's RBSP reader if landed).
- The branch is 643 commits behind
-
§5 Evidence — Final rebased head hardware verification:
- T6000 (M1 Pro) and T8112 (M2) now have decode-order and throughput A/B evidence for commit 1 +
5ac02307reverted (#issuecomment-7080614409, 0 SErrors / DART faults / failed units). - After dropping commit 3 and rebasing, please run the remaining unrun hardware checks noted in the PR body ("Not done yet"): J475c (T6021) with pipelined submission (commit 3 dropped) and the
30000/1001VUI stamp, plus T6000/T8112 CBR/VBR and VUIr_frame_ratechecks.
- T6000 (M1 Pro) and T8112 (M2) now have decode-order and throughput A/B evidence for commit 1 +
Code Audit Notes (Commits 1, 2, 4 — Non-blocking)
- Commit 1 (
d0b0e0aa,h264_inter): Clean and well-bounded; KUnit covers bothh264_interon/off and confirms HEVC timescale is untouched. - Commit 2 (
a73782b5,rate_control): Good separation of firmware rounded rate (fps_num/fps_den) vs exactclient_fps_num/client_fps_den, and good CBR surplus clamp on rate drop. Minor: consider pairingWRITE_ONCEinave_s_ctrl()forctx->bitrate/ctx->bitrate_peakto match theREAD_ONCE()calls inave_sess_cbr_fill()/ave_build_process(), and noteDIV_ROUND_CLOSEST(t->denominator, t->numerator)inave_s_parm()can overflow 32-bit addition if userspace passesdenominatornearU32_MAX. - Commit 4 (
4f6e71b5, VUI timing): ITU-T H.264 Table E-1 and H.265 Table E.1 SPS/VUI bit walks,ave_vui_ticks()32-bit overflow handling, and KUnit vectors all check out cleanly. Minor:ave_h264_stamp_timing()andave_hevc_stamp_timing()each placestruct ave_rbsp+rebuilt[320]+escaped[384](~968 B + locals) on the stack, which is close to a 1024-byteWframe-larger-thanlimit if built with a tighter frame warning threshold.
Checklist Summary
- §1 No model gating: PASS (layout flags on
ave_layout_6070_11_1, stream-driven VUI rewrite). - §2 Production-ready: FAIL (drop
low_delaycommit 3; resolveDIRTYconflicts onintegration/aurora). - §3 Safety: PASS.
- §4 Clean-room & attribution: FAIL (
Assisted-by:trailers in all 11 commits). - §5 Evidence: PARTIAL (T6000/T8112 decode-order & perf verified via
#issuecomment-7080614409; rebased final-head rows pending). - §6 Naming: PASS.
Assisted-by: LLM (Gemini 4 Neon)
|
Commit 1 ( Would you like to send that commit as its own PR so it can land while the rest is reworked? If you'd rather not, we can open it for you with your authorship and sign-off kept as they are, and link it here. Either way, we will run the decode row on that head when it is up. Assisted-by: LLM (Claude:Opus 5.5) |
Stacked on #2374 (
ave/t6021). Review the top four commits.Base: #2374 (
ave/t6021,9aadf56a25ad). Four commits on branchave/t6021-rc(ludagoo/linux), tip4f6e71b51956. The settings are keyed on the firmware, not the machine: three are flags ofstruct ave_fw_layoutset inave_layout_6070_11_1, and the VUI timing is keyed on the stream. So T6000, T8112 and T6021 all get them. They were measured on T6021 (J475c) only.keep 6070.11.1 H.264 P pictures as references (
h264_inter,d0b0e0aa187c). With the Process timescale word nonzero, every H.264 P slice hadnal_ref_idc0; with it zero, P slices havenal_ref_idc1 andframe_numcounts up. The driver writes zero for H.264; HEVC keeps it. The three motion lambdas at Start 0xff98 (full-pel search), 0xffa4 (inter mode decision) and 0xffa8 (intra mode decision): with all three zero, about 94% of P macroblocks were 8x8 partitions and constant quality 0 on a 720p lecture clip came out at 8.4 Mbit/s. With 64, 256 and 64, 8x8 partitions became rare, the same clip came out at 0.30 Mbit/s, and quality 50 took 1.8 times the bits of libx264 at the same PSNR. The values were tuned on that one 720p clip.offer CBR and VBR on 6070.11.1 (
rate_control,a73782b55f09). Rate-control mode 2, the driver's CBR value from 9003, held the Start QP; mode 1 moved slice QP with the bit rate. CBR and VBR both submit mode 1. With a frame interval of 1000/30000 s every frame sat at the QP ceiling (about 0.31 Mbit/s for a 1.0 Mbit/s target), so the firmware gets the frame rate rounded to an integer, over 1; the client'stimeperframeand G_PARM are unchanged, and the session keepstimeperframeexactly for the VUI timing (commit 4). A new rate written into the Process frame-rate words while streaming stepped the HEVC picture clock backwards, so the Start rate stays there and the next Process bit rate and VBR limit are scaled by start rate / new rate; an HEVC stream at 30, then 15, then 30 fps kept every picture. The host CBR filler budget follows the live rate. The filler itself is upstream's.encode 6070.11.1 one frame at a time by default (
low_delay,5ac023072f70). B-frames default to 0, and without B-frames each frame's reply is awaited before the next is submitted. A second session on the same encoder waits behind that frame. On T6000 and T8112 this changes today's default (three B-frames, pipelined); see "Open question" below.add VUI timing to 6070 parameter sets that lack it (
4f6e71b51956). On T6021 the SPS had no VUI timing, and with B-frames off no VUI at all, so a raw Annex B reader guessed 25 fps. The driver adds timing to an SPS that has none, in the output buffer, from the client'stimeperframeexactly (not the integer rate the firmware gets): H.264num_units_in_tickthe denominator andtime_scaletwice the numerator, withfixed_frame_rate_flag; HEVCvui_num_units_in_tickthe denominator andvui_time_scalethe numerator. The rate is taken in lowest terms, so 30/1 gives 1 and 60 (H.264) or 1 and 30 (HEVC), the same bytes as before, and 30000/1001 gives 1001 and 60000 or 1001 and 30000. If twice the numerator does not fit 32 bits, H.264 halves an even denominator instead; with an odd one the SPS is left as written. ffprobe on a raw H.264 stream prints the field rate, 60/1 for a 30 fps stream and 60000/1001 for 30000/1001; that is the field clock, the stream is 30 fps (an MP4 mux reports 30/1 and 30000/1001). An SPS that already has timing, or that the walk cannot follow (scaling lists, POC type 1, more than one HEVC sub-layer, longer than 256 bytes), is left as written. There is no flag: it runs for every 6070 parameter-set buffer.The bit reader is media: apple: ave: 26A428: 60 fps and no-B sessions, B-picture flags #2218's (
struct ave_rbsp,ave_rbsp_init,ave_rbsp_bit,ave_rbsp_ue, the same code), with the buffer raised toAVE_RBSP_BYTES(256) for a whole SPS, plusave_rbsp_getandave_rbsp_get_uefor the SPS walk. Whichever of the two PRs lands second drops its copy.What changes on T6000 and T8112
Not run there. For anyone running rows on an M1 Pro or M2:
timeperframe, so a 30000/1001 stream is stamped 1001 and 60000 (H.264) or 1001 and 30000 (HEVC).The pinned-bytes KUnit case from #2374 still checks T6000/T8112 Start and Process bytes, built with these layout settings off.
Open question:
low_delayThe review asked for all four settings to be keyed on the firmware. I moved
low_delaytoo, so that the three chips run one configuration, but I think it is a default rather than a property of the firmware: it chooses latency over throughput, and on M1 Pro and M2 it turns off the three default B-frames and their pipelining. The alternative is to drop commit 3: every 6070 part keeps B-frames 3 and pipelining, and a T6021 client that asks for 0 B-frames gets submission ahead, which was not measured on T6021.Result, plainly
CBR undershoots, and CBR and VBR are the same encode. The firmware's coded rate stays below the target; for CBR the host then adds filler NAL units. With filler removed, CBR and VBR produced byte-identical streams in every row below: the VBR peak changes nothing at these rates. H.264 gets closest on hard content and with B pictures; HEVC sits at about 55% of target everywhere and is not tuned.
Overlap: #2218 (T8142 60 fps, on #1900) conflicts with this PR in
ave.handave-sess.cif it merges first; its reader is the one commit 4 uses, so the rebase removes one copy. #1900 (ave.h) and #1990 (ave.h,ave-abi-test.c) conflict textually. A rebase needs KUnit again, not hardware.Tested
apple-ave(arm64, LLVM) at every commit: 47, 48, 48 and 49 tests, all passing, no compiler warnings. New cases:ave_6070_h264_inter(timescale 0 only for H.264; lambdas; skip mode and static mask unchanged),ave_6070_rate_control(CQ, CBR, VBR words; live-rate scale; no scale without the flag), SPS timing vectors for H.264 with and without VUI and for HEVC, and three SPS that already carry timing and must come out unchanged. The same table has 30000/1001 for H.264 with and without VUI and for HEVC, rates that reduce to 30/1 (60/2, 30000/1000) with the 30/1 bytes, the 32-bit limits (H.264 3000000001/2 and 3000000001/3, HEVC 4000000000/3) and a zero rate. Each flag's case checks that 6070.11.1 sets it.checkpatch.pl --strict: 0 errors, 0 warnings, 0 checks on every commit.tools/asahi/run-host-tests.py --only ave: 6/6 at this tip.The largest coded second (30 consecutive pictures) went over target in three H.264 rows: lecture 1.0 (1.017 Mbit), pan 1.0 (1.076) and pan 2.5 (2.742, 10% over). HEVC stayed under in every second. CBR wire rates with filler on the lecture were 0.95 and 2.39 Mbit/s.
video_b_frames=3, the only nonzero step): I10 P150 B140. H.264 CQ 0.670 (PSNR-Y 42.16), HEVC CQ 0.518 (41.15), H.264 CBR 1.0 Mbit/s 1.020 coded (102%, 45.80), HEVC CBR 1.0 0.580 (58%, 42.10).h264_v4l2m2m/hevc_v4l2m2m,ffmpeg -f rawvideo -pix_fmt nv12 -s 1280x720 -r <rate> -i src720.nv12 -frames:v 300 -c:v <codec> -b:v 1M, thenffprobe -show_entries stream=r_frame_rateon the raw stream):-r 60gives 120/1 for H.264 (time scale 120, the field clock) and 60/1 for HEVC. ffmpeg leaves the bitrate mode at CQ, so these runs check timing, not rate. That output was read in the session; no log file was kept. That run was before the timing followedtimeperframe: it stamped 30000/1001 as 30 (60/1 H.264, 30/1 HEVC). With this version 30000/1001 is stamped 1001 and 60000 (H.264) or 1001 and 30000 (HEVC), checked by the KUnit vectors only, not on the J475c.r_frame_rate=30/1.Not done yet
r_frame_rateon the raw streams, the same checks the maintainer offered to run on M1 Pro and M2).bitstream_restrictionwithmax_num_reorder_frames = 0in the minimal VUI would cut decoder latency with B-frames off; not added.🤖 Generated with Claude Code