Repository navigation
Conversation
…lock The t602x trees describe the ranges at *020000 and *044000 next to each encoder as two more DARTs. On the M2 Max (J475c) apple-dart rejects the *044000 nodes: the stream count it reads from them is 385 at 40d044000 and 350 at 507044000, above its 256 limit. The *020000 nodes probe as DARTs. T600x describes the same two ranges as one apple,t6000-ave-dma block, with the DARTs at *030000 and *040000. Do the same on t6020 (ave0), t6021 (ave0, ave1) and t6022 (ave0 to ave3), and drop the two ranges from the encoders' iommus. The binding allows exactly these two ranges. A maintainer may prefer an apple,t6020-ave-dma compatible in front; the binding has none today. The encoders on J475c ran with only the *030000 and *040000 DARTs and showed no DART faults. t6020 and t6022 were not booted. Assisted-by: Grok 4.7 Assisted-by: Claude Opus 5.5 Signed-off-by: Lucas Goossen <lucas.goossen@hey.com>
|
Thanks, this is a clean correction. The two ranges that apple-dart rejects become one We built all eight t602x device trees at Once this is merged, #2376 can drop its copy of the commit. |
|
Thanks for the review. The updates are pushed; replies to each of your comments below. Re: binding: Thanks for building all eight. No change from me. The blocks are the same layout as T600x's, which is why they use |
Base:
integration/aurora0abc2f385e54. One commit (8b313f4d5640on branchave/t602x-dma, ludagoo/linux), independent of the driver PRs.The t602x trees describe two ranges next to each video encoder,
*020000and*044000, as DARTs. On the M2 Max (J475c) apple-dart rejects the*044000nodes: the stream count it reads there is 385 at40d044000and 350 at507044000, above its limit of 256. The*020000nodes probe as DARTs. T600x describes the same two ranges as oneapple,t6000-ave-dmablock, with the encoder's DARTs at*030000and*040000. (T603x and T8122 use a third form:*020000asapple,dart-smmuand*044000asapple,dapf, both disabled. T8112 has no node for either range.)This does the same as T600x on t6020 (ave0), t6021 (ave0, ave1) and t6022 (ave0 to ave3, both dies): one
dma-controllernode with the two ranges, the interrupt and the power domain the old nodes had, and the encoders'iommuskeep only the two real DARTs. Every node stays disabled. The binding already allows this compatible with exactly these two ranges; a maintainer may prefer anapple,t6020-ave-dmacompatible in front, which the binding does not have today.Tested
*030000and*040000DARTs attached, several hundred sessions, no DART faults. The blocks stay disabled there. With them enabled on that board,apple-ave-dmabinds and holds the VENC sys domains on (see the J475c PR); this PR enables nothing. media/dts: apple: enable the T6000 AVE DMA fault reporter with runtime PM #1861 (draft) describes the same effect on T6000 ("once the device bound genpd counted it as active and kept the encoder's power domain up for good") and adds runtime PM toapple-ave-dma; with that, a board could enable these blocks.scripts/dtc/apple-dt-check.sh 0abc2f385e54 <this commit>(dtschema 2026.9): all 137 Apple device trees build, 1404 CHECK_DTBS warning lines at base and head, none new and none removed. Re-run for this version on the eight t602x trees only (all 8 build with CHECK_DTBS, 481 schema findings at base and here, none new and none removed); the device tree files are byte-identical to the ones the full check ran on.checkpatch.pl --strict: clean.t6020 and t6022 were not booted.
Overlap: #2252 (t602x scaler, draft) and #1861 touch the same files and merge cleanly with this commit.
Not done yet
apple-ave-dmaon t602x unless a board does.🤖 Generated with Claude Code