Repository navigation
thermal: apple-pmp: find the T8132 clusters from the cores' nodes - #2234
DjDeveloperr wants to merge 1 commit into
Conversation
The policy checked each cpufreq cluster against fixed logical CPU masks,
with a J773g override (P cores 0 and 3-5). Linux numbers the CPUs from
the boot CPU and the device tree order, so the masks depend on the boot
path: on a J773g booted through aura the P cluster is CPUs 0 and 7-9 and
the E cluster 1-6, the override's masks do not match, and the setup fails
with -EINVAL ("apple-pmp-thermal: setup failed: -22"), leaving the Mac
mini with no thermal zone, no cooling devices and no rail power budget.
Build each cluster's members, and the CPU that names its policy, from the
cores' own compatibles (apple,donan-p and apple,donan-e) instead.
Signed-off-by: Diljit Singh <hey@djdev.me>
|
GPU effect, measured by the M4 mini GPU lane on the same Mac mini with this commit on its G16 kernel (m4gpu1 = #1191 + a J773g 25G83 fwid entry + this commit):
🤖 Generated with Claude Code |
|
No blockers. This replaces a board check ( The PR body ends with the "Generated with Claude Code" line rather than an HW row: an M4 MacBook Air (J713 or J613) on the same kernel and default command line: Assisted-by: LLM (Claude:Opus 5.5) |
Summary
apple-pmp-thermalchecked each cpufreq cluster against fixed logical CPU masks, with a J773g override (P cores 0 and 3-5). Linux numbers CPUs from the boot CPU and the device-tree order, so the masks depend on the boot path. On a J773g booted through aura, the P cluster is CPUs 0 and 7-9 and the E cluster is 1-6. The override doesn't match, and setup fails:That leaves the Mac mini with no thermal zone, no cooling devices and no measured-rail power budget.
This builds each cluster's members, and the CPU that names its policy, from the cores' own compatibles (
apple,donan-p,apple,donan-e), so they no longer depend on the numbering.Testing
Measured on the owner's Mac mini J773g (Mac16,10), 2026-11-19. The kernel was 7.3.0-ARCH-m4drv2 = m4mini/gpu-test e083527 (9125b31 + #1898 + #1191) + this commit + the J773g jack, Bluetooth and #1192 commits. It booted through aura with the J773g DT.
apple-pmp-thermal: setup failed: -22; cpufreq ownership retained,/sys/class/thermalempty. cpufreq policy0 = CPUs 0 7 8 9 (P), policy1 = CPUs 1-6 (E). The M4 GPU lane also saw the G16 cooling device held at 8 (GPU limited to S1, 338 MHz) with this failure.apple-pmp-thermal: T8132 provisional policy: ..., zoneapple-pmp-dieat 48.75 C, cooling devicescpufreq-cpu00/19 andcpufreq-cpu10/7,scaling_max_freqP 4104000 and E 2892000 (the hardware maxima).The file is identical on integration/aurora 0abc2f3 and on the tested base.
checkpatch --strictis clean.Assisted-by: LLM (Gemini:4 Neon)