Repository navigation
Conversation
|
Thanks for bringing High Power mode to the K116s. We select behaviour by a hardware description rather than a list of machines, and this turns the single machine string into a list: Whether a machine offers High Power mode is a property of the board (its cooling and power envelope), so it belongs in the board's device tree. Could you replace the list with a boolean on the clpc node, for example |
|
Following up on the DT property note above with the test that would show the mode working on the K116s, since High Power mode changes behaviour only under sustained load:
The same log on a J714s would confirm the existing behaviour there is unchanged. Removing the Once that is in we can run no-regression rows on our A18 Pro and M4 Pro, which use the same driver. |
d884286 to
6e0090d
Compare
|
Ryan, thanks. v2 is pushed: Tests at the v2 head (K116s, firmware 27.2):
balanced and performance under load were measured on the first version (same load, table in the description): fans 3900 rpm against 6250 rpm, PMP effort 57 to 66 against 37 to 44, throughput up about 4 %. I did not repeat them at v2: the only change is how the mode is selected, and the switch check above covers that. I used a fixed I have no J714s to run the no-regression row on. |
|
Thanks, v2 is exactly the shape we asked for, and the switch and low-power numbers cover the selection change. Accepting the openssl load and the v1 balanced/performance table is fine. One coordination note: #2310 adds the same For the J714s, the property keeps today's behaviour; a J714s owner's switch check ( |
macOS offers High Power mode on the 16-inch M5 Pro. Say so on the CLPC node, and keep the CLPC's SMC link the record is sent over, which was held back here until it had been tried. On a K116s the SMC on firmware 27.2 takes the record as the J714s's 27.0 does: in the performance profile the fans run up to their maximum under a sustained load, where they level off at 62 % of it otherwise. Signed-off-by: Jens Axboe <axboe@kernel.dk>
6e0090d to
fc11f94
Compare
v3 (2026-11-22): #2784 merged the binding and the driver side (
apple,high-power-modeon the CLPC node, set for the J616s and the J714s). What is left here is one commit: the K116s sets the property and keeps the CLPC'sapple,smclink the record is sent over. Rebased onintegration/aurorabb9f8ec.Without it the SMC's fan policy on the K116s keeps its Automatic ceiling whatever the profile: under a sustained load both fans level off at 62 % of their maximum while the PMP throttles to hold the die.
Measured on a K116s (firmware 27.2) with the first two versions of this PR, which differ from #2784 only in how the mode is selected. Four minutes of
openssl speed -multi 18 -evp aes-256-gcmper profile:On #2784's driver (bb9f8ec plus this commit and my K116s stack, 2026-11-22): the profile registers as
apple-clpcwith low-power, balanced and performance. In performance, two minutes of the same load took the fans from 0 to 6135 / 6683 rpm (maximum 6250 / 6750), past the 62 % they level off at without the record. The table above was not rerun.dtbs_checkadds no warning for the K116s.