Repository navigation
Conversation
|
Thanks for the Cyberpunk numbers; +25% is a big gain. We try to select behaviour by a hardware or firmware property rather than by the board it was measured on. This flips the per-board flag for one more machine ( Whether explicit waits can take the firmware's completion class is a property of the firmware interface, not of the board. Could you make it depend on that (the firmware build/layout that supports it), or turn it on for every M5 board and remove the field? If some board must keep it off, a comment with the reason would be the way. Before that, the two lost Vulkan devices you mention need the matched comparison with completion inputs disabled. We can help with rows on other machines. |
Whether a compute kick's explicit waits on other kicks take the completion class, held in firmware until the producer completes, was a per-board flag that only the J714 set. It is a property of the firmware interface and the host encodings, not of the board: derive it from them and drop the field. Boards on the T6050 firmware's M5 graph layout (J714G17S26A428) with the G17S/G17C host encodings take completion inputs. The layout is matched positively, so a board on any other layout keeps them off. This turns them on for the J716c (G17C) as well as the J714. The common interface (the J813) keeps its own kick forms, and the G17D keeps its qualified tuple and pipelined firmware waits; the reason for each is beside Board::completion_inputs(). A compile-time check pins the result for every board. On the J716c every compute kick now takes the counted form. A wait on a producer that does not declare a visible completion still waits on the host. Signed-off-by: Erik Bourget <erik@ebourget.net>
313543d to
aa1abb9
Compare
|
Note 🤖 Claude Opus 5.5 responding on behalf of erikwb Thanks. The field is gone: Why the four boards differed, from the history:
What the code now says:
These reasons are now comments on On the two lost devices, the matched run is done:
With completion inputs on, stock vkd3d-proton is 23.3% faster and the PR build 38.0% faster. Neither arm lost the device in these 43 launches. The two earlier losses didn't recur on either kernel, so this run doesn't tie them to completion inputs; it also can't rule out a rare loss. The description has the same table. Rows on other machines would help: a J714 with this head should see no change, and a J775D or J813 should see no change either. |
|
Thanks, this resolves the review. Since behaviour only changes on the J716c, where it is measured, we have no further rows to ask for. Assisted-by: LLM (Claude:Opus 5.5) |
|
Merge-train adversarial review (MERGETRAIN-LINUX2) at aa1abb9: NO BLOCKERS. Code read only, nothing built here. Before the merge it still needs Dj's verdict at this head; the missing rows are listed below. Full review#2207 drm/asahi: enable GPU completion inputs on J716c @aa1abb9aVERDICT: NO BLOCKERS Checked:
Effects on J716C:
Nits:
Missing rows:
|
DjDeveloperr
left a comment
There was a problem hiding this comment.
Review at aa1abb9a8ce5: 0 code, CI, policy, or attribution blockers.
Checked:
- Interface selection (§1): Removes the per-board
completion_inputsfield fromBoardand derivesBoard::completion_inputs()frommatches!(self.graph.profile, RootProfile::J714G17S26A428) && !self.g17d_forms, with clear comments explaining why J813 (common interface, no submission sequence / retired-parent relaxation) and J775D (G17D qualified tuple + pipelined waits) stay off, plus a compile-timeconstassertion pinning all five board definitions so J714, J775D, and J813 are unchanged. - Attribution (§4) & CI: Commit
aa1abb9a8ce5carries human author/committer andSigned-off-by:only;host-testsis green. - Performance & conformance (§5): The alternating matched A/B on J716c is solid (43 Cyberpunk launches, 0 Vulkan device losses on either arm, 0 GPU recovery/MMU fault/timeout lines, +23.3% stock / +38.0% PR vkd3d-proton, and identical 8,532 Pass / 6 NotSupported timeline-semaphore CTS).
Non-blocking nit:
drivers/gpu/drm/asahi/g17/fw/m5/initdata.rs:2926-2930: the doc comment says the check "follows the firmware interface the board runs", whereasself.graph.profileis the staticM5_GRAPHfamily (J714G17S26A428) even when runtime 27.2 selectsM5_GRAPH_26B123(works identically on 27.0 and 27.2, just slightly imprecise wording).
Still owed before approval/merge (§5):
- Full regression counts on the default kernel command line (0 SELinux denials, 0 failed units, 0 new kernel errors).
- A J716c confirmation row on
integration/auroraonce #2185 lands (since the A/B measurements were run on the unmerged #1173/#1650/#2185 stack).
Assisted-by: LLM (Gemini 4 Neon)
Whether a compute kick's explicit waits on other kicks take the completion class (held in firmware until the producer completes) was a per-board flag that only the J714 set. It is a property of the firmware interface and the host encodings, so
Board::completion_inputs()now derives it from them and the field is gone:RootProfile::J714G17S26A428, matched positively) with the G17S/G17C host encodings. That keeps the J714 as it was and turns them on for the J716c (G17C). A board on any other layout keeps them off until its kicks are known to take that form.The reasons are commented next to
Board::completion_inputs(). A compile-time check pins the result for every board: on for J714 and J716C, off for J775D, J813 and J813 on 26B123.On the J716c every compute kick now takes the counted form (ordinal as submission sequence, completion-class parent while it runs), whatever the userspace. A wait on a producer that does not declare a visible completion (
DRM_ASAHI_COMPUTE_VISIBLE_COMPLETION) still waits on the host. Only userspace that sets that flag gets firmware waits.Testing on the J716c (an earlier head with the same effect on this board): in Cyberpunk 2077 at 3840×2160, High with FSR2 Balanced, the two control runs rendered 18.26 and 17.75 FPS. With completion inputs on, they rendered 22.52 and 22.61 FPS (+25.3% across the means). Both kernels passed 64 of 65 synchronization CTS cases, with one unsupported and zero failures. Two game launches with completion inputs on lost the Vulkan device while a render queue waited for its completion stamps.
Matched comparison on the J716c. Two kernels were built from the same tree, the J716c daily (integration/aurora with the board enablement below) plus this change. They differ only in that the control returns false from
completion_inputs()on every board. Boots alternated (on, off, on, off), with the same Mesa build, the same settings, the desktop up and the 140 W adapter connected. Each boot ran Cyberpunk 2077 at tier T2 of issue #457 (2560×1600), with 5 launches on stock vkd3d-proton (one launch on the first boot didn't start because another benchmark held the lock) and 3 pairs of passes on the PR build of vkd3d-proton.dEQP-VK.synchronization*.op.multi_queue.timeline_semaphore.*, 8,538 cases)With completion inputs on, stock vkd3d-proton is 23.3% faster and the PR build 38.0% faster. Neither arm lost the device in these 43 launches, so the two earlier losses did not recur here, on either arm.
tools/asahi/run-host-tests.pyon this head: 426 of 427 runs pass locally. Theapple-dcpselftest run also fails, with the same 15 subtests, on a tree with the same base and without this change. The arm64 kernel with this commit builds with the J716c daily configuration.To boot the J716c, the test kernel also included the board enablement in #1173, #1650 and #2185.
Assisted-by: LLM (Claude:Opus 5.5)