Repository navigation
arm64: dts: apple: t6041-j616c: system power state for the port controllers - #2174
AxxzyWasTaken wants to merge 1 commit into
Conversation
7d925f6 to
c9140b0
Compare
|
Looks good; approve once the J616c suspend-to-RAM row below is on this head with #1664. The DT change itself is correct: the four nodes exist in t6041-j614c-j616c.dtsi (hpm0/hpm1 on nub_spmi_a0, hpm5 at 0x8, hpm2 on nub_spmi_a1), all are interrupt-driven, so
HW row: J616c (M4 Max), this head + #1664 on current integration/aurora, default command line, Assisted-by: LLM (Claude:Opus 5.5) |
|
Rebased onto |
c9140b0 to
a9cb8bb
Compare
…ollers macOS tells the USB-C port controllers the system power state (SSPS), S3 before a sleep and S0 after it. The tipd driver does the same around a firmware-driven suspend for a controller with apple,sleep-ssps, as the J700, J714s, J716c and J813/J815 have. Give it to the J616c's four SN201202x controllers: hpm0, hpm1, hpm2 and MagSafe's hpm5. Signed-off-by: AxxzyWasTaken <axxzytte@gmail.com>
a9cb8bb to
7b1a2f3
Compare
|
Rebased onto |
Depends on #1664 (draft until it lands). It doesn't need #1664's commits to apply.
macOS tells the USB-C port controllers the system power state (SSPS): S3 before a sleep and S0 after it. For a controller with
apple,sleep-ssps, the tipd driver does the same around a firmware-driven suspend. The J700, J714s, J716c and J813/J815 have the property; the J616c's four SN201202x controllers don't. This adds it to hpm0, hpm1, hpm2 and MagSafe's hpm5.The property only matters for a firmware-driven suspend, which T6041 gets from #1664. It has nothing to do with #1889's idle sleep, which is runtime PM. On the J616c, the driver uses the plain SSPS path (no
tipd_sleep_ssps_rules()): a failed S3 is a warning, not a refused sleep.Testing
apple,sleep-sspson the fourusb-pdnodes. No new dtc warnings withW=1. I couldn't rundtbs_check(no dtschema here); the sn201202x binding already has the property.Assisted-by: LLM (Anthropic:Claude Opus 5.5)