Repository navigation
arm64: dts: apple: t6041: link the GPU to the CLPC - #2173
AxxzyWasTaken wants to merge 1 commit into
Conversation
|
Tested on the J614c (16-core CPU / 40-core GPU M4 Max), together with #1369, on top of #1664. With this, the GPU is linked to the CLPC: 🤖 Generated with Claude Code |
|
Thanks. This is the same link The code looks good to us. Your plan to land it after #1369, so that the M4 Max never runs with the M4 Pro's GPU floor, makes sense. When you take it out of draft, a short row on the exact head with #1369 would complete it. On a J616c or J614c: the GPU listed as a CLPC consumer, the GPU floor engaged while glmark2 runs, and ten minutes without GPU faults. joske's J614c result already covers most of that. |
|
The row on the exact heads, on my J616C (binned T6041). Kernel: 7.3.0-j616c-s2rR = #2175 head 4c4ebec (on #1664 c767947, integration/aurora 391fac6) + #1369 head f4adbb5 + this PR's head 90ee582. Both merged without conflicts. I used the tree's own t6041-j616c.dtb (50c5b341). One-shot boot, 0 failed units.
I'll take this out of draft once #1369 lands, so that the M4 Max never runs with the M4 Pro's GPU floor. Disclosure: prepared with an AI tool (the commits carry Assisted-by: LLM); tested as described. |
The T6040 GPU node names the CLPC with apple,clpc; the T6041 one does not, so the CLPC driver never links the M4 Max GPU and the GPU's work never reaches the CLPC. Add the link as t6040.dtsi has it. All three T6041 boards (J575c, J614c, J616c) enable the PMC the CLPC sits on. Signed-off-by: AxxzyWasTaken <axxzytte@gmail.com>
90ee582 to
55196b8
Compare
|
Closing as superseded by #1951 (commit |
Depends on #1369 (draft until it lands). It doesn't need #1369's commits to apply.
The T6040 GPU node has
apple,clpc = <&clpc>, but the T6041 one doesn't. Soapple_clpc_gpu_get()finds no CLPC for the M4 Max GPU, and the GPU's work never reaches the CLPC. With the upstream DT, #1369's busy-share floor and light effort do nothing on T6041. This adds the link ast6040.dtsihas it.Why it waits for #1369: T6041 uses the T6040 CLPC table today. With this link alone, the M4 Max GPU would get the M4 Pro's GPU floor (DCS 5 / fabric 2 while GPU work is in flight). That combination never ran on the Max. #1369 gives T6041 its own table.
All three T6041 boards (J575c, J614c, J616c) enable the PMC that the CLPC sits on, so the GPU won't wait for a CLPC that never probes.
Testing
apple,clpcpointing atapple,t6041-clpc. No new dtc warnings withW=1(30 before and after). I couldn't rundtbs_check(no dtschema here); the AGX binding already listsapple,clpc.Assisted-by: LLM (Anthropic:Claude Opus 5.5)