Repository navigation
arm64: dts: apple: t6050-k114c: add the deep-sleep controller node - #2089
joshuaswarren wants to merge 2 commits into
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
|
CHANGES on 21d241e Claude review, exact head. One finding, message only. The tree is clean. Finding: neither commit has a Signed-off-by. What I checked (sparse checkout of this head, gcc preprocessor plus
Notes, not findings:
I will re-review and post GREEN when the Signed-off-by lines are in. |
21d241e to
8f72413
Compare
|
w7X: Signed-off-by added to both commits via rebase --signoff (original author kept; new head 8f72413). Tree unchanged. |
|
GREEN on 8f72413 Claude review, exact head. This closes my CHANGES on
Not covered: |
8f72413 to
218d09f
Compare
|
GREEN on 218d09f Independent review at the rebased head by a second model family, posted by [Joshua's agent] on the reviewer's behalf. |
|
Thanks Joshua, moving the T6050 sleep match off the J714s is the right direction. Three points on the code:
Row still needed on the K114c: boot with the node and the sleep driver probes without "unsupported board/CPU inventory". Once the boot loader's SoC data is in the node: Since |
|
[Joshua's agent] Thanks, Ryan. Three points on #2089 at head 1. Duplicate Agree. At this head the K114c file is 233 lines and differs from 2. Max profile: J716c sleep data vs J714s copy I have no K114c sleep boot receipts yet: no probe line, no Static facts checked in the tree (not boot):
Position: J716c Max soc plus J716c sleep device files is plausible for a K114c Max without PMP, but it is unproven here until the boot row runs. I will not widen the DTS to J716c shapes without a measured pass that shows the sleep driver probes and suspends cleanly. If the first boot fails inventory or region setup, that is the fork to document. 3. Understood on I have not re-run the compile-only inventory proof on I will not remove Row still owed (K114c, unbooted on this PR today): probe without "unsupported board/CPU inventory"; then Skipped: dtbs_check on latest integration tip; J716c sleep DTS swap without boot. |
|
Thanks Joshua. Yes, please go ahead with the code change on this PR:
The K114c row is unchanged: probe without "unsupported board/CPU inventory", then |
218d09f to
ae610ba
Compare
|
Thanks Joshua. The latest push seems to have come from the wrong base. The PR now has 10 commits: besides your two, it carries eight from the J775c compatibility work (acio routers, DROM placeholders, PCI Clock PM, the J775c board consolidation, the G17C binding), about 7k lines that belong to #1619 and #1618. Your two commits are unchanged: Could you reset the branch onto
The K114c row is unchanged. |
|
Inspection evidence (no K114c boot claim): at the pinned integration base 26294e8 and #2201 head 965c1b5, the MPIDR/CPU-count check remains inside |
|
Thanks, you're right. At the base, the boot-MPIDR and CPU-count check in Still missing:
|
- Reuse J716c's disabled Max description instead of a copied J714s file. - Keep the controller disabled until K114c sleep is qualified. - Preserve K114c's SIO alias and MagSafe controller status. - Do not enable the unqualified full profile. Signed-off-by: Joshua Warren <816217+joshuaswarren@users.noreply.github.com>
- Validate CPU inventory when a profile provides MPIDR or CPU count. - Remove machine metadata from both T6050 entries and KUnit assertions. Signed-off-by: Joshua Warren <816217+joshuaswarren@users.noreply.github.com>
ae610ba to
50ae77a
Compare
|
Reset complete: PR head is
|
|
Thanks for the reset: two commits on current integration, the K114c reusing the existing disabled J716c sleep description instead of a 233-line copy, and the MPIDR/CPU-count check now running whenever a profile supplies either, with |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Looked at 50ae77a. The shape is right: the K114c includes the disabled J716c sleep description, and the CPU-inventory check (sleep.c:1895-1898) now runs whenever a profile sets boot_mpidr or cpu_count. Neither .machine remains.
Not merging yet:
- It's a draft, and it conflicts with
integration/aurora(DIRTY). The base moved about 326 commits past 26294e8, includingt6050-k114c.dtsandsleep-t6050.h, so it needs a rebase onto the current tip. - The K114c (14-inch M5 Max) row is still open, as Ryan listed it. Run it on the rebased head:
- The sleep driver probes with no "unsupported CPU inventory" line.
rtcwake -m mem -s 30passes three times.- A lid close/open wake and a power-key wake both work.
- After each resume,
dmesg --level=erris empty, a USB device comes back, andping -c 5passes over Wi-Fi.
sleep.c is shared, so once that row is in we'll run the no-regression sleep rows on J714s and J700 before merging.
Assisted-by: Claude Opus 5.5
|
Note wAK (AI assistant) responding on behalf of joshuaswarren Acknowledged: shape accepted, rebase first. Next action is rebasing the two commits onto the current |
|
Blockers: 2. Not superseded: no K114c sleep node is on integration/aurora (the tip's
Nit: the PR title and body still describe the old 233-line The HW row: K114c on the rebased head. The sleep driver probes with no "unsupported CPU inventory" line, the rtc list is as above, and there are 0 failed units, 0 AVC and no new Assisted-by: LLM (Claude:Opus 5.5) |
Summary
Ports the T6050 (K114c / M5 Max) deep-sleep controller node and SoC-match
fix from our k40u series:
8dddc6162b57—arm64: dts: apple: t6050-k114c: add the deep-sleep controller node(newt6050-k114c-sleep.dtsi, 233 lines, plus theinclude in
t6050-k114c.dts)c166fc4296c49—soc: apple: sleep: T6050: match the board by the SoC, not the J714s(sleep-t6050.h+sleep.cdisplay-powerhand-off compatible)
The node copies the J714s sleep controller shape: cluster power gates,
AOP2/SIO mailboxes, port-controller sleep state. Register banks are the
T6050 pmgr/cluster/watchdog/SPMI/PMC/PTD/clockgen/memory-controller
pages shared with J714s. Per the source commit message, the boot
loader's SoC data is not in the node yet, so the driver has no commit
schedule and does no deep sleep — this lands the DT/driver plumbing,
not an active sleep path.
Port notes
Cherry-picked onto
integration/aurora@bf423bf0. The original saton a k40u file layout that also carried
t6050-k114c-display.dtsiandthe qspi/nvram block (separate, not-yet-upstreamed work); upstream has
neither, so the include lands at end of file. The sleep.dtsi itself is
unchanged.
Verification
t6050-k114c.dtbcompiles clean via the kernel dtc path(
gcc -E -D__DTS__+scripts/dtc/dtc -b 0): only pre-existingwarnings in
t6050-k114c-gpu.dtsi/t6050-peripherals.dtsi, nonefrom the new file.
M5 Max deep-sleep enablement is future work; this is DT plumbing only.
Generated with Devin