Repository navigation
soc: apple: sep: fail key operations when credential disposal fails - #2048
Conversation
|
@RyanTheTide, could you approve CI on #2048–#2051? They're my first PRs here, so They replace #1004, retargeted to |
A password-authorized sign or unseal creates an unlock evaluation in the enclave and deletes it afterwards. The deletion's answer was ignored, so a result could be returned while the credential context it was authorized by might still be live. Confirm the deletion before a result leaves the driver, and discard the result if it fails. An unconfirmed deletion latches key operations off until the driver restarts (a reboot or a module reload), so nothing later runs against a context that may still hold the credential; capability queries and cancellation stay available meanwhile. The KUnit cases and the host test run the production guard for success, early exits and a failed deletion, checking that the result is destroyed and that deletion is attempted exactly once. Assisted-by: LLM [Claude Code, claude-opus-5-5] Signed-off-by: Cameron Cooper <c@meron.cc>
fd781ee to
7723f3d
Compare
|
Blockers: 1. The guard itself is sound.
HW row: on the J293 with this build, run the password sign and unseal, then 10 Touch ID unlocks, then password sign and unseal again, all passing. Show Assisted-by: LLM (Claude:Opus 5.5) |
e38a73c
into
aurora-silicon:integration/aurora
A password-authorized
SEP_KEY_SIGN_PASSWORDorSEP_KEY_UNSEAL_PASSWORDcreates an unlock evaluation in the enclave and deletes it afterwards. The deletion's answer was ignored, so a result could be returned while the credential context it was authorized by might still be live.This confirms the deletion before a result leaves the driver and discards the result if it fails. An unconfirmed deletion latches private key operations off until the driver restarts (a reboot or module reload);
SEP_KEY_GET_INFOandSEP_KEY_CANCELstay available. This is the "unconfirmed credential disposal" case that warrants a quarantine; ordinary refusals, misses and cancellations are unaffected.Tests
apple_sep_key_one_op): two new cases drive the production guard for success, early exits and a failed deletion, checking that the result is destroyed and that deletion is attempted exactly once.tools/aurora-sep/tests/test_key_context_cleanup.py(same pattern astest_refkey_seal_admission.py), added to thesep-sourceworkflow.test_log_ratelimit.pypasses; the module builds for arm64 with no new warnings.Hardware
🤖 Generated with Claude Code