Repository navigation
Conversation
5fcabb9 to
b5d5dfa
Compare
|
Thanks for the thorough J414c rows: the tunables count, 10/10 s2idle with display, Wi-Fi and USB checked after each wake, and the idle power table. One request on the shape. The extra rows for the SoC-level form, where an owner can run them: one other T602x machine (e.g. a J475c) with |
Move APPLE_USE_PMP to the T6021 SoC include. T6020 inherits it from that include, so drop the J414s board define. Pair the DTBs with a bootloader that can copy the PMP tunables. T6022 needs a separate change for its second-die AVD power domain. Link: aurora-silicon/aura#268 Signed-off-by: Muness Castle <931+muness@users.noreply.github.com>
b5d5dfa to
1500657
Compare
|
Thanks, 1500657 is the shape I asked for. One merge-order point: this depends on aura#268 (OPEN), which makes room for the PMP tunables in the boot device tree. Merging the DTBs first would leave the PMP node enabled on loaders that can't copy them. So please land aura#268 first, or confirm what the PMP does on these boards when its tunables are absent. If it then stays off cleanly, the order doesn't matter. Approving with that ordering. Assisted-by: LLM (Claude:Opus 5.5) |
Move
APPLE_USE_PMPinto the T6021 SoC include. T6020 inherits it from T6021, so the J414s board-level define can go. The PMP can then manage fabric and DCS p-states on M2 Pro and M2 Max. Ship these DTBs after the Aura loader fix.Enabling the same define on T6022 exposed a missing
pmp_report_avd_sys_die1phandle. M2 Ultra needs a separate change to describe that power domain.DTB build
All eight T602x DTBs build with Aurora’s bundled dtc. J414s and both M2 Ultra DTBs are byte-for-byte identical to the base. Five boards gain the PMP alias (J416s, J474s, J414c, J416c, J475c).
J414c results from the board-level trial
On Aurora Alarm -40, the original board-level DTB booted with patched Aura, passed 87 tunables (13,220 value bytes), and logged
PMP firmware and endpoint readyandPMP manages fabric and DCS p-states. The DTB SHA-256 isad16664a8cbc1e323bb883999a741ae1ca9fae20b0aa57c4aedc787c5ab28058.The original board-level DTB passed 10/10 s2idle cycles on a J414c with patched
Aura
52af355c, Aurora Alarm -40 and a Microsoft Surface Thunderbolt 4 Dock.The built-in panel returned, the stock BCM4388 driver reconnected and
answered a Wi-Fi gateway ping, and 22 USB devices enumerated after every
wake. The Wi-Fi reload workaround was disabled. PMP stayed enabled.
Suspend durations in seconds, cycles 1–10: 24.7, 31.1, 30.6, 37.9, 49.1, 69.2, 27.4, 32.0, 43.6, 33.2.
Each wake logged a DRM resume error (
-22), USB4 DisplayPort discovery andtunnel messages, and DCP lane-count warnings. Nine wakes also logged USB
descriptor errors (
-32) on a dock hub and USB audio sample-rate warnings.The devices still enumerated. The cycle logs contain no PMP or RTKit warnings.
The PMP-on boot logged that
pmp-isp-syswould stay powered. The Aura PR records thestock bootloader failure and patched boot comparison.
Screen-on idle power
J414c on battery at 40% built-in brightness with the dock unplugged. Both
boots used Aurora Alarm -40, the same Aura Stage 2 and U-Boot, and differed
only in the J414c DTB. Each run settled for 60 seconds, then sampled the SMC
power sensors at 1 Hz for 240 seconds.
One run per setting, PMP on first. CPU activity averaged 2.7% with PMP off
and 3.6% with PMP on.
Review checklist
PMP manages fabric and DCS p-states, and run three s2idle cycles with no PMP or RTKit warnings.Assisted-by: LLM (OpenAI:GPT-6.2-sol)