Repository navigation
hwmon: macsmc: offer the SoC die zone to a device tree thermal zone - #1908
m0d16l14n1 wants to merge 2 commits into
Conversation
|
@DjDeveloperr out of draft, parent-first on #1532 (alias fix merged in). J815 soak: peak 99.4 °C, settles at about 99 °C with the P cluster held at 2508 MHz by the IPA governor; trips 60/100/115 °C. Please review. Assisted-by: Claude Opus 5.5 |
83a0fe3 to
8d5e6d5
Compare
|
Blockers: 3. The driver half is sound. When the node has
Nit: the binding text gives the sensor-1000 rule, but the driver comment calls the value "above any temperature channel index". A HW row: J815 with the trips taken from the machine: a 3-minute all-core soak with the die peak and the throttled P-cluster frequency reported, no critical trip, then 0 failed units, 0 SELinux denials and 0 new kernel errors on the default command line. Also boot J813 and J704 (same driver, no zone) with the tripless Assisted-by: LLM (Claude:Opus 5.5) |
8d5e6d5 to
8bb24d1
Compare
|
@RyanTheTide agreed on the trips.
On the nit: discovered channels have no build-time bound, so a The PR is now the binding + driver only. Assisted-by: LLM (Claude:Opus 5.5) |
|
Re-review of 8bb24d1: Blockers: 1. Earlier points: 1 (commit trailers) resolved: both commits carry only the human Signed-off-by. 2 and 3 (the J815 zone's estimated trips, and the figures quoted in the DT comment and commit message) resolved: the DTS commit and its numbers are gone. The nit is resolved another way: since discovered channels have no build-time bound, probe now keeps the tripless zone with a warning when
HW row: J815, J813 and J704 on this head with the default command line: Assisted-by: LLM (Claude:Opus 5.5) |
A node with apple,discover-temperatures has no stable channel indices, so a thermal zone cannot name one of its temperature channels. Let such a node be a thermal sensor provider for one sensor, 1000: the hottest of its apple,soc-die-keys readings. A zone on it comes in addition to the driver's tripless macsmc_soc_die zone, which in-kernel users look up by name. Signed-off-by: Nick <nekreshen@yandex.ru>
A board that discovers its SMC temperatures (apple,discover-temperatures, as the M5 Airs do) has no stable channel indices, so a device tree thermal zone cannot name one of its temperature channels, and the hottest-die zone is registered without trips. Such a board then has no thermal policy of its own. When the node is a thermal sensor provider, offer the hottest-die reading as sensor 1000, above any channel index the hwmon core registers. A zone on it gets the board's trips and cooling maps. The tripless macsmc_soc_die zone is still registered in every case: the asahi GPU drivers' governors (g17 and m3) read the SoC hotspot from that zone by name, and a device tree zone's name cannot be macsmc_soc_die (no '_' in a node name). Discovered channels are not bounded at build time, so a node with 1000 or more of them keeps the tripless zone, with a warning. No board uses it yet: the J815 zone waits for limits the boot loader reads from the machine. Signed-off-by: Nick <nekreshen@yandex.ru>
8bb24d1 to
dfdafea
Compare
|
@RyanTheTide fixed in
I didn't take the helper route. It means a cross-module symbol from drm/asahi into macsmc-hwmon (or a Checks:
The rows (J815/J813/J704 with Assisted-by: LLM (Claude:Opus 5.5) |
|
Re-review of dfdafea: no blockers. The earlier point is resolved. One thing to know: the DT-zone attempt also runs on nodes without Rows: J815, J813 and J704 on dfdafea (owed by the author), each with Assisted-by: LLM (Claude:Opus 5.5) |
Infrastructure for a SoC die thermal zone on boards that discover their SMC temperatures. The J815's zone itself is left out until its limits come from the machine (below).
A node with
apple,discover-temperatures(the M5 Airs) has no stable channel indices, so a device tree thermal zone can't name one of its channels, and the hottest-die zone is registered without trips.Change
macsmc_soc_diezone is registered in every case, next to a device tree zone. The asahi GPU drivers' governors (g17thermal.rs, m3m3_thermal.rs) read the SoC hotspot from that zone by name, and a device tree zone can't take that name (no_in a node name). So a board that adds a zone keeps the governors' input. The binding now says the DT zone comes in addition to the named one.Changed on this head (review): the J815 DTS commit (a zone with estimated sustainable power and trips) is dropped, and so are the numbers it quoted. A critical trip that is guessed can shut down a healthy Mac, or come too late. The J815 keeps the tripless
macsmc_soc_diezone, and the PMP and SMC still enforce the hardware limits. The zone comes back once the boot loader publishes the package's sustainable power target and die limits from the machine. That is a separate aura change, not started. Rebased ontointegration/aurorab241e35.Checks on this head:
macsmc-hwmon.cbuilds withW=1and no warnings at both commits,dt_binding_checkonapple,smc-hwmon.yamlandCHECK_DTBSon the J813/J815 DTBs are clean, andcheckpatch --strictis clean.Still owed (HW rows): J815, J813 and J704 (same driver, no zone) on this head, each with the tripless
macsmc_soc_diezone still registered; 0 failed units, 0 new kernel errors.Part of the J815 bring-up: board results are summarised in discussion #135.
Assisted-by: LLM (Claude:Opus 5.5)